Fix Job Tracking Issue #1071
Merged
Fix Job Tracking Issue #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgardens
requested review from
sherifnada,
michel-tricot and
ChristopheDuong
sherifnada
approved these changes
Nov 24, 2020
| return switch (output.getStatus()) { | ||
| case SUCCEEDED -> JobStatus.COMPLETED; | ||
| case FAILED -> JobStatus.FAILED; | ||
| default -> throw new IllegalStateException("Unknown state " + output.getStatus()); |
There was a problem hiding this comment.
This should probably log instead of throw an exception
There was a problem hiding this comment.
mb -- I misread. This is correct.
There was a problem hiding this comment.
I thoguth this was only used in tracking code not in business logic. Wouldn't have wanted to fail over tracking issues.
cgardens
commented
Nov 24, 2020
.env.dev
Outdated
| @@ -13,7 +13,7 @@ WORKSPACE_ROOT=/tmp/workspace | |||
| WORKSPACE_DOCKER_MOUNT=/tmp/dev_root/workspace | |||
| LOCAL_ROOT=/tmp/airbyte_local | |||
| LOCAL_DOCKER_MOUNT=/tmp/airbyte_local | |||
| TRACKING_STRATEGY=logging | |||
| TRACKING_STRATEGY=segment | |||
There was a problem hiding this comment.
todo - revert before merge. going to do this separately.
cgardens
force-pushed
the
cgardens/debug_segment_issues
branch
from
a7af49f to
8b57fef
Compare
cgardens
commented
Nov 25, 2020
| @@ -142,24 +142,21 @@ public void writeStandardDestinationDefinition(final StandardDestinationDefiniti | |||
| destinationDefinition); | |||
| } | |||
|
|
|||
| public SourceConnection getSourceConnection(final UUID sourceId) | |||
There was a problem hiding this comment.
blank space changes.
cgardens
commented
Nov 25, 2020
| @@ -159,12 +159,6 @@ public SourceDefinitionSpecificationRead getSourceDefinitionSpecification(Source | |||
| final String imageName = DockerUtils.getTaggedImageName(source.getDockerRepository(), source.getDockerImageTag()); | |||
| final ConnectorSpecification spec = getConnectorSpecification(imageName); | |||
|
|
|||
| TrackingClientSingleton.get().track("get_source_spec", ImmutableMap.<String, Object>builder() | |||
There was a problem hiding this comment.
this is just throwing money in a bucket and lighting it on fire.
This was referenced Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1064
What