Source Greenhouse #1076
Merged
Source Greenhouse #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugene-kulak
force-pushed
the
source-greenhouse
branch
3 times, most recently
from
f9a475a to
30520ad
Compare
|
based on #1068 - not anymore, rebased on master |
eugene-kulak
force-pushed
the
source-greenhouse
branch
2 times, most recently
from
bb9c70e to
8aa0c1a
Compare
sherifnada
reviewed
Dec 2, 2020
There was a problem hiding this comment.
This is pretty close to shipping, the main two things remaining are:
- merge master to pick up the changes in this PR Freshdesk fixes #1145 and resolve any conflicts
- run
./tools/integrations/manage.sh build airbyte-integrations/connectors/source-greenhousefrom the repo root and verify the tests are passing
| def __init__(self, *args, **kwargs): | ||
| super().__init__(*args, **kwargs) | ||
|
|
||
| # FIXME: patch missing endpoint |
There was a problem hiding this comment.
what's this comment about?
There was a problem hiding this comment.
The current Greenhouse package doesn't support custom_fields endpoint, so I have to patch internals manually here. I have created a PR for the Greenhouse package, but it doesn't seem to be very much alive.
There was a problem hiding this comment.
I have improved the comment to clarify this
| self._uris["direct"]["custom_fields"] = {"list": "custom_fields", "retrieve": "custom_field/{id}"} | ||
|
|
||
| def __getattr__(self, key): | ||
| # FIXME: patch auth object to avoid bug with serialization of None |
There was a problem hiding this comment.
is this suppsed to be done in this PR?
There was a problem hiding this comment.
No, the latest package has an issue that is fixed in the master branch, we just need it to be released to drop this line
| @@ -0,0 +1,45 @@ | |||
| # Greenhouse | |||
|
|
|||
| ## Overview | |||
airbyte-integrations/connectors/source-greenhouse/Dockerfile.test
Outdated
Show resolved
Hide resolved
|
|
to use it append `&template=source.md` to standard MR URL
sherifnada
approved these changes
Dec 3, 2020
Merged
davydov-d
added a commit
that referenced
this pull request
Dec 27, 2022
davydov-d
added a commit
that referenced
this pull request
Dec 27, 2022
davydov-d
added a commit
that referenced
this pull request
Dec 27, 2022
davydov-d
added a commit
that referenced
this pull request
Dec 27, 2022
davydov-d
added a commit
that referenced
this pull request
Dec 28, 2022
grubberr
added a commit
that referenced
this pull request
Jan 5, 2023
…n-usable-stream Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add new source Greenhouse
How
Describe the solution
Checklist
Recommended reading order
test.javacomponent.ts