set memory limit/request for blob storage connectors #10861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmossman
commented
Mar 4, 2022
Comment on lines
-192
to
-198
| # this is our first example of setting these requirements. they are guesses, not data driven. | ||
| # setting default cpu higher, because we have found that check and discover can be cpu constrained for dbs. | ||
| default: | ||
| cpu_limit: "1.0" | ||
| cpu_request: "1.0" | ||
| memory_limit: "300Mi" | ||
| memory_request: "300Mi" |
There was a problem hiding this comment.
Removing this because these resource requirements are not currently applied to anything besides sync jobs, so having this here is a bit misleading. I created an issue to add support for this here: https://github.com/airbytehq/airbyte/issues/10862
lmossman
commented
Mar 4, 2022
Comment on lines
-203
to
-204
| cpu_limit: "0.5" | ||
| cpu_request: "0.5" |
There was a problem hiding this comment.
I removed the cpu_limit and cpu_request requirements because we are going to set the default CPU requirements for all jobs to 0.5, and if we decide to change that default in the future then having this requirement here will prevent that change from affecting snowflake connectors.
benmoriceau
approved these changes
Mar 4, 2022
cgardens
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolves https://github.com/airbytehq/airbyte-cloud/issues/1082
Set the connector-definition level memory limit/request resource requirement for all blob storage connectors to 1Gi, as recommended by the connectors team. See issue for details.
How
Uses the sync jobSpecific resource requirement configuration in the destination definition seed yaml to set the memory limit/request to 1Gi for all blob storage connectors.
This PR also removes some resource requirement configuration from the snowflake connector, as noted in the comments below
Recommended reading order
x.javay.python