Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10148 BigQuery Destination/Denormalized Destination spec updates #11620

Merged
merged 6 commits into from
Apr 2, 2022

Conversation

alexandr-shegeda
Copy link
Contributor

@alexandr-shegeda alexandr-shegeda commented Mar 31, 2022

What

In order to make documentation more efficient, we need to update fields description and actualize the links.

How

Update spec field description

🚨 User Impact 🚨

No impact, since fields description/title were updated.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Mar 31, 2022
@alexandr-shegeda alexandr-shegeda temporarily deployed to more-secrets March 31, 2022 11:28 Inactive
@alexandr-shegeda alexandr-shegeda temporarily deployed to more-secrets March 31, 2022 11:28 Inactive
@alexandr-shegeda alexandr-shegeda temporarily deployed to more-secrets April 2, 2022 16:10 Inactive
@alexandr-shegeda alexandr-shegeda temporarily deployed to more-secrets April 2, 2022 16:10 Inactive
@alexandr-shegeda
Copy link
Contributor Author

alexandr-shegeda commented Apr 2, 2022

/test connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/2082578886
✅ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/2082578886
Python tests coverage:

Name                                                                                                                            Stmts   Miss  Cover
---------------------------------------------------------------------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                                                                                          2      0   100%
normalization/transform_catalog/reserved_keywords.py                                                                               13      0   100%
normalization/transform_catalog/__init__.py                                                                                         2      0   100%
normalization/destination_type.py                                                                                                  13      0   100%
normalization/__init__.py                                                                                                           4      0   100%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/bases/airbyte-protocol/airbyte_protocol/models/airbyte_protocol.py     124      0   100%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/bases/airbyte-protocol/airbyte_protocol/models/__init__.py               1      0   100%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/bases/airbyte-protocol/airbyte_protocol/__init__.py                      2      0   100%
normalization/transform_catalog/destination_name_transformer.py                                                                   155      8    95%
normalization/transform_config/transform.py                                                                                       168     31    82%
normalization/transform_catalog/table_name_registry.py                                                                            174     34    80%
normalization/transform_catalog/utils.py                                                                                           33      7    79%
normalization/transform_catalog/catalog_processor.py                                                                              143     77    46%
normalization/transform_catalog/transform.py                                                                                       45     26    42%
normalization/transform_catalog/stream_processor.py                                                                               524    337    36%
---------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                                            1403    520    63%

@alexandr-shegeda
Copy link
Contributor Author

alexandr-shegeda commented Apr 2, 2022

/publish connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/2082726405
✅ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/2082726405

@alexandr-shegeda
Copy link
Contributor Author

alexandr-shegeda commented Apr 2, 2022

/publish connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/2082727454
✅ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/2082727454

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants