Source Github: re-implement incremental for `reviews` stream #11623

grubberr · 2022-03-31T11:29:23Z

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

Reviews stream implements incremental sync relying on submitted_at cursor_field
but this filed can be missed in objects of PENDING state and it's not updated.

https://docs.github.com/en/rest/reference/pulls#create-a-review-for-a-pull-request

Current implementation of incremental is wrong.

How

I have re-implemented incremental sync using updated_at field of parent stream PullRequests

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

codecov · 2022-03-31T11:35:00Z

Codecov Report

❗ No coverage uploaded for pull request base (master@43df422). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head bac7e9b differs from pull request most recent head 5ea656d. Consider uploading reports for the commit 5ea656d to get more accurate results

@@            Coverage Diff            @@
##             master   #11623   +/-   ##
=========================================
  Coverage          ?   90.76%           
=========================================
  Files             ?        3           
  Lines             ?      574           
  Branches          ?        0           
=========================================
  Hits              ?      521           
  Misses            ?       53           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43df422...5ea656d. Read the comment docs.

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-03-31T12:02:15Z

/test connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/2070876628
✅ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/2070876628
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                        Stmts   Miss  Cover
-----------------------------------------------
source_github/__init__.py       2      0   100%
source_github/streams.py      484     45    91%
source_github/source.py        89     24    73%
-----------------------------------------------
TOTAL                         575     69    88%

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-03-31T19:00:35Z

/test connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/2073047187
✅ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/2073047187
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                        Stmts   Miss  Cover
-----------------------------------------------
source_github/__init__.py       2      0   100%
source_github/streams.py      484     29    94%
source_github/source.py        89     24    73%
-----------------------------------------------
TOTAL                         575     53    91%

grubberr · 2022-04-01T05:41:29Z

/test connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/2075377174
❌ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/2075377174
🐛 https://gradle.com/s/msdgjojhm5hvw

grubberr · 2022-04-01T05:57:55Z

/test connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/2075423630
❌ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/2075423630
🐛 https://gradle.com/s/jzehqr2p2to7a

docs/integrations/sources/github.md

airbyte-integrations/connectors/source-github/unit_tests/test_stream.py

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-04-01T15:59:24Z

/test connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/2078367447
✅ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/2078367447
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                        Stmts   Miss  Cover
-----------------------------------------------
source_github/__init__.py       2      0   100%
source_github/streams.py      484     29    94%
source_github/source.py        89     24    73%
-----------------------------------------------
TOTAL                         575     53    91%

airbyte-integrations/connectors/source-github/source_github/streams.py

midavadim · 2022-04-01T21:30:08Z

PR can be merged int main without airbyte review

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-04-01T21:48:09Z

/test connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/2079906494
✅ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/2079906494
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                        Stmts   Miss  Cover
-----------------------------------------------
source_github/__init__.py       2      0   100%
source_github/streams.py      484     29    94%
source_github/source.py        89     24    73%
-----------------------------------------------
TOTAL                         575     53    91%

grubberr · 2022-04-01T21:59:07Z

/publish connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/2079939622
✅ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/2079939622

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

bump version 0.2.25 -> 0.2.26

b49a01b

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr self-assigned this Mar 31, 2022

grubberr linked an issue Mar 31, 2022 that may be closed by this pull request

Source Github: get_updated_state problem on reviews stream #11566

Closed

github-actions bot added the area/connectors Connector related issues label Mar 31, 2022

grubberr temporarily deployed to more-secrets March 31, 2022 11:31 Inactive

change submitted_at -> parent_updated_at cursor_field

264fdda

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr temporarily deployed to more-secrets March 31, 2022 11:58 Inactive

grubberr changed the title ~~bump version 0.2.25 -> 0.2.26~~ Source Github: re-implement incremental for reviews stream Mar 31, 2022

grubberr added 2 commits March 31, 2022 16:21

Merge branch 'master' into grubberr/11566-source-github-reviews-fix2

0e70039

github.md updated

070077e

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

github-actions bot added the area/documentation Improvements or additions to documentation label Mar 31, 2022

grubberr temporarily deployed to more-secrets March 31, 2022 13:31 Inactive

test_stream_reviews_incremental_read added

4b94621

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr temporarily deployed to more-secrets March 31, 2022 18:54 Inactive

Merge branch 'master' into grubberr/11566-source-github-reviews-fix2

8ce5ed7

grubberr temporarily deployed to more-secrets April 1, 2022 05:42 Inactive

grubberr requested review from bazarnov and davydov-d April 1, 2022 05:49

bazarnov reviewed Apr 1, 2022

View reviewed changes

docs/integrations/sources/github.md Outdated Show resolved Hide resolved

airbyte-integrations/connectors/source-github/unit_tests/test_stream.py Show resolved Hide resolved

davydov-d approved these changes Apr 1, 2022

View reviewed changes

grubberr added 2 commits April 1, 2022 13:22

Merge branch 'master' into grubberr/11566-source-github-reviews-fix2

a0dcc79

improve docs

43702f9

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr requested a review from bazarnov April 1, 2022 10:29

grubberr temporarily deployed to more-secrets April 1, 2022 10:30 Inactive

bazarnov approved these changes Apr 1, 2022

View reviewed changes

grubberr requested a review from midavadim April 1, 2022 12:51

Merge branch 'master' into grubberr/11566-source-github-reviews-fix2

f1de984

grubberr temporarily deployed to more-secrets April 1, 2022 16:01 Inactive

grubberr requested a review from ChristopheDuong April 1, 2022 16:39

midavadim approved these changes Apr 1, 2022

View reviewed changes

airbyte-integrations/connectors/source-github/source_github/streams.py Outdated Show resolved Hide resolved

grubberr added 2 commits April 2, 2022 00:36

Merge branch 'master' into grubberr/11566-source-github-reviews-fix2

f0fad7c

parent_updated_at -> pull_request_updated_at

bac7e9b

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr temporarily deployed to more-secrets April 1, 2022 21:49 Inactive

source_specs.yaml updated

5ea656d

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr merged commit e9946c9 into master Apr 1, 2022

grubberr deleted the grubberr/11566-source-github-reviews-fix2 branch April 1, 2022 22:11

grubberr temporarily deployed to more-secrets April 1, 2022 22:12 Inactive

octavia-squidington-iii mentioned this pull request Apr 5, 2022

Bump Airbyte version from 0.35.64-alpha to 0.35.65-alpha #11722

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Github: re-implement incremental for `reviews` stream #11623

Source Github: re-implement incremental for `reviews` stream #11623

grubberr commented Mar 31, 2022 •

edited

Loading

codecov bot commented Mar 31, 2022 •

edited

Loading

grubberr commented Mar 31, 2022 •

edited by github-actions bot

Loading

grubberr commented Mar 31, 2022 •

edited by github-actions bot

Loading

grubberr commented Apr 1, 2022 •

edited by github-actions bot

Loading

grubberr commented Apr 1, 2022 •

edited by github-actions bot

Loading

grubberr commented Apr 1, 2022 •

edited by github-actions bot

Loading

midavadim commented Apr 1, 2022

grubberr commented Apr 1, 2022 •

edited by github-actions bot

Loading

grubberr commented Apr 1, 2022 •

edited by github-actions bot

Loading

Source Github: re-implement incremental for reviews stream #11623

Source Github: re-implement incremental for reviews stream #11623

Conversation

grubberr commented Mar 31, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Tests

codecov bot commented Mar 31, 2022 • edited Loading

Codecov Report

grubberr commented Mar 31, 2022 • edited by github-actions bot Loading

grubberr commented Mar 31, 2022 • edited by github-actions bot Loading

grubberr commented Apr 1, 2022 • edited by github-actions bot Loading

grubberr commented Apr 1, 2022 • edited by github-actions bot Loading

grubberr commented Apr 1, 2022 • edited by github-actions bot Loading

midavadim commented Apr 1, 2022

grubberr commented Apr 1, 2022 • edited by github-actions bot Loading

grubberr commented Apr 1, 2022 • edited by github-actions bot Loading

Source Github: re-implement incremental for `reviews` stream #11623

Source Github: re-implement incremental for `reviews` stream #11623

grubberr commented Mar 31, 2022 •

edited

Loading

codecov bot commented Mar 31, 2022 •

edited

Loading

grubberr commented Mar 31, 2022 •

edited by github-actions bot

Loading

grubberr commented Mar 31, 2022 •

edited by github-actions bot

Loading

grubberr commented Apr 1, 2022 •

edited by github-actions bot

Loading

grubberr commented Apr 1, 2022 •

edited by github-actions bot

Loading

grubberr commented Apr 1, 2022 •

edited by github-actions bot

Loading

grubberr commented Apr 1, 2022 •

edited by github-actions bot

Loading

grubberr commented Apr 1, 2022 •

edited by github-actions bot

Loading