Redshift SUPER type #12064
Merged
Redshift SUPER type #12064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or raw JSON data (#9407) * airbyte-5050: Added support of SUPER datatype for destination-redshift on the Java side Co-authored-by: Oleksandr Tsukanov <alexander.tsukanovvv@gmail.com> Co-authored-by: user <user@HRK1-LMC-A13537.local> Co-authored-by: Sergey Chvalyuk <grubberr@gmail.com> Co-authored-by: Christophe Duong <christophe.duong@gmail.com> Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com> Co-authored-by: Oleksandr Tsukanov <alexander.tsukanovvv@gmail.com> Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
github-actions
bot
added
area/connectors
|
Oleksandr Tsukanov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
|
/test connector=bases/base-normalization
|
This was referenced Apr 15, 2022
|
/test connector=connectors/destination-redshift
|
|
/test connector=connectors/destination-redshift
|
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
|
/test connector=bases/base-normalization
|
edgao
approved these changes
Apr 19, 2022
after resolving them| } | ||
| transform_catalog.process_catalog() | ||
|
|
||
| run_destination_process(destination_type, tmp_path, messages_file1, "destination_catalog.json", docker_tag="0.3.29") |
There was a problem hiding this comment.
nitpick: let's a comment explaining why this is using 0.3.29 (something like 0.3.29 is the highest destination-redshift version that did not use the SUPER type)
| dbt_test_utils.dbt_run(destination_type, tmp_path, force_full_refresh=True) | ||
| run_destination_process(destination_type, tmp_path, messages_file2, "destination_catalog.json", docker_tag="dev") | ||
| dbt_test_utils.dbt_run(destination_type, tmp_path, force_full_refresh=False) | ||
| dbt_test(destination_type, tmp_path) |
There was a problem hiding this comment.
for my understanding: what is this validating? (I think it's testing that DBT correctly read the SUPER-typed _raw table and created the normalized tables?)
There was a problem hiding this comment.
DBT correctly read the SUPER-typed _raw table and created the normalized tables
this case already tested by old tests because we switch to SUPER type as default
Adding test_redshift_normalization_migration I wanted to test migration process:
- load data to
_raw_airbyte_table using old VARCHAR type - do normalization for old VARCHAR type
- convert VARCHAR -> SUPER of
_raw_airbyte_table and append data - convert VARCHAR -> SUPER of normalization tables and append data
|
/test connector=bases/base-normalization
|
|
also, @noahkawasaki-airbyte fyi - this is a pretty interesting redshift+normalization PR. There's quite a lot going on here, so LMK when you questions! |
|
/test connector=bases/base-normalization
|
|
/test connector=connectors/destination-redshift
|
|
/publish connector=connectors/destination-redshift
|
|
/publish connector=bases/base-normalization run-tests=false
|
This was
linked to
issues
Apr 20, 2022
This was referenced Apr 20, 2022
14 tasks
suhomud
pushed a commit
that referenced
this pull request
May 23, 2022
* 🎉 Destination Redshift: Use SUPER data type on Redshift destination for raw JSON data (#9407) Co-authored-by: Oleksandr Tsukanov <alexander.tsukanovvv@gmail.com> Co-authored-by: Sergey Chvalyuk <grubberr@gmail.com> Co-authored-by: Christophe Duong <christophe.duong@gmail.com> Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
This was referenced Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
add support of amazon SUPER type
https://docs.aws.amazon.com/redshift/latest/dg/r_SUPER_type.html
How
Describe the solution
Recommended reading order
x.javay.python🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/SUMMARY.mddocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampledocs/integrations/README.mdairbyte-integrations/builds.mdAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing/publishcommand described hereUpdating a connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing/publishcommand described hereConnector Generator
-scaffoldin their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplatesthen checking in your changesTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.