Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Destination Namespace default value #12200

Merged
merged 4 commits into from
Apr 21, 2022
Merged

Add Destination Namespace default value #12200

merged 4 commits into from
Apr 21, 2022

Conversation

teallarson
Copy link
Contributor

@teallarson teallarson commented Apr 20, 2022 •
edited
Loading

What

Closes https://github.com/airbytehq/airbyte-cloud/issues/1434
Adds back a default for the Destination Namespace when creating a connection.

default namespace

How

Adding the connection's source as the initialValue in the Formik config.

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@github-actions github-actions bot added area/frontend area/platform issues related to the platform labels Apr 20, 2022
@teallarson teallarson changed the title Teal desination namespace default Add Destination Namespace default value Apr 20, 2022
@teallarson teallarson marked this pull request as ready for review April 20, 2022 20:04
@teallarson teallarson requested a review from a team as a code owner April 20, 2022 20:04
edmundito
edmundito reviewed Apr 20, 2022
View reviewed changes
airbyte-webapp/src/views/Connection/ConnectionForm/formConfig.tsx
@@ -273,7 +273,7 @@ const useInitialValues = (
syncCatalog: initialSchema,
schedule: connection.schedule !== undefined ? connection.schedule : DEFAULT_SCHEDULE,
prefix: connection.prefix || "",
namespaceDefinition: connection.namespaceDefinition,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with this area of the code, but should it try to use the namespaceDefinition of the connection first before falling back to the default? Have you tested this when both creating and also editing a new connection?

Copy link
Contributor Author

@teallarson teallarson Apr 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it should. Fixed!

@teallarson teallarson merged commit 39b074e into master Apr 21, 2022
@teallarson teallarson deleted the teal-desination-namespace-default branch April 21, 2022 14:03
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Apr 21, 2022
Merged
suhomud pushed a commit that referenced this pull request May 23, 2022
@teallarson @suhomud
Add Destination Namespace default value (#12200)
e6fe351 
* default streamOption is source format

* use formik initialValue instead of form defaultValue

* cleanup

* initial value should be namespaceDefinition if exists
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmundito edmundito edmundito approved these changes

Assignees
No one assigned
Labels
area/platform issues related to the platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teallarson @edmundito