Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Smartsheets: fix docs to certify for Beta #12203

Merged
merged 12 commits into from
Apr 28, 2022
Merged

Source Smartsheets: fix docs to certify for Beta #12203

merged 12 commits into from
Apr 28, 2022

Conversation

davydov-d
Copy link
Collaborator

What

Doc fixes according to the Beta certification checklist

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Apr 20, 2022
@codecov
Copy link

codecov bot commented Apr 20, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@a33cbf6). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #12203   +/-   ##
=========================================
  Coverage          ?   96.61%           
=========================================
  Files             ?        4           
  Lines             ?      118           
  Branches          ?        0           
=========================================
  Hits              ?      114           
  Misses            ?        4           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a33cbf6...e415d24. Read the comment docs.

midavadim
midavadim approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@midavadim midavadim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update can be merged without Airbyte review

@davydov-d davydov-d requested a review from misteryeo April 27, 2022 19:30
@davydov-d davydov-d self-assigned this Apr 27, 2022
@davydov-d
Copy link
Collaborator Author

davydov-d commented Apr 28, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-smartsheets

🕑 connectors/source-smartsheets https://github.com/airbytehq/airbyte/actions/runs/2239444556
❌ Failed to publish connectors/source-smartsheets
❌ Couldn't auto-bump version for connectors/source-smartsheets

@davydov-d davydov-d merged commit 87beaf5 into master Apr 28, 2022
@davydov-d davydov-d deleted the ddavydov/11759-smartsheets-to-beta-doc-fixes branch April 28, 2022 13:04
@davydov-d
Copy link
Collaborator Author

/publish connector=connectors/source-smartsheets

This was referenced Apr 28, 2022
Merged
Closed
@davydov-d
Copy link
Collaborator Author

/publish connector=connectors/source-smartsheets

@davydov-d davydov-d restored the ddavydov/11759-smartsheets-to-beta-doc-fixes branch April 29, 2022 07:48
@davydov-d
Copy link
Collaborator Author

davydov-d commented Apr 29, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-smartsheets

🕑 connectors/source-smartsheets https://github.com/airbytehq/airbyte/actions/runs/2245015937
🚀 Successfully published connectors/source-smartsheets
🚀 Auto-bumped version for connectors/source-smartsheets
✅ connectors/source-smartsheets https://github.com/airbytehq/airbyte/actions/runs/2245015937

@davydov-d davydov-d mentioned this pull request Apr 29, 2022
Closed
16 tasks
suhomud pushed a commit that referenced this pull request May 23, 2022
@davydov-d @suhomud
Source Smartsheets: fix docs to certify for Beta (#12203)
7e6be7d 
* #5520 fix scrambled columns bug

* #5520 source smartsheets: add changelog item

* #5520 move pytest to optional setup requirements

* #12003 source smartsheets: implement incremental read + tests

* #12003 source smartsheet: add changelog

* #12003 source smartsheets: fix merge conflict on unit tests

* #12003 source smartsheets: fix startdate in spec

* #11759 source smartsheets: fix doc to certify for Beta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@midavadim midavadim midavadim approved these changes

@misteryeo misteryeo Awaiting requested review from misteryeo

Assignees

@davydov-d davydov-d

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davydov-d @midavadim @AlexandruManolache1