-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove stale required key in OpenAPI config #12341
Remove stale required key in OpenAPI config #12341
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for spotting this. How did you find it? How is this a blocker for you (just for my own curiosity)?
I'm running the CI to test on a non forked branch and will get back for merge.
I confirm that CI tests are passing. I successfully created a connection from a UI with a build on this branch. |
Yes, I have TypeScript definitions for AirByte API which is generated from this config file, and this issue leads to a wrong definition which is:
and the expected is:
For me, I have to maintiain a patch memo and remind my self every time when the definition is generated. It is really a head burden. |
What
There is a key in required list, but not in properties config, issue: #12340
How
Remove the key in required list.
Recommended reading order
src/main/openapi/config.yaml
:components.schemas.WebBackendConnectionCreate