🐛 Source Hubspot: correct createAt and updateAd data type #12424

marcosmarxm · 2022-04-27T23:31:22Z

What

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

marcosmarxm · 2022-04-27T23:32:15Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2236288110
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2236288110
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              285    106    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  896    259    71%
Name                         Stmts   Miss  Cover
------------------------------------------------
source_hubspot/errors.py         6      0   100%
source_hubspot/__init__.py       2      0   100%
source_hubspot/streams.py      707     56    92%
source_hubspot/source.py        69     12    83%
------------------------------------------------
TOTAL                          784     68    91%

codecov · 2022-04-27T23:40:35Z

Codecov Report

❗ No coverage uploaded for pull request base (master@03a6b6b). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #12424   +/-   ##
=========================================
  Coverage          ?   91.32%           
=========================================
  Files             ?        4           
  Lines             ?      784           
  Branches          ?        0           
=========================================
  Hits              ?      716           
  Misses            ?       68           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03a6b6b...64225a3. Read the comment docs.

marcosmarxm · 2022-04-28T13:19:33Z

/publish connector=connectors/source-hubspot auto-bump-version=false

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2239538678
❌ Failed to publish connectors/source-hubspot

marcosmarxm · 2022-04-28T13:35:11Z

/publish connector=connectors/source-hubspot auto-bump-version=false

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2239628852
❌ Failed to publish connectors/source-hubspot

marcosmarxm · 2022-04-28T13:52:17Z

/publish connector=connectors/source-hubspot auto-bump-version=false

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2239725348
🚀 Successfully published connectors/source-hubspot
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2239725348

* correct createAt and updateAd data type * bump connectorversion * bump connector version again

correct createAt and updateAd data type

457ffbd

github-actions bot added the area/connectors Connector related issues label Apr 27, 2022

marcosmarxm requested review from alafanechere and harshithmullapudi April 28, 2022 02:38

alafanechere approved these changes Apr 28, 2022

View reviewed changes

bump connectorversion

031210e

github-actions bot added the area/documentation Improvements or additions to documentation label Apr 28, 2022

marcosmarxm temporarily deployed to more-secrets April 28, 2022 13:37 Inactive

bump connector version again

64225a3

marcosmarxm temporarily deployed to more-secrets April 28, 2022 13:54 Inactive

marcosmarxm merged commit e0902e6 into master Apr 28, 2022

marcosmarxm deleted the marcos/source-hubspot-correct-schema branch April 28, 2022 16:00

This was referenced Apr 28, 2022

Bump Airbyte version from 0.36.4-alpha to 0.36.5-alpha #12448

Merged

Bump Airbyte version from 0.36.4-alpha to 0.36.5-alpha #12453

Closed

suhomud pushed a commit that referenced this pull request May 23, 2022

🐛 Source Hubspot: correct createAt and updateAd data type (#12424)

863f023

* correct createAt and updateAd data type * bump connectorversion * bump connector version again

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Source Hubspot: correct createAt and updateAd data type #12424

🐛 Source Hubspot: correct createAt and updateAd data type #12424

marcosmarxm commented Apr 27, 2022 •

edited

Loading

marcosmarxm commented Apr 27, 2022 •

edited by github-actions bot

Loading

codecov bot commented Apr 27, 2022 •

edited

Loading

marcosmarxm commented Apr 28, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Apr 28, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Apr 28, 2022 •

edited by github-actions bot

Loading

🐛 Source Hubspot: correct createAt and updateAd data type #12424

🐛 Source Hubspot: correct createAt and updateAd data type #12424

Conversation

marcosmarxm commented Apr 27, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

marcosmarxm commented Apr 27, 2022 • edited by github-actions bot Loading

codecov bot commented Apr 27, 2022 • edited Loading

Codecov Report

marcosmarxm commented Apr 28, 2022 • edited by github-actions bot Loading

marcosmarxm commented Apr 28, 2022 • edited by github-actions bot Loading

marcosmarxm commented Apr 28, 2022 • edited by github-actions bot Loading

marcosmarxm commented Apr 27, 2022 •

edited

Loading

marcosmarxm commented Apr 27, 2022 •

edited by github-actions bot

Loading

codecov bot commented Apr 27, 2022 •

edited

Loading

marcosmarxm commented Apr 28, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Apr 28, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Apr 28, 2022 •

edited by github-actions bot

Loading