Update "empty" status in StatusIcon to "sleep" with new icon #12436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishnaglick
approved these changes
Apr 28, 2022
This was referenced Apr 28, 2022
suhomud
pushed a commit
that referenced
this pull request
May 23, 2022
* Update status icon empty state with new Moon icon Add StatusIcon storybook * Move PauseIcon to components/icons * Fix support for big status icon for inactive and empty * Rename status icon empty state to sleep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This updates the "empty" status of the
StatusIconcomponent to use the updated moon icon and renames the status tosleep. Also takes an opportunity to cleanup theStatusIconcomponentCloses #10842
How
components/iconsThe only status that doesn't work in "big" mode is currently the "loading" status.
Recommended reading order
Top to bottom