Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destination Clickhouse : Enable and fix DAT tests #12566

Merged
merged 2 commits into from
May 5, 2022
Merged

Destination Clickhouse : Enable and fix DAT tests #12566

merged 2 commits into from
May 5, 2022

Conversation

DoNotPanicUA
Copy link
Contributor

@DoNotPanicUA DoNotPanicUA commented May 4, 2022 •
edited
Loading

What

The Clickhouse destination fails the DAT tests. It means that we can't guarantee full data type compliance.

How

Enable DAT tests and fix all errors.

Recommended reading order

  1. ClickhouseTestDataComparator.java
  2. ClickhouseDestinationAcceptanceTest.java

@DoNotPanicUA DoNotPanicUA self-assigned this May 4, 2022
@github-actions github-actions bot added the area/connectors Connector related issues label May 4, 2022
@DoNotPanicUA DoNotPanicUA changed the title Destination Clickhouse : Destination Clickhouse : Enable and fix DAT tests May 4, 2022
@DoNotPanicUA

This comment was marked as outdated.

Sign in to view
@DoNotPanicUA
Copy link
Contributor Author

DoNotPanicUA commented May 4, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/destination-clickhouse

🕑 connectors/destination-clickhouse https://github.com/airbytehq/airbyte/actions/runs/2271857100
✅ connectors/destination-clickhouse https://github.com/airbytehq/airbyte/actions/runs/2271857100
No Python unittests run

@DoNotPanicUA
Copy link
Contributor Author

Followup ticket to fix the issue with the normalization run: #12582

@DoNotPanicUA DoNotPanicUA marked this pull request as ready for review May 4, 2022 19:32
@DoNotPanicUA DoNotPanicUA linked an issue May 4, 2022 that may be closed by this pull request
Run the new DAT(s) against all destinations and find destinations that are not compliant #9444
Closed
@DoNotPanicUA DoNotPanicUA merged commit b752d82 into master May 5, 2022
@DoNotPanicUA DoNotPanicUA deleted the aleonets/DAT-fix-clickhouse branch May 5, 2022 08:18
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request May 5, 2022
Merged
suhomud pushed a commit that referenced this pull request May 23, 2022
@DoNotPanicUA @suhomud
Destination Clickhouse : Enable and fix DAT tests (#12566)
637daec 
* enable DAT for the default clickhouse destination

* disable normalization in the tests fully due to broken normalization container for the Clickhouse.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sashaNeshcheret sashaNeshcheret sashaNeshcheret approved these changes

@alexandr-shegeda alexandr-shegeda Awaiting requested review from alexandr-shegeda

Assignees

@DoNotPanicUA DoNotPanicUA

Labels
area/connectors Connector related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run the new DAT(s) against all destinations and find destinations that are not compliant
2 participants
@DoNotPanicUA @sashaNeshcheret