bump GA connectors to latest version of python cdk #12685

pedroslopez · 2022-05-06T22:08:42Z

What

Bumps source-facebook-marketing, source-google-sheets and source-salesforce to CDK v0.1.56 to start emitting AirbyteTraceMessages on uncaught exceptions (see CDK update in #12593)

Also fixes up some changelogs that had not been updated

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

codecov · 2022-05-06T22:15:33Z

Codecov Report

❗ No coverage uploaded for pull request base (master@73c7fad). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #12685   +/-   ##
=========================================
  Coverage          ?   85.01%           
=========================================
  Files             ?       25           
  Lines             ?     1742           
  Branches          ?        0           
=========================================
  Hits              ?     1481           
  Misses            ?      261           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73c7fad...79fb8b5. Read the comment docs.

pedroslopez · 2022-05-06T22:43:58Z

/test connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/2284385208
✅ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/2284385208
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              285    106    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  896    259    71%
Name                                 Stmts   Miss  Cover
--------------------------------------------------------
source_salesforce/__init__.py            2      0   100%
source_salesforce/exceptions.py          8      1    88%
source_salesforce/api.py               150     19    87%
source_salesforce/streams.py           306     67    78%
source_salesforce/rate_limiting.py      22      6    73%
source_salesforce/source.py             77     33    57%
source_salesforce/utils.py               8      7    12%
--------------------------------------------------------
TOTAL                                  573    133    77%
Name                                 Stmts   Miss  Cover
--------------------------------------------------------
source_salesforce/utils.py               8      0   100%
source_salesforce/__init__.py            2      0   100%
source_salesforce/source.py             77      6    92%
source_salesforce/api.py               150     14    91%
source_salesforce/exceptions.py          8      1    88%
source_salesforce/rate_limiting.py      22      3    86%
source_salesforce/streams.py           306     43    86%
--------------------------------------------------------
TOTAL                                  573     67    88%

pedroslopez · 2022-05-06T22:44:06Z

/test connector=connectors/source-google-sheets

🕑 connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/2284385646
✅ connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/2284385646
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              285    106    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  896    259    71%
Name                                                Stmts   Miss  Cover
-----------------------------------------------------------------------
google_sheets_source/models/spreadsheet_values.py      12      0   100%
google_sheets_source/models/spreadsheet.py             34      0   100%
google_sheets_source/models/__init__.py                 2      0   100%
google_sheets_source/__init__.py                        2      0   100%
google_sheets_source/helpers.py                       139     26    81%
google_sheets_source/client.py                         22      5    77%
google_sheets_source/google_sheets_source.py          103     84    18%
-----------------------------------------------------------------------
TOTAL                                                 314    115    63%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 22 passed, 1 skipped in 128.67s (0:02:08) ===================

pedroslopez · 2022-05-06T22:44:20Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2284386456
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2284386456
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              285    106    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  896    259    71%
Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
source_facebook_marketing/streams/__init__.py                   2      0   100%
source_facebook_marketing/spec.py                              34      0   100%
source_facebook_marketing/__init__.py                           2      0   100%
source_facebook_marketing/api.py                               96     12    88%
source_facebook_marketing/streams/base_streams.py             127     27    79%
source_facebook_marketing/streams/common.py                    41     13    68%
source_facebook_marketing/streams/streams.py                   97     32    67%
source_facebook_marketing/source.py                            39     16    59%
source_facebook_marketing/streams/base_insight_streams.py     129     54    58%
source_facebook_marketing/streams/async_job.py                210    134    36%
source_facebook_marketing/streams/async_job_manager.py         78     60    23%
-------------------------------------------------------------------------------
TOTAL                                                         855    348    59%
Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
source_facebook_marketing/streams/async_job.py                210      0   100%
source_facebook_marketing/streams/__init__.py                   2      0   100%
source_facebook_marketing/spec.py                              34      0   100%
source_facebook_marketing/__init__.py                           2      0   100%
source_facebook_marketing/streams/common.py                    41      1    98%
source_facebook_marketing/source.py                            39      1    97%
source_facebook_marketing/streams/async_job_manager.py         78      3    96%
source_facebook_marketing/api.py                               96      9    91%
source_facebook_marketing/streams/base_insight_streams.py     129     13    90%
source_facebook_marketing/streams/streams.py                   97     22    77%
source_facebook_marketing/streams/base_streams.py             127     30    76%
-------------------------------------------------------------------------------
TOTAL                                                         855     79    91%

pedroslopez · 2022-05-06T23:08:31Z

/publish connector=connectors/source-google-sheets

🕑 connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/2284458205
🚀 Successfully published connectors/source-google-sheets
🚀 Auto-bumped version for connectors/source-google-sheets
✅ connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/2284458205

pedroslopez · 2022-05-06T23:08:43Z

/publish connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2284458798
🚀 Successfully published connectors/source-facebook-marketing
🚀 Auto-bumped version for connectors/source-facebook-marketing
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2284458798

pedroslopez · 2022-05-06T23:08:56Z

/publish connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/2284459774
🚀 Successfully published connectors/source-salesforce
🚀 Auto-bumped version for connectors/source-salesforce
✅ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/2284459774

…m/airbytehq/airbyte into pedroslopez/bump-ga-connector-cdk

* bump GA connectors to latest version of python cdk * update changelogs * fix changelogs * more changelog fixes * auto-bump connector version * auto-bump connector version * auto-bump connector version Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

bump GA connectors to latest version of python cdk

eb49768

github-actions bot added the area/connectors Connector related issues label May 6, 2022

pedroslopez added 2 commits May 6, 2022 18:19

update changelogs

4be2207

fix changelogs

4eefb71

github-actions bot added the area/documentation Improvements or additions to documentation label May 6, 2022

more changelog fixes

0229a5e

pedroslopez requested a review from sherifnada May 6, 2022 22:41

sherifnada approved these changes May 6, 2022

View reviewed changes

auto-bump connector version

c06c4f8

octavia-squidington-iii temporarily deployed to more-secrets May 6, 2022 23:23 Inactive

octavia-squidington-iii added 2 commits May 6, 2022 23:23

auto-bump connector version

5f7bf7e

Merge branch 'pedroslopez/bump-ga-connector-cdk' of https://github.co…

4e8fa00

…m/airbytehq/airbyte into pedroslopez/bump-ga-connector-cdk

octavia-squidington-iii temporarily deployed to more-secrets May 6, 2022 23:26 Inactive

octavia-squidington-iii added 2 commits May 6, 2022 23:28

auto-bump connector version

f65b822

Merge branch 'pedroslopez/bump-ga-connector-cdk' of https://github.co…

79fb8b5

…m/airbytehq/airbyte into pedroslopez/bump-ga-connector-cdk

octavia-squidington-iii temporarily deployed to more-secrets May 6, 2022 23:30 Inactive

pedroslopez merged commit 816fece into master May 7, 2022

pedroslopez deleted the pedroslopez/bump-ga-connector-cdk branch May 7, 2022 00:53

octavia-squidington-iii mentioned this pull request May 9, 2022

Bump Airbyte version from 0.37.0-alpha to 0.37.1-alpha #12703

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bump GA connectors to latest version of python cdk #12685

bump GA connectors to latest version of python cdk #12685

pedroslopez commented May 6, 2022 •

edited

Loading

codecov bot commented May 6, 2022 •

edited

Loading

pedroslopez commented May 6, 2022 •

edited by github-actions bot

Loading

pedroslopez commented May 6, 2022 •

edited by github-actions bot

Loading

pedroslopez commented May 6, 2022 •

edited by github-actions bot

Loading

pedroslopez commented May 6, 2022 •

edited by github-actions bot

Loading

pedroslopez commented May 6, 2022 •

edited by github-actions bot

Loading

pedroslopez commented May 6, 2022 •

edited by github-actions bot

Loading

bump GA connectors to latest version of python cdk #12685

bump GA connectors to latest version of python cdk #12685

Conversation

pedroslopez commented May 6, 2022 • edited Loading

What

Pre-merge Checklist

Community member or Airbyter

Airbyter

codecov bot commented May 6, 2022 • edited Loading

Codecov Report

pedroslopez commented May 6, 2022 • edited by github-actions bot Loading

pedroslopez commented May 6, 2022 • edited by github-actions bot Loading

pedroslopez commented May 6, 2022 • edited by github-actions bot Loading

pedroslopez commented May 6, 2022 • edited by github-actions bot Loading

pedroslopez commented May 6, 2022 • edited by github-actions bot Loading

pedroslopez commented May 6, 2022 • edited by github-actions bot Loading

pedroslopez commented May 6, 2022 •

edited

Loading

codecov bot commented May 6, 2022 •

edited

Loading

pedroslopez commented May 6, 2022 •

edited by github-actions bot

Loading

pedroslopez commented May 6, 2022 •

edited by github-actions bot

Loading

pedroslopez commented May 6, 2022 •

edited by github-actions bot

Loading

pedroslopez commented May 6, 2022 •

edited by github-actions bot

Loading

pedroslopez commented May 6, 2022 •

edited by github-actions bot

Loading

pedroslopez commented May 6, 2022 •

edited by github-actions bot

Loading