🎉 Source Bing Ads: implement `OAuth2.0` support, remove `redirect_uri`, change `Account ID` to `User ID` in spec #12937

bazarnov · 2022-05-17T19:58:18Z

What

Resolving:
#9972
#6294
#12488
#12939
#12490
#12925

How

edited spec.json to reflect oauth support
added support of old input configuration for easy connector update transition for Customers
edited client.py to support oauth config
added MicrosoftBingAdsOAuthFlow.java class - oauth implementation
edited spec.json to get rid of accounts, user_id, customer_id from input configuration, get these values from authenticated user instead.
increased unit_tests coverage up to 92%

🚨 User Impact 🚨

No impact expected.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

bazarnov · 2022-05-17T20:03:35Z

/test connector=connectors/source-bing-ads

🕑 connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/2341104891
✅ connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/2341104891
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        75      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_incremental.py        85     25    71%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              285    106    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  913    246    73%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_bing_ads/__init__.py       2      0   100%
source_bing_ads/cache.py         18      3    83%
source_bing_ads/source.py       252     83    67%
source_bing_ads/client.py        92     37    60%
source_bing_ads/reports.py      115     53    54%
-------------------------------------------------
TOTAL                           479    176    63%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 21 passed, 1 skipped in 147.48s (0:02:27) ===================

…-ads-to-beta

bazarnov · 2022-05-18T12:35:34Z

/test connector=connectors/source-bing-ads

🕑 connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/2345528837
✅ connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/2345528837
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        75      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_incremental.py        85     25    71%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              285    106    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  913    246    73%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_bing_ads/__init__.py       2      0   100%
source_bing_ads/cache.py         18      3    83%
source_bing_ads/source.py       252     83    67%
source_bing_ads/client.py        92     37    60%
source_bing_ads/reports.py      115     53    54%
-------------------------------------------------
TOTAL                           479    176    63%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 21 passed, 1 skipped in 154.24s (0:02:34) ===================

evantahler

This is my first time reviewing an oAuth addition, so I'll add @girarda as a reviewer as well

airbyte-config/init/src/main/resources/seed/source_definitions.yaml

airbyte-integrations/connectors/source-bing-ads/source_bing_ads/schemas/accounts.json

airbyte-integrations/connectors/source-bing-ads/source_bing_ads/spec.json

airbyte-oauth/src/main/java/io/airbyte/oauth/flows/MicrosoftBingAdsOAuthFlow.java

airbyte-integrations/connectors/source-bing-ads/acceptance-test-config.yml

airbyte-integrations/connectors/source-bing-ads/unit_tests/test_source.py

codecov · 2022-05-23T15:35:07Z

Codecov Report

❗ No coverage uploaded for pull request base (master@bb139ec). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head f53386b differs from pull request most recent head f82494c. Consider uploading reports for the commit f82494c to get more accurate results

@@            Coverage Diff            @@
##             master   #12937   +/-   ##
=========================================
  Coverage          ?   63.76%           
=========================================
  Files             ?        5           
  Lines             ?      483           
  Branches          ?        0           
=========================================
  Hits              ?      308           
  Misses            ?      175           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb139ec...f82494c. Read the comment docs.

midavadim · 2022-05-23T17:33:24Z

/test connector=connectors/source-bing-ads

🕑 connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/2372944213
✅ connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/2372944213
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_bing_ads/__init__.py       2      0   100%
source_bing_ads/source.py       252      9    96%
source_bing_ads/cache.py         18      1    94%
source_bing_ads/client.py        93     12    87%
source_bing_ads/reports.py      115     17    85%
-------------------------------------------------
TOTAL                           480     39    92%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 22 passed, 1 skipped in 278.17s (0:04:38) ===================

midavadim · 2022-05-23T17:50:05Z

/publish connector=connectors/source-bing-ads

🕑 connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/2373028262
🚀 Successfully published connectors/source-bing-ads
🚀 Auto-bumped version for connectors/source-bing-ads
✅ connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/2373028262

bazarnov added 2 commits May 17, 2022 22:44

implemented oauth support

36c54ed

bumped version

912de94

bazarnov self-assigned this May 17, 2022

github-actions bot added the area/connectors Connector related issues label May 17, 2022

This was linked to issues May 17, 2022

Source Bing Ads: change account id field name #9972

Closed

Source Bing Ads: support oauth #6294

Closed

bazarnov requested a review from lazebnyi May 17, 2022 20:02

added changelog

5b908f0

github-actions bot added the area/documentation Improvements or additions to documentation label May 17, 2022

bazarnov temporarily deployed to more-secrets May 17, 2022 20:09 Inactive

bazarnov added 2 commits May 17, 2022 23:12

changed releaseStage to beta

17c5b8c

Merge remote-tracking branch 'origin/master' into bazarnov/12238-bing…

cc14712

…-ads-to-beta

bazarnov linked an issue May 17, 2022 that may be closed by this pull request

🎉 Source Bing Ads: label Bing Ads as beta in the UI #12939

Closed

bazarnov temporarily deployed to more-secrets May 17, 2022 20:15 Inactive

bazarnov mentioned this pull request May 17, 2022

Source Bing Ads: support oauth #6294

Closed

1 task

bazarnov linked an issue May 18, 2022 that may be closed by this pull request

Source Bing Ads: redirect_url is not needed #12488

Closed

removed redirect_uri from spec

c4edca2

bazarnov temporarily deployed to more-secrets May 18, 2022 12:36 Inactive

bazarnov changed the title ~~🎉 Source Bing Ads: implement OAuth2.0 support~~ 🎉 Source Bing Ads: implement OAuth2.0 support, remove redirect_uri, change Account ID to User ID in spec May 18, 2022

airbytehq deleted a comment from codecov bot May 18, 2022

bazarnov linked an issue May 19, 2022 that may be closed by this pull request

Source Bing Ads: remove the user_id parameter from spec.json #12490

Closed

removed user_id, customer_id from spec

569e673

airbytehq deleted a comment from codecov bot May 19, 2022

bazarnov temporarily deployed to more-secrets May 19, 2022 08:57 Inactive

bazarnov temporarily deployed to more-secrets May 20, 2022 14:30 Inactive

airbytehq deleted a comment from codecov bot May 20, 2022

evantahler requested changes May 20, 2022

View reviewed changes

evantahler requested a review from girarda May 20, 2022 16:54

girarda reviewed May 20, 2022

View reviewed changes

airbyte-integrations/connectors/source-bing-ads/acceptance-test-config.yml Show resolved Hide resolved

airbyte-integrations/connectors/source-bing-ads/unit_tests/test_source.py Outdated Show resolved Hide resolved

bazarnov added 2 commits May 21, 2022 22:16

updated after review

b5ac71c

added oauth implementation java test

4836cd4

bazarnov requested review from girarda and evantahler May 21, 2022 21:49

airbytehq deleted a comment from codecov bot May 21, 2022

bazarnov temporarily deployed to more-secrets May 21, 2022 21:51 Inactive

updated spec

307bb20

girarda approved these changes May 23, 2022

View reviewed changes

evantahler approved these changes May 23, 2022

View reviewed changes

updated after review

17143c0

bazarnov temporarily deployed to more-secrets May 23, 2022 15:36 Inactive

updated docs

494341f

midavadim temporarily deployed to more-secrets May 23, 2022 17:03 Inactive

auto-bump connector version

f82494c

octavia-squidington-iii temporarily deployed to more-secrets May 23, 2022 18:07 Inactive

midavadim merged commit e56922f into master May 23, 2022

midavadim deleted the bazarnov/12238-bing-ads-to-beta branch May 23, 2022 18:22

octavia-squidington-iii mentioned this pull request May 25, 2022

Bump Airbyte version from 0.39.1-alpha to 0.39.2-alpha #13188

Merged

lazebnyi linked an issue Jun 6, 2022 that may be closed by this pull request

Source Bing Ads: should have at least 90% unit test coverage (currently 64%) #12925

Closed

lazebnyi mentioned this pull request Jun 6, 2022

Source Bing Ads: should have at least 90% unit test coverage (currently 64%) #12925

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Source Bing Ads: implement `OAuth2.0` support, remove `redirect_uri`, change `Account ID` to `User ID` in spec #12937

🎉 Source Bing Ads: implement `OAuth2.0` support, remove `redirect_uri`, change `Account ID` to `User ID` in spec #12937

bazarnov commented May 17, 2022 •

edited

Loading

bazarnov commented May 17, 2022 •

edited by github-actions bot

Loading

bazarnov commented May 18, 2022 •

edited by github-actions bot

Loading

evantahler left a comment

codecov bot commented May 23, 2022 •

edited

Loading

midavadim commented May 23, 2022 •

edited by github-actions bot

Loading

midavadim commented May 23, 2022 •

edited by github-actions bot

Loading

🎉 Source Bing Ads: implement OAuth2.0 support, remove redirect_uri, change Account ID to User ID in spec #12937

🎉 Source Bing Ads: implement OAuth2.0 support, remove redirect_uri, change Account ID to User ID in spec #12937

Conversation

bazarnov commented May 17, 2022 • edited Loading

What

How

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

bazarnov commented May 17, 2022 • edited by github-actions bot Loading

bazarnov commented May 18, 2022 • edited by github-actions bot Loading

evantahler left a comment

Choose a reason for hiding this comment

codecov bot commented May 23, 2022 • edited Loading

Codecov Report

midavadim commented May 23, 2022 • edited by github-actions bot Loading

midavadim commented May 23, 2022 • edited by github-actions bot Loading

🎉 Source Bing Ads: implement `OAuth2.0` support, remove `redirect_uri`, change `Account ID` to `User ID` in spec #12937

🎉 Source Bing Ads: implement `OAuth2.0` support, remove `redirect_uri`, change `Account ID` to `User ID` in spec #12937

bazarnov commented May 17, 2022 •

edited

Loading

bazarnov commented May 17, 2022 •

edited by github-actions bot

Loading

bazarnov commented May 18, 2022 •

edited by github-actions bot

Loading

codecov bot commented May 23, 2022 •

edited

Loading

midavadim commented May 23, 2022 •

edited by github-actions bot

Loading

midavadim commented May 23, 2022 •

edited by github-actions bot

Loading