-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
source Myhours: Udate API schema #12964
source Myhours: Udate API schema #12964
Conversation
@wissevrowl let us know when this is ready to review |
/test connector=connectors/source-my-hours
Build PassedTest summary info:
|
@wissevrowl I'm wondering if this should be converted as ready for review? |
Hi @alafanechere, I'm sorry for not continuing on this PR, work got in the way. This fix is in our Airbyte deployment and has fixed the issues. The only things remaining is updating the Changelog etc. |
/publish connector=connectors/source-my-hours
|
/publish connector=connectors/source-my-hours
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wissevrowl I made the additional required changes. Merging now.
What
The MyHours API Schema has changed, breaking the current version.
How
The schema has been updated.
Recommended reading order
x.java
y.python
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.