Jira Source: Added resolutiondate to fields on issues stream #13202

Mainara · 2022-05-25T20:34:04Z

What

This PR solves the problem of mapping the date and time when an issue was completed, which is extremely important for projects that use Airbyte to pull data from Jira and monitor the progress of activities.

How

I added the resolutiondate field in the fields object present in the stream issues,

User Impact

There is no breakchanges, just more information being returned in the stream issues.

Pre-merge Checklist

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

CLAassistant · 2022-05-25T20:34:12Z

All committers have signed the CLA.

marcosmarxm · 2022-05-25T23:48:57Z

@Mainara thanks, can you sign the CLA and bump the Dockerfile version?

marcosmarxm · 2022-05-25T23:49:57Z

/test connector=connectors/source-jira

🕑 connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/2387786563
❌ connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/2387786563
🐛 https://gradle.com/s/jgpwpzwkent6i

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs0]
FAILED test_core.py::TestBasicRead::test_read[inputs5] - Failed: Please check...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestFullRefresh.test_sequential_reads because not found in the config
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
============= 2 failed, 28 passed, 2 skipped in 157.57s (0:02:37) ==============

Mainara · 2022-05-26T12:43:39Z

@Mainara thanks, can you sign the CLA and bump the Dockerfile version?

@marcosmarxm I made the changes. 😃

marcosmarxm · 2022-05-30T19:44:33Z

/test connector=connectors/source-jira

🕑 connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/2411037853
✅ connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/2411037853
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestFullRefresh.test_sequential_reads because not found in the config
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 30 passed, 2 skipped in 165.62s (0:02:45) ===================

marcosmarxm · 2022-05-30T20:02:14Z

/publish connector=connectors/source-jira

🕑 connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/2411096020
🚀 Successfully published connectors/source-jira
❌ Couldn't auto-bump version for connectors/source-jira

marcosmarxm · 2022-05-30T20:22:42Z

/publish connector=connectors/source-jira auto-bump-version=false

🕑 connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/2411174279
❌ Failed to publish connectors/source-jira

marcosmarxm · 2022-05-30T20:31:42Z

/publish connector=connectors/source-jira auto-bump-version=false

🕑 connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/2411206311
🚀 Successfully published connectors/source-jira
✅ connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/2411206311

…hq#13202) * Added resolutiondate to fields on issues stream (jira source) * updated jira source changelog * updated dockerfile version * correct jira ci Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>

github-actions bot added the area/connectors Connector related issues label May 25, 2022

octavia-squidington-iii added the community label May 25, 2022

github-actions bot added the area/documentation Improvements or additions to documentation label May 25, 2022

marcosmarxm self-assigned this May 25, 2022

marcosmarxm approved these changes May 25, 2022

View reviewed changes

Mainara changed the title ~~Added resolutiondate to fields on issues stream (jira source)~~ Jira Source: Added resolutiondate to fields on issues stream May 26, 2022

vincentkoc approved these changes May 29, 2022

View reviewed changes

Mainara and others added 4 commits May 30, 2022 16:41

Added resolutiondate to fields on issues stream (jira source)

59f5a75

updated jira source changelog

e5f93ab

updated dockerfile version

91d8124

correct jira ci

6f08ddc

marcosmarxm merged commit 1d1476e into airbytehq:master May 30, 2022

octavia-squidington-iii mentioned this pull request May 31, 2022

Bump Airbyte version from 0.39.5-alpha to 0.39.6-alpha #13350

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Jira Source: Added resolutiondate to fields on issues stream #13202

Jira Source: Added resolutiondate to fields on issues stream #13202

Mainara commented May 25, 2022

CLAassistant commented May 25, 2022 •

edited

Loading

marcosmarxm commented May 25, 2022

marcosmarxm commented May 25, 2022 •

edited by github-actions bot

Loading

Mainara commented May 26, 2022

marcosmarxm commented May 30, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented May 30, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented May 30, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented May 30, 2022 •

edited by github-actions bot

Loading

Jira Source: Added resolutiondate to fields on issues stream #13202

Jira Source: Added resolutiondate to fields on issues stream #13202

Conversation

Mainara commented May 25, 2022

What

How

Recommended reading order

User Impact

Pre-merge Checklist

Community member or Airbyter

CLAassistant commented May 25, 2022 • edited Loading

marcosmarxm commented May 25, 2022

marcosmarxm commented May 25, 2022 • edited by github-actions bot Loading

Build Failed

Mainara commented May 26, 2022

marcosmarxm commented May 30, 2022 • edited by github-actions bot Loading

Build Passed

marcosmarxm commented May 30, 2022 • edited by github-actions bot Loading

marcosmarxm commented May 30, 2022 • edited by github-actions bot Loading

marcosmarxm commented May 30, 2022 • edited by github-actions bot Loading

CLAassistant commented May 25, 2022 •

edited

Loading

marcosmarxm commented May 25, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented May 30, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented May 30, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented May 30, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented May 30, 2022 •

edited by github-actions bot

Loading