Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source Mixpanel: Handle lowercase naming conflicts #13257

Closed
wants to merge 3 commits into from

Conversation

roman-romanov-o
Copy link
Contributor

What

Fix type of bug, that occured during normalization:
when custom Export schema contains fields like userName and username

How

Sort property names, and check for such cases, and transform userName -> _userName

If such collission occurs more than one time, then

userName
UserName
username

will be transformed to

userName
_UserName
__username

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Change schema for such conflicts, but for this cases it failed on normalization already

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the area/connectors Connector related issues label May 27, 2022
@roman-romanov-o roman-romanov-o requested a review from lazebnyi May 27, 2022 08:07
@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@981dc65). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #13257   +/-   ##
=========================================
  Coverage          ?   91.83%           
=========================================
  Files             ?        3           
  Lines             ?      355           
  Branches          ?        0           
=========================================
  Hits              ?      326           
  Misses            ?       29           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 981dc65...1e6ff76. Read the comment docs.

Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update change log in docs and bump version in the Docker file and seeds. Also run tests with /test command.

@roman-romanov-o
Copy link
Contributor Author

@lazebnyi I did not do it yet, cause there is another PR on verge of merge

#12286

As soon as it will merge, I will merge master and update version\changelog

@lazebnyi
Copy link
Collaborator

I think /test command can be run without looking back to other PRs.

Why you are waiting? You can bump your version before merge and in other PRs contributors will be fix conflicts.

@roman-romanov-o
Copy link
Contributor Author

roman-romanov-o commented May 30, 2022

/test connector=source-mixpanel

🕑 source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/2408741048
❌ source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/2408741048
🐛 https://gradle.com/s/wzlvuztbkixnm

Build Failed

Test summary info:

Could not find result summary

@roman-romanov-o
Copy link
Contributor Author

roman-romanov-o commented May 30, 2022

/test connector=source-mixpanel

🕑 source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/2409108217
❌ source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/2409108217
🐛 https://gradle.com/s/nxqzacijiqcq6

Build Failed

Test summary info:

Could not find result summary

@roman-romanov-o
Copy link
Contributor Author

roman-romanov-o commented May 31, 2022

/test connector=source-mixpanel

🕑 source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/2413431058

@roman-romanov-o
Copy link
Contributor Author

roman-romanov-o commented May 31, 2022

/test connector=source-mixpanel

🕑 source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/2414706605

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants