-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Source Mixpanel: Handle lowercase naming conflicts #13257
Conversation
|
Codecov Report
@@ Coverage Diff @@
## master #13257 +/- ##
=========================================
Coverage ? 91.83%
=========================================
Files ? 3
Lines ? 355
Branches ? 0
=========================================
Hits ? 326
Misses ? 29
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update change log in docs and bump version in the Docker file and seeds. Also run tests with /test
command.
I think Why you are waiting? You can bump your version before merge and in other PRs contributors will be fix conflicts. |
/test connector=source-mixpanel
Build FailedTest summary info:
|
/test connector=source-mixpanel
Build FailedTest summary info:
|
/test connector=source-mixpanel
|
/test connector=source-mixpanel
|
What
Fix type of bug, that occured during normalization:
when custom Export schema contains fields like
userName
andusername
How
Sort property names, and check for such cases, and transform
userName
->_userName
If such collission occurs more than one time, then
will be transformed to
Recommended reading order
x.java
y.python
🚨 User Impact 🚨
Change schema for such conflicts, but for this cases it failed on normalization already
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changesTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.