Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalization: rename *.sql -> *.sql.j2 #13474

Merged
merged 4 commits into from
Jun 6, 2022
Merged

Normalization: rename *.sql -> *.sql.j2 #13474

merged 4 commits into from
Jun 6, 2022

Conversation

grubberr
Copy link
Contributor

@grubberr grubberr commented Jun 4, 2022 •
edited
Loading

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

Rename test_pokemon_super.sql -> test_pokemon_super.sql.j2 to avoid be formatted by SQL formatter

@grubberr
test_pokemon_super.sql -> test_pokemon_super.sql.j2
64110ac 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr linked an issue Jun 4, 2022 that may be closed by this pull request
Normalization: rename *.sql -> *.sql.j2 to avoid be changed by SQL code formatter #12384
Closed
@grubberr grubberr self-assigned this Jun 4, 2022
grubberr added 2 commits June 6, 2022 09:05
@grubberr
Merge branch 'master' into grubberr/12384-base-normalization-redshift…
fbc79a4 
…-sql-j2
@grubberr
pytest.mark.skip
80e3637 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Copy link
Contributor Author

grubberr commented Jun 6, 2022 •
edited by github-actions bot
Loading

/test connector=bases/base-normalization

🕑 bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/2446001200
✅ bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/2446001200
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 13      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    13      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     155      8    95%
normalization/transform_config/transform.py                         159     31    81%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_catalog/utils.py                             38      9    76%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 543    352    35%
-------------------------------------------------------------------------------------
TOTAL                                                              1333    559    58%
Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 13      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    13      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     155      8    95%
normalization/transform_config/transform.py                         159     31    81%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_catalog/utils.py                             38      9    76%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 543    352    35%
-------------------------------------------------------------------------------------
TOTAL                                                              1333    559    58%
Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 13      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    13      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/utils.py                             38      3    92%
normalization/transform_catalog/dbt_macro.py                         22      3    86%
normalization/transform_catalog/catalog_processor.py                147     21    86%
normalization/transform_catalog/table_name_registry.py              174     51    71%
normalization/transform_catalog/transform.py                         61     22    64%
normalization/transform_catalog/stream_processor.py                 543    222    59%
normalization/transform_catalog/destination_name_transformer.py     155     75    52%
normalization/transform_config/transform.py                         159    100    37%
-------------------------------------------------------------------------------------
TOTAL                                                              1333    497    63%

Build Passed

Test summary info:

	 =========================== short test summary info ============================
	 SKIPPED [8] integration_tests/test_ephemeral.py:48: skip
	 SKIPPED [7] integration_tests/test_ephemeral.py:64: skip
	 SKIPPED [1] integration_tests/test_ephemeral.py:84: skip
	 SKIPPED [1] integration_tests/test_ephemeral.py:89: skip
	 SKIPPED [16] integration_tests/test_normalization.py:58: skip
	 �[32m================== �[32m�[1m1 passed�[0m, �[33m33 skipped�[0m�[32m in 195.15s (0:03:15)�[0m�[32m ===================�[0m
	 =========================== short test summary info ============================
	 SKIPPED [8] integration_tests/test_ephemeral.py:48: skip
	 SKIPPED [7] integration_tests/test_ephemeral.py:64: skip
	 SKIPPED [1] integration_tests/test_ephemeral.py:84: skip
	 SKIPPED [1] integration_tests/test_ephemeral.py:89: skip
	 SKIPPED [16] integration_tests/test_normalization.py:58: skip
	 �[32m================== �[32m�[1m1 passed�[0m, �[33m33 skipped�[0m�[32m in 131.42s (0:02:11)�[0m�[32m ===================�[0m

@grubberr
Revert "pytest.mark.skip"
6e9b712 
This reverts commit 80e3637.
@grubberr grubberr requested a review from edgao June 6, 2022 07:08
edgao
edgao approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@grubberr grubberr merged commit 0342699 into master Jun 6, 2022
@grubberr grubberr deleted the grubberr/12384-base-normalization-redshift-sql-j2 branch June 6, 2022 15:58
This was referenced Jun 6, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davydov-d davydov-d davydov-d approved these changes

@edgao edgao edgao approved these changes

Assignees

@grubberr grubberr

Labels
normalization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Normalization: rename *.sql -> *.sql.j2 to avoid be changed by SQL code formatter
3 participants
@grubberr @edgao @davydov-d