Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source LinkedIn Ads: fixed issue with normalization on redshift #13495

Merged

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented Jun 6, 2022

What

Resolving: #13018

How

  • renamed pivot key in Analytics streams, to be _pivot to avoid name conflicts on Redshift, since pivot is the reserved keyword.
  • re-factored the public documentation to reflect standard_template
  • increased unit_test coverage to 92%
  • labeled source-linkedin-ads as generally_available for UI

🚨 User Impact 🚨

Customers should Refresh source schema for all existing connections, after the update to 0.1.8 since the schema should also reflect the updated key name. Or do not update if your existing connection is working properly and your destination is different from Redshift.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

@airbytehq airbytehq deleted a comment from codecov bot Jun 7, 2022
@airbytehq airbytehq deleted a comment from codecov bot Jun 7, 2022
@bazarnov bazarnov temporarily deployed to more-secrets June 7, 2022 10:41 Inactive
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Jun 7, 2022
@bazarnov bazarnov temporarily deployed to more-secrets June 7, 2022 11:26 Inactive
@bazarnov
Copy link
Collaborator Author

bazarnov commented Jun 7, 2022

/test connector=connectors/source-linkedin-ads

🕑 connectors/source-linkedin-ads https://github.com/airbytehq/airbyte/actions/runs/2454297657
✅ connectors/source-linkedin-ads https://github.com/airbytehq/airbyte/actions/runs/2454297657
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                               Stmts   Miss  Cover
------------------------------------------------------
source_linkedin_ads/analytics.py      45      0   100%
source_linkedin_ads/__init__.py        2      0   100%
source_linkedin_ads/utils.py          90      5    94%
source_linkedin_ads/source.py        168     20    88%
------------------------------------------------------
TOTAL                                305     25    92%

Build Passed

Test summary info:

All Passed

@bazarnov bazarnov temporarily deployed to more-secrets June 7, 2022 11:50 Inactive
@airbytehq airbytehq deleted a comment from codecov bot Jun 7, 2022
@bazarnov bazarnov requested review from lazebnyi and midavadim June 7, 2022 12:11
@airbytehq airbytehq deleted a comment from codecov bot Jun 8, 2022
Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Few small comments.

@bazarnov
Copy link
Collaborator Author

bazarnov commented Jun 8, 2022

/publish connector=connectors/source-linkedin-ads

🕑 connectors/source-linkedin-ads https://github.com/airbytehq/airbyte/actions/runs/2462165676
🚀 Successfully published connectors/source-linkedin-ads
🚀 Auto-bumped version for connectors/source-linkedin-ads
✅ connectors/source-linkedin-ads https://github.com/airbytehq/airbyte/actions/runs/2462165676

@airbytehq airbytehq deleted a comment from codecov bot Jun 8, 2022
@airbytehq airbytehq deleted a comment from codecov bot Jun 8, 2022
@bazarnov bazarnov merged commit ec6a58c into master Jun 8, 2022
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets June 8, 2022 14:53 Inactive
@bazarnov bazarnov deleted the bazarnov/13018-linkedin-ads-pivot-causes-normalization-fail branch June 8, 2022 14:53
@airbytehq airbytehq deleted a comment from codecov bot Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/linkedin-ads
Projects
None yet
3 participants