-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source LinkedIn Ads: fixed issue with normalization on redshift #13495
🐛 Source LinkedIn Ads: fixed issue with normalization on redshift #13495
Conversation
…edin-ads-pivot-causes-normalization-fail
/test connector=connectors/source-linkedin-ads
Build PassedTest summary info:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Few small comments.
airbyte-integrations/connectors/source-linkedin-ads/source_linkedin_ads/utils.py
Show resolved
Hide resolved
airbyte-integrations/connectors/source-linkedin-ads/source_linkedin_ads/utils.py
Outdated
Show resolved
Hide resolved
/publish connector=connectors/source-linkedin-ads
|
What
Resolving: #13018
How
pivot
key in Analytics streams, to be_pivot
to avoid name conflicts on Redshift, sincepivot
is the reserved keyword.standard_template
unit_test
coverage to 92%source-linkedin-ads
asgenerally_available
for UI🚨 User Impact 🚨
Customers should
Refresh source schema
for all existing connections, after the update to0.1.8
since the schema should also reflect the updated key name. Or do not update if your existing connection is working properly and your destination is different from Redshift.Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described here