Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the acceptance tests. #13501

Merged
merged 10 commits into from
Jun 6, 2022
Merged

Fix the acceptance tests. #13501

merged 10 commits into from
Jun 6, 2022

Conversation

davinchia
Copy link
Contributor

@davinchia davinchia commented Jun 6, 2022 •
edited
Loading

What

Fix the Kube Acceptance Tests.

We've seen errors like:

  1. https://github.com/airbytehq/airbyte/runs/6758654948?check_suite_focus=true#step:11:52833 - from trying to list bootloader logs. This is no longer possible since we remove the bootloader pod.
  2. https://github.com/airbytehq/airbyte/runs/6746572522?check_suite_focus=true#step:11:52164 - errors while tearing down the test.

I will do a follow up PR to refactor tests to hopefully speed things up:

  1. split Kube from normal tests.
  2. explore not recreating the db on each time.

In the mean time, this should stabilise the tests and get us back to green build.

How

  • remove bootloader logging.
  • try to catch errors.

Recommended reading order

  • The two files.

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@davinchia davinchia temporarily deployed to more-secrets June 6, 2022 16:11 Inactive
@davinchia davinchia temporarily deployed to more-secrets June 6, 2022 16:47 Inactive
@davinchia davinchia temporarily deployed to more-secrets June 6, 2022 17:18 Inactive
@davinchia davinchia temporarily deployed to more-secrets June 6, 2022 17:24 Inactive
@davinchia davinchia temporarily deployed to more-secrets June 6, 2022 17:44 Inactive
davinchia
davinchia commented Jun 6, 2022
View reviewed changes
tools/bin/acceptance_test_kube.sh
@@ -36,7 +36,6 @@ kubectl describe pods | grep "Name\|Node"
sleep 120s

if [ -n "$CI" ]; then
bootloader_logs () { kubectl logs pod/airbyte-bootloader > /tmp/kubernetes_logs/bootloader.txt; }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can no longer retrieve the bootloader logs since the pod is removed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch!

@davinchia davinchia marked this pull request as ready for review June 6, 2022 18:12
jdpgrailsdev
jdpgrailsdev approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@jdpgrailsdev jdpgrailsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@davinchia davinchia temporarily deployed to more-secrets June 6, 2022 18:14 Inactive
lmossman
lmossman reviewed Jun 6, 2022
View reviewed changes
Copy link
Contributor

@lmossman lmossman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple comments. Main concern is around the @Disabled annotation

tools/bin/acceptance_test_kube.sh
@@ -36,7 +36,6 @@ kubectl describe pods | grep "Name\|Node"
sleep 120s

if [ -n "$CI" ]; then
bootloader_logs () { kubectl logs pod/airbyte-bootloader > /tmp/kubernetes_logs/bootloader.txt; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch!

airbyte-tests/src/acceptanceTests/java/io/airbyte/test/acceptance/AcceptanceTests.java Outdated Show resolved Hide resolved
airbyte-tests/src/acceptanceTests/java/io/airbyte/test/acceptance/AcceptanceTests.java Outdated Show resolved Hide resolved
@davinchia davinchia changed the title Try fixing the acceptance tests. Fix the acceptance tests. Jun 6, 2022
@davinchia davinchia temporarily deployed to more-secrets June 6, 2022 18:25 Inactive
lmossman
lmossman approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@lmossman lmossman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davinchia davinchia merged commit 40cb78e into master Jun 6, 2022
@davinchia davinchia deleted the davinchia/refactor-java-tests branch June 6, 2022 18:38
@davinchia davinchia temporarily deployed to more-secrets June 6, 2022 18:40 Inactive
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jun 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmossman lmossman lmossman approved these changes

@jdpgrailsdev jdpgrailsdev jdpgrailsdev approved these changes

@terencecho terencecho Awaiting requested review from terencecho

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davinchia @jdpgrailsdev @lmossman