Fix lost schedule when editing connection name and ensure connection name is not cleared in other connection updates #13510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update updateConnection calls in ConnectionName component to include all required fields
github-actions
bot
added
area/platform
edmundito
added
area/frontend
and removed
area/platform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes a few issues related to connection name:
Related to #12803
How
Currently, the api used to edit the connection (
/web_backend/connections/update) uses an all or nothing approach. We must dump the entire update state, otherwise, it will set those fields to null. The change ensures that all calls made to update the connection include all the fields.Additionally, keyboard events in the name editor were causing the connection to update twice. This also resolves that issue.