🎉 New Source: AppFollow Service #14418
Conversation
Ref https://appfollow.docs.apiary.io/ Does not currently include authentication
BASIC AUTH REALLY
90% pass
We have no incremental streams
|
|
marcosmarxm
changed the title
|
Thanks for the contributin @dtt101 ! Soon someone from the team will review it |
marcosmarxm
changed the title
|
Thanks @marcosmarxm - appreciated - the first one I have written so advice is definitely welcome! |
|
@dtt101 |
|
@igrankova - email sent with confirmation we are a customer |
|
@dtt101 Thank you very much! |
|
@harshithmullapudi you can review and publish without the sandbox account. |
github-actions
bot
added
the
area/documentation
|
/publish connector=connectors/source-appfollow
if you have connectors that successfully published but failed definition generation, follow step 4 here |
|
@harshithmullapudi - thanks for the commits! |
|
/publish connector=connectors/source-appfollow |
|
/publish connector=connectors/source-appfollow
if you have connectors that successfully published but failed definition generation, follow step 4 here |
|
@harshithmullapudi - thanks for running the publish - bumping the version has resolved the failing test. This looks like because the acceptance test config is missing - is this because you commented out, or is there some other config I need to add? |
|
/test connector=connectors/source-appfollow
Build FailedTest summary info: |
|
/publish connector=connectors/source-appfollow
if you have connectors that successfully published but failed definition generation, follow step 4 here |
|
/publish connector=connectors/source-appfollow run-tests=false
if you have connectors that successfully published but failed definition generation, follow step 4 here |
|
Ok - great it is building and publishing! I am not sure of the next step (apols if I am being dense). Would welcome any suggestions - thanks for the time so far cc @harshithmullapudi @marcosmarxm |
|
Hey @dtt101 you can go ahead and use the connector |
* Generated template Using https://docs.airbyte.com/connector-development/tutorials/cdk-speedrun * Added spec.yaml Ref https://appfollow.docs.apiary.io/ Does not currently include authentication * Schema and working discover for ratings API * Add catalog * Add cid as required parameter * Working ratings call BASIC AUTH REALLY * Use basic auth in check connection * Updated comment for request params * Update README for local run * Moved with common params to stream superclass * Add support for country parameter * WIP: acceptance 90% pass * Passing acceptance tests for ratings in docker * Remove incremental unit tests We have no incremental streams * Match number of streams to test * Passing streams unit tests * Connection check test * Update unit test type check * Remove TODO * fix: tests are failing * docs: added documentation for appfollow and logo * docs: added documentation for appfollow and logo * Bump io.airbyte.version * fix: tests are failing * auto-bump connector version [ci skip] Co-authored-by: Harshith Mullapudi <harshithmullapudi@gmail.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
|
@dtt101 first thanks for building this connector. Did you manage to get this working. All i get is json in the ratings column no matter what destination I try. |
|
@wallies - yes - rating is the only endpoint it supports (or do you mean you get an error in the expected response)? |
What
This introduces a new source connector for the Appfollow service.
It allows users to gather mobile application data from multiple app stores.
This initial version contains support for one API endpoint:
ratingsas documented hereHow
The connector exposes a number of config params, api secret, client ID, app store (i,e play / apple) ID and country and reads ratings data from the source API
🚨 User Impact 🚨
There are no breaking changes - the PR should provide a new connector option for airbyte users
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampledocs/integrations/README.mdairbyte-integrations/builds.mdAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing/publishcommand described hereAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing/publishcommand described hereTests
Unit
Integration
Acceptance