Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Freshsales: tune get_view_id function #14705

Merged

Conversation

davydov-d
Copy link
Collaborator

What

Tune the function's docstring and make it fail fast in case of missing filter_name

@davydov-d davydov-d self-assigned this Jul 14, 2022
@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jul 14, 2022
@davydov-d davydov-d linked an issue Jul 14, 2022 that may be closed by this pull request
@davydov-d
Copy link
Collaborator Author

davydov-d commented Jul 14, 2022

/test connector=connectors/source-freshsales

🕑 connectors/source-freshsales https://github.com/airbytehq/airbyte/actions/runs/2669004224
✅ connectors/source-freshsales https://github.com/airbytehq/airbyte/actions/runs/2669004224
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                            Stmts   Miss  Cover
---------------------------------------------------
source_freshsales/__init__.py       2      0   100%
source_freshsales/source.py       116     51    56%
---------------------------------------------------
TOTAL                             118     51    57%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
======================== 21 passed, 1 skipped in 27.77s ========================

@davydov-d
Copy link
Collaborator Author

davydov-d commented Jul 14, 2022

/publish connector=connectors/source-freshsales

🕑 Publishing the following connectors:
connectors/source-freshsales
https://github.com/airbytehq/airbyte/actions/runs/2670294883


Connector Did it publish? Were definitions generated?
connectors/source-freshsales

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@davydov-d davydov-d merged commit c7dc5e1 into master Jul 14, 2022
@davydov-d davydov-d deleted the ddavydov/#12111-source-freshsales-validate-get_view_id branch July 14, 2022 12:42
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets July 14, 2022 12:43 Inactive
@lazebnyi lazebnyi removed their request for review July 18, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/freshsales
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Freshsales: get_view_id only returns a single view ID
3 participants