Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix file descriptor leak when retrieving configs #1471

Merged
merged 1 commit into from
Dec 29, 2020
Merged

fix file descriptor leak when retrieving configs #1471

merged 1 commit into from
Dec 29, 2020

Conversation

jrhizor
Copy link
Contributor

@jrhizor jrhizor commented Dec 29, 2020 •
edited
Loading

Fixes #1470

The stream from Files.list was not being closed.

@jrhizor
Copy link
Contributor Author

jrhizor commented Dec 29, 2020

Going to just check that this was the only source of the leak before merging.

@jrhizor
Copy link
Contributor Author

jrhizor commented Dec 29, 2020

It looks steady now. No descriptors on /data are remaining. For /workspace we only have logging descriptors which docs say after "30 minutes will be automatically closed and discarded."

@jrhizor jrhizor merged commit 6a99634 into master Dec 29, 2020
@jrhizor jrhizor deleted the jrhizor/fix-leak branch December 29, 2020 19:11
@jrhizor jrhizor mentioned this pull request Dec 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michel-tricot michel-tricot michel-tricot approved these changes

@cgardens cgardens Awaiting requested review from cgardens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

file descriptor limit reached
2 participants
@jrhizor @michel-tricot