🎉 New source: Freshcaller [Reopened] #14759

jsrcodes · 2022-07-15T18:47:12Z

What

Creating a new python HTTP source for Freshcaller based on this API spec

How

Using the python CDK to implement full refresh and incremental streams for some important endpoints listed in the API docs.

🚨 User Impact 🚨

None

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Integration

Acceptance

harshithmullapudi · 2022-07-20T04:33:54Z

Hey thanks for the contribution

harshithmullapudi · 2022-07-20T04:35:38Z

Hey @jsrcodes we tried getting sandbox previously for this connector and failed. Could you help us understand this?

harshithmullapudi · 2022-07-20T04:35:54Z

#12123

jsrcodes · 2022-07-20T04:43:54Z

Hey @jsrcodes we tried getting sandbox previously for this connector and failed. Could you help us understand this?

Hi Harshit, we managed to secure a trial account that's valid up to an year. And the Freshcaller team told us that they will extend it when it nears expiry. I can share the credentials for test suite to work. Please let me know if that's what you need.

jsrcodes · 2022-07-26T17:52:19Z

@harshithmullapudi - A bump here on this. Please let me know if I can help provide the test account credentials.

marcosmarxm · 2022-08-11T19:55:23Z

/test connector=connectors/source-freshcaller

marcosmarxm · 2022-08-11T20:47:57Z

/test connector=connectors/source-freshcaller

🕑 connectors/source-freshcaller https://github.com/airbytehq/airbyte/actions/runs/2842723257
❌ connectors/source-freshcaller https://github.com/airbytehq/airbyte/actions/runs/2842723257
🐛 https://gradle.com/s/5cgpkxntdxthi

Build Failed

Test summary info:

Could not find result summary

marcosmarxm · 2022-08-11T21:40:57Z

/test connector=connectors/source-freshcaller

🕑 connectors/source-freshcaller https://github.com/airbytehq/airbyte/actions/runs/2842994613
✅ connectors/source-freshcaller https://github.com/airbytehq/airbyte/actions/runs/2842994613
Python tests coverage:

Name                             Stmts   Miss  Cover
----------------------------------------------------
source_freshcaller/__init__.py       2      0   100%
source_freshcaller/streams.py      100      4    96%
source_freshcaller/source.py        29     15    48%
----------------------------------------------------
TOTAL                              131     19    85%
Name                             Stmts   Miss  Cover
----------------------------------------------------
source_freshcaller/__init__.py       2      0   100%
source_freshcaller/source.py        29     11    62%
source_freshcaller/streams.py      100     47    53%
----------------------------------------------------
TOTAL                              131     58    56%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       121     25    79%   21-23, 29-31, 36-43, 48-61, 208-214
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       110     48    56%   23-26, 32, 36, 39-64, 67-69, 72-74, 77-79, 82-84, 87-89, 92-110, 144-146
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1321    463    65%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:51: The previous connector image could not be retrieved.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:229: The previous connector image could not be retrieved.
=================== 27 passed, 2 skipped in 75.82s (0:01:15) ===================

marcosmarxm · 2022-08-11T21:58:46Z

/publish connector=connectors/source-freshcaller

🕑 Publishing the following connectors:
connectors/source-freshcaller
https://github.com/airbytehq/airbyte/actions/runs/2843078087

Connector	Did it publish?	Were definitions generated?
connectors/source-freshcaller	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

marcosmarxm · 2022-08-11T22:24:19Z

Thanks @jsrcodes for the new connector!

github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jul 15, 2022

octavia-squidington-iii added bounty community connectors/source/freshcaller labels Jul 15, 2022

jsrcodes changed the title ~~🎉 Add source: Freshcaller~~ 🎉 Add source: Freshcaller [Reopened] Jul 15, 2022

jsrcodes changed the title ~~🎉 Add source: Freshcaller [Reopened]~~ 🎉 New source: Freshcaller [Reopened] Jul 16, 2022

harshithmullapudi self-requested a review July 25, 2022 14:01

harshithmullapudi self-assigned this Jul 25, 2022

airbytehq deleted a comment from harshithmullapudi Aug 11, 2022

jsrcodes and others added 4 commits August 11, 2022 18:07

Add source: Freshcaller

3490774

Formatted

68d0fe1

fix connector backward compatibility

830b931

fix unused files

6e03667

marcosmarxm force-pushed the new-source-freshcaller branch from cb9b50a to 6e03667 Compare August 11, 2022 21:40

marcosmarxm added 2 commits August 11, 2022 18:56

add seed file

1d16231

add changelog

6e201b6

auto-bump connector version [ci skip]

1180740

marcosmarxm approved these changes Aug 11, 2022

View reviewed changes

marcosmarxm merged commit 611ef03 into airbytehq:master Aug 11, 2022

octavia-squidington-iii mentioned this pull request Aug 19, 2022

Bump Airbyte version from 0.40.0-alpha to 0.40.1-alpha #15775

Closed

evantahler mentioned this pull request Aug 22, 2022

Bump Airbyte version from 0.40.0-alpha to 0.40.1 #15857

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 New source: Freshcaller [Reopened] #14759

🎉 New source: Freshcaller [Reopened] #14759

jsrcodes commented Jul 15, 2022

harshithmullapudi commented Jul 20, 2022

harshithmullapudi commented Jul 20, 2022

harshithmullapudi commented Jul 20, 2022

jsrcodes commented Jul 20, 2022

jsrcodes commented Jul 26, 2022

marcosmarxm commented Aug 11, 2022

marcosmarxm commented Aug 11, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Aug 11, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Aug 11, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Aug 11, 2022

🎉 New source: Freshcaller [Reopened] #14759

🎉 New source: Freshcaller [Reopened] #14759

Conversation

jsrcodes commented Jul 15, 2022

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

harshithmullapudi commented Jul 20, 2022

harshithmullapudi commented Jul 20, 2022

harshithmullapudi commented Jul 20, 2022

jsrcodes commented Jul 20, 2022

jsrcodes commented Jul 26, 2022

marcosmarxm commented Aug 11, 2022

marcosmarxm commented Aug 11, 2022 • edited by github-actions bot Loading

Build Failed

marcosmarxm commented Aug 11, 2022 • edited by github-actions bot Loading

Build Passed

marcosmarxm commented Aug 11, 2022 • edited by github-actions bot Loading

marcosmarxm commented Aug 11, 2022

marcosmarxm commented Aug 11, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Aug 11, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Aug 11, 2022 •

edited by github-actions bot

Loading