Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix airbyte-worker #14977

Merged
merged 3 commits into from
Jul 25, 2022
Merged

fix: fix airbyte-worker #14977

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f280b8e
fix: fix airbyte-worker
xpuska513 Jul 23, 2022
fc8bc79
bump temporalio version to 1.13.0
xpuska513 Jul 25, 2022
83e8c87
fix: revert removal of deploymentMode variable
xpuska513 Jul 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions charts/airbyte-worker/Chart.lock
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions charts/airbyte-worker/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,8 +298,6 @@ spec:
configMapKeyRef:
name: {{ .Release.Name }}-airbyte-env
key: USE_STREAM_CAPABLE_STATE
{{- if .Values.worker.extraEnv }}
{{ .Values.worker.extraEnv | toYaml | nindent 8 }}
{{- end }}
{{- if .Values.extraEnv }}
{{ .Values.extraEnv | toYaml | nindent 8 }}
Expand Down
30 changes: 0 additions & 30 deletions charts/airbyte/Chart.lock
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion charts/airbyte/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,7 +721,7 @@ temporal:
image:
repository: temporalio/auto-setup
pullPolicy: IfNotPresent
tag: "1.7.0"
tag: "latest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not sure we can do this. i remember us running into issues here. See this for more info.

This is also making me realise this isn't correct. Our docker files use a wrapped Temporal image and we should probably use that in Helm too, and hopefully upgrade it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumped version the same as specified in our dockerfiles


## @param temporal.service.type The Kubernetes Service Type
## @param temporal.service.port The temporal port and exposed kubernetes port
Expand Down