[low-code connectors] Handle 200 responses with error

airbyte-cdk/python/airbyte_cdk/sources/declarative/read_exception.py

@@ -0,0 +1,7 @@
+#
+# Copyright (c) 2022 Airbyte, Inc., all rights reserved.
+#
+class ReadException(Exception):
+    """
+    Raise when there is an error reading data from an API Source
+    """

airbyte-cdk/python/airbyte_cdk/sources/declarative/requesters/error_handlers/default_error_handler.py

@@ -112,20 +112,20 @@ def max_retries(self) -> Union[int, None]:
 
     def should_retry(self, response: requests.Response) -> ResponseStatus:
         request = response.request
-        if response.ok:
-            return response_status.SUCCESS
+
         if request not in self._last_request_to_attempt_count:
             self._last_request_to_attempt_count = {request: 1}
         else:
             self._last_request_to_attempt_count[request] += 1
-
         for response_filter in self._response_filters:
             filter_action = response_filter.matches(response)
             if filter_action is not None:
                 if filter_action == ResponseAction.RETRY:
                     return ResponseStatus(ResponseAction.RETRY, self._backoff_time(response, self._last_request_to_attempt_count[request]))
                 else:
                     return ResponseStatus(filter_action)
+        if response.ok:
+            return response_status.SUCCESS
         # Fail if the response matches no filters
         return response_status.FAIL
 

airbyte-cdk/python/airbyte_cdk/sources/declarative/requesters/error_handlers/http_response_filter.py

@@ -61,4 +61,5 @@ def _response_contains_error_message(self, response: requests.Response) -> bool:
         if not self._error_message_contains:
             return False
         else:
-            return self._error_message_contains in HttpStream.parse_response_error_message(response)
+            error_message = HttpStream.parse_response_error_message(response)
+            return error_message and self._error_message_contains in error_message

airbyte-cdk/python/airbyte_cdk/sources/declarative/retrievers/simple_retriever.py

@@ -7,6 +7,7 @@
 import requests
 from airbyte_cdk.models import SyncMode
 from airbyte_cdk.sources.declarative.extractors.http_selector import HttpSelector
+from airbyte_cdk.sources.declarative.read_exception import ReadException
 from airbyte_cdk.sources.declarative.requesters.error_handlers.response_action import ResponseAction
 from airbyte_cdk.sources.declarative.requesters.paginators.no_pagination import NoPagination
 from airbyte_cdk.sources.declarative.requesters.paginators.paginator import Paginator
@@ -263,7 +264,7 @@ def parse_response(
         # else -> delegate to record selector
         response_status = self._requester.should_retry(response)
         if response_status.action == ResponseAction.FAIL:
-            response.raise_for_status()
+            raise ReadException(f"Request {response.request} failed with response {response}")
         elif response_status.action == ResponseAction.IGNORE:
             self.logger.info(f"Ignoring response for failed request with error message {HttpStream.parse_response_error_message(response)}")
             return []

airbyte-cdk/python/unit_tests/sources/declarative/requesters/error_handlers/test_default_error_handler.py

@@ -101,6 +101,15 @@
             response_status.FAIL,
             None,
         ),
+        (
+            "test_200_fail_with_predicate",
+            HTTPStatus.OK,
+            HttpResponseFilter(action=ResponseAction.FAIL, error_message_contain="found"),
+            None,
+            {},
+            response_status.FAIL,
+            None,
+        ),
         (
             "test_retry_403",
             HTTPStatus.FORBIDDEN,