Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

14895 Destination MongoDB Strict Encrypt Fixed Failing Integration Test #15191

Closed
wants to merge 5 commits into from
Closed

14895 Destination MongoDB Strict Encrypt Fixed Failing Integration Test #15191

wants to merge 5 commits into from

Conversation

suhomud
Copy link
Contributor

@suhomud suhomud commented Aug 2, 2022

What

Destination MongoDB Strict Encrypt integration tests were failing because of server availability.

How

Integration tests were adapted to use mongo with test container

@github-actions github-actions bot added the area/connectors Connector related issues label Aug 2, 2022
@suhomud
Copy link
Contributor Author

suhomud commented Aug 2, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/destination-mongodb-strict-encrypt

🕑 connectors/destination-mongodb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2780439101
❌ connectors/destination-mongodb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2780439101
🐛

@suhomud
Copy link
Contributor Author

suhomud commented Aug 2, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/destination-mongodb

🕑 connectors/destination-mongodb https://github.com/airbytehq/airbyte/actions/runs/2780441152
❌ connectors/destination-mongodb https://github.com/airbytehq/airbyte/actions/runs/2780441152
🐛

@suhomud
Copy link
Contributor Author

suhomud commented Aug 2, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/destination-mongodb-strict-encrypt

🕑 connectors/destination-mongodb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2780527705
✅ connectors/destination-mongodb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2780527705
No Python unittests run

Build Passed

Test summary info:

All Passed

@suhomud
Copy link
Contributor Author

suhomud commented Aug 2, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/destination-mongodb

🕑 connectors/destination-mongodb https://github.com/airbytehq/airbyte/actions/runs/2780528840
❌ connectors/destination-mongodb https://github.com/airbytehq/airbyte/actions/runs/2780528840
🐛 https://gradle.com/s/4daljr54ijy24

Build Failed

Test summary info:

Could not find result summary

@suhomud suhomud requested a review from andriikorotkov August 2, 2022 08:07
@suhomud
Copy link
Contributor Author

suhomud commented Aug 2, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/destination-mongodb

🕑 connectors/destination-mongodb https://github.com/airbytehq/airbyte/actions/runs/2780618029
❌ connectors/destination-mongodb https://github.com/airbytehq/airbyte/actions/runs/2780618029
🐛 https://gradle.com/s/zanuvfj3yke6k

Build Failed

Test summary info:

Could not find result summary

@suhomud
Copy link
Contributor Author

suhomud commented Aug 2, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/destination-mongodb

🕑 connectors/destination-mongodb https://github.com/airbytehq/airbyte/actions/runs/2780951616
✅ connectors/destination-mongodb https://github.com/airbytehq/airbyte/actions/runs/2780951616
No Python unittests run

Build Passed

Test summary info:

All Passed

@suhomud suhomud marked this pull request as ready for review August 2, 2022 13:53
@suhomud suhomud linked an issue Aug 2, 2022 that may be closed by this pull request
Destination MongoDB Strict Encrypt Failing Integration Test #14895
Closed
alexandr-shegeda
alexandr-shegeda reviewed Aug 2, 2022
View reviewed changes
.../airbyte/integrations/destination/mongodb/MongodbDestinationStrictEncryptAcceptanceTest.java Outdated
}

private MongoDatabase getMongoDatabase() {
final String connectionString = String.format("mongodb://%s:%s@%s:%s/%s?authSource=admin&tcl=true",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please replace tcl with tls

andriikorotkov
andriikorotkov approved these changes Aug 2, 2022
View reviewed changes
...onnectors/destination-mongodb-strict-encrypt/src/test-integration/resources/mongodb-cert.crt
7He0Jqfg53+yLZv33w6NA4X8QIWdoBuK02ZP7ZhEBcMJOByetsuaHXjadsOpP4LM
7KaP6zUq9kteKD6TgiCTmV6U/tpDvhS3YdVBEdd0aPlBeWGJ+GzubbOUUJOYSkt0
jQ/Z56qy7eSveCa5ZQ==
-----END CERTIFICATE-----
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the expiration date of these keys? We need them to be valid for a very long time.

@natikgadzhi natikgadzhi closed this Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandr-shegeda alexandr-shegeda alexandr-shegeda left review comments

@andriikorotkov andriikorotkov andriikorotkov approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues connectors/destination/mongodb connectors/destination/mongodb-strict-encrypt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Destination MongoDB Strict Encrypt Failing Integration Test
5 participants
@suhomud @alexandr-shegeda @andriikorotkov @natikgadzhi @octavia-squidington-iii