Query and monitor if we have skipped any scheduled jobs #15256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
github-actions
bot
removed
area/platform
xiaohansong
requested review from
a team and
git-phu
and removed request for
a team
xiaohansong
changed the title
git-phu
approved these changes
Aug 6, 2022
| @@ -148,4 +148,44 @@ public static List<Pair<JobStatus, Double>> overallJobRuntimeForTerminalJobsInLa | |||
| return pairedRes; | |||
| } | |||
|
|
|||
| public static Long numOfJobsNotRunningOnSchedule(final DSLContext ctx) { | |||
There was a problem hiding this comment.
do we have any kind of testing for these queries?
There was a problem hiding this comment.
not in unit test I'm afraid... but I ran these manually on dbeaver.
There was a problem hiding this comment.
ok, should we add a comment about what our logic is for determining if a job run was missed?
There was a problem hiding this comment.
make sense. I have a runbook coming in https://github.com/airbytehq/airbyte-cloud/pull/2272; I'll add a short summary here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
https://github.com/airbytehq/airbyte-cloud/issues/2225
Monitor if we have skipped any scheduled jobs