15302: Destination Azure Blob Storage: Handle per-stream state #15318

kimerinn · 2022-08-04T16:35:25Z

What

Per-stream state fixed for Azure Blob destination

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

…302_Destination_Azure_Blob_Storage_Handle_per-stream_state

alexandr-shegeda · 2022-08-06T07:02:38Z

/test connector=connectors/destination-azure-blob-storage

🕑 connectors/destination-azure-blob-storage https://github.com/airbytehq/airbyte/actions/runs/2808039373
❌ connectors/destination-azure-blob-storage https://github.com/airbytehq/airbyte/actions/runs/2808039373
🐛 https://gradle.com/s/x5seilw7p4z5u

Build Failed

Test summary info:

Could not find result summary

...java/io/airbyte/integrations/destination/azure_blob_storage/AzureBlobRecordConsumerTest.java

…302_Destination_Azure_Blob_Storage_Handle_per-stream_state

…e_per-stream_state

alexandr-shegeda · 2022-08-08T10:54:06Z

please make sure that tests passed

alexandr-shegeda

code looks good so far, but I also expect that tests should pass

kimerinn · 2022-08-08T10:58:08Z

/test connector=connectors/destination-azure-blob-storage

🕑 connectors/destination-azure-blob-storage https://github.com/airbytehq/airbyte/actions/runs/2817366545
❌ connectors/destination-azure-blob-storage https://github.com/airbytehq/airbyte/actions/runs/2817366545
🐛 https://gradle.com/s/oiabqvdb2o3cy

Build Failed

Test summary info:

Could not find result summary

kimerinn · 2022-08-08T11:11:31Z

/test connector=connectors/destination-azure-blob-storage

🕑 connectors/destination-azure-blob-storage https://github.com/airbytehq/airbyte/actions/runs/2817446140
❌ connectors/destination-azure-blob-storage https://github.com/airbytehq/airbyte/actions/runs/2817446140
🐛 https://gradle.com/s/3hi2aecpk3j2a

Build Failed

Test summary info:

Could not find result summary

…e_per-stream_state

kimerinn · 2022-08-08T11:26:16Z

/test connector=connectors/destination-azure-blob-storage

🕑 connectors/destination-azure-blob-storage https://github.com/airbytehq/airbyte/actions/runs/2817531282
❌ connectors/destination-azure-blob-storage https://github.com/airbytehq/airbyte/actions/runs/2817531282
🐛 https://gradle.com/s/obpgl7ns3izfe

Build Failed

Test summary info:

Could not find result summary

kimerinn · 2022-08-08T12:02:00Z

/test connector=connectors/destination-azure-blob-storage

…e_per-stream_state

kimerinn · 2022-08-08T14:38:43Z

/test connector=connectors/destination-azure-blob-storage

🕑 connectors/destination-azure-blob-storage https://github.com/airbytehq/airbyte/actions/runs/2818731581
✅ connectors/destination-azure-blob-storage https://github.com/airbytehq/airbyte/actions/runs/2818731581
No Python unittests run

Build Passed

Test summary info:

All Passed

…e_per-stream_state

edgao · 2022-08-08T16:57:38Z

@kimerinn did you mean to publish this connector before merging?

tuliren · 2022-08-08T17:37:51Z

Looks like the changes are not published. I will publish it in this PR: #15412

Update: done.

alexandr-shegeda · 2022-08-08T18:51:10Z

@tuliren thanks a lot

15302: Azure blob destination consumer fixed

5a76bce

github-actions bot added the area/connectors Connector related issues label Aug 4, 2022

kimerinn linked an issue Aug 4, 2022 that may be closed by this pull request

Destination Azure Blob Storage: Handle per-stream state #15302

Closed

octavia-squidington-iii added the connectors/destination/azure-blob-storage label Aug 4, 2022

kimerinn added 2 commits August 5, 2022 13:55

Merge branch 'master' of https://github.com/airbytehq/airbyte into 15…

9cb10b8

…302_Destination_Azure_Blob_Storage_Handle_per-stream_state

15302: Unit test added

fbfe138

alexandr-shegeda reviewed Aug 6, 2022

View reviewed changes

...java/io/airbyte/integrations/destination/azure_blob_storage/AzureBlobRecordConsumerTest.java Show resolved Hide resolved

kimerinn added 2 commits August 8, 2022 03:13

Merge branch 'master' of https://github.com/airbytehq/airbyte into 15…

e1b320b

…302_Destination_Azure_Blob_Storage_Handle_per-stream_state

15302: Unit test added

38f8b3d

kimerinn marked this pull request as ready for review August 8, 2022 09:38

kimerinn requested a review from a team as a code owner August 8, 2022 09:38

Merge branch 'master' into 15302_Destination_Azure_Blob_Storage_Handl…

c00d914

…e_per-stream_state

alexandr-shegeda approved these changes Aug 8, 2022

View reviewed changes

Merge branch 'master' into 15302_Destination_Azure_Blob_Storage_Handl…

0d52e24

…e_per-stream_state

15318: test fix

97c7a3e

Merge branch 'master' into 15302_Destination_Azure_Blob_Storage_Handl…

9b448a7

…e_per-stream_state

Merge branch 'master' into 15302_Destination_Azure_Blob_Storage_Handl…

faeb321

…e_per-stream_state

kimerinn merged commit 211d331 into master Aug 8, 2022

kimerinn deleted the 15302_Destination_Azure_Blob_Storage_Handle_per-stream_state branch August 8, 2022 15:49

tuliren mentioned this pull request Aug 8, 2022

Destination azure: bump version #15412

Merged

octavia-squidington-iii mentioned this pull request Aug 10, 2022

Bump Airbyte version from 0.39.42-alpha to 0.40.0-alpha #15493

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

15302: Destination Azure Blob Storage: Handle per-stream state #15318

15302: Destination Azure Blob Storage: Handle per-stream state #15318

kimerinn commented Aug 4, 2022

alexandr-shegeda commented Aug 6, 2022 •

edited by github-actions bot

Loading

alexandr-shegeda commented Aug 8, 2022

alexandr-shegeda left a comment

kimerinn commented Aug 8, 2022 •

edited by github-actions bot

Loading

kimerinn commented Aug 8, 2022 •

edited by github-actions bot

Loading

kimerinn commented Aug 8, 2022 •

edited by github-actions bot

Loading

kimerinn commented Aug 8, 2022

kimerinn commented Aug 8, 2022 •

edited by github-actions bot

Loading

edgao commented Aug 8, 2022

tuliren commented Aug 8, 2022 •

edited

Loading

alexandr-shegeda commented Aug 8, 2022

15302: Destination Azure Blob Storage: Handle per-stream state #15318

15302: Destination Azure Blob Storage: Handle per-stream state #15318

Conversation

kimerinn commented Aug 4, 2022

What

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

alexandr-shegeda commented Aug 6, 2022 • edited by github-actions bot Loading

Build Failed

alexandr-shegeda commented Aug 8, 2022

alexandr-shegeda left a comment

Choose a reason for hiding this comment

kimerinn commented Aug 8, 2022 • edited by github-actions bot Loading

Build Failed

kimerinn commented Aug 8, 2022 • edited by github-actions bot Loading

Build Failed

kimerinn commented Aug 8, 2022 • edited by github-actions bot Loading

Build Failed

kimerinn commented Aug 8, 2022

kimerinn commented Aug 8, 2022 • edited by github-actions bot Loading

Build Passed

edgao commented Aug 8, 2022

tuliren commented Aug 8, 2022 • edited Loading

alexandr-shegeda commented Aug 8, 2022

alexandr-shegeda commented Aug 6, 2022 •

edited by github-actions bot

Loading

kimerinn commented Aug 8, 2022 •

edited by github-actions bot

Loading

kimerinn commented Aug 8, 2022 •

edited by github-actions bot

Loading

kimerinn commented Aug 8, 2022 •

edited by github-actions bot

Loading

kimerinn commented Aug 8, 2022 •

edited by github-actions bot

Loading

tuliren commented Aug 8, 2022 •

edited

Loading