low-code connectors: convert request headers to string before submitting them #15336

girarda · 2022-08-04T23:21:57Z

What

requests raises an exception if the request headers are not strings

raise InvalidHeader(\nrequests.exceptions.InvalidHeader: Header part (1.0) from {'api-version': 1.0} must be of type str or bytes, not <class 'float'>\n", "failure_type": "system_error"}}}

How

cast request headers to strings before sending them to HttpStream

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

girarda · 2022-08-05T02:21:05Z

...cdk/python/airbyte_cdk/sources/declarative/stream_slicers/cartesian_product_stream_slicer.py

+        return dict(
+            ChainMap(
+                *[
+                    s.request_params(stream_state=stream_state, stream_slice=stream_slice, next_page_token=next_page_token)


pass keyworded arguments

girarda · 2022-08-05T02:21:09Z

...cdk/python/airbyte_cdk/sources/declarative/stream_slicers/cartesian_product_stream_slicer.py

+        return dict(
+            ChainMap(
+                *[
+                    s.request_headers(stream_state=stream_state, stream_slice=stream_slice, next_page_token=next_page_token)


pass keyworded arguments

girarda · 2022-08-05T02:21:12Z

...cdk/python/airbyte_cdk/sources/declarative/stream_slicers/cartesian_product_stream_slicer.py

+        return dict(
+            ChainMap(
+                *[
+                    s.request_body_json(stream_state=stream_state, stream_slice=stream_slice, next_page_token=next_page_token)


pass keyworded arguments

girarda · 2022-08-05T02:21:15Z

...cdk/python/airbyte_cdk/sources/declarative/stream_slicers/cartesian_product_stream_slicer.py

+        return dict(
+            ChainMap(
+                *[
+                    s.request_body_data(stream_state=stream_state, stream_slice=stream_slice, next_page_token=next_page_token)


pass keyworded arguments

girarda · 2022-08-05T02:21:29Z

airbyte-cdk/python/airbyte_cdk/sources/declarative/retrievers/simple_retriever.py

@@ -127,11 +127,11 @@ def _get_request_options(
        :param paginator_method:
        :return:
        """
-        requester_mapping = requester_method(self.state, stream_slice, next_page_token)
+        requester_mapping = requester_method(stream_state=self.state, stream_slice=stream_slice, next_page_token=next_page_token)


pass keyworded arguments

girarda · 2022-08-05T02:21:32Z

airbyte-cdk/python/airbyte_cdk/sources/declarative/retrievers/simple_retriever.py

        requester_mapping_keys = set(requester_mapping.keys())
-        paginator_mapping = paginator_method(self.state, stream_slice, next_page_token)
+        paginator_mapping = paginator_method(stream_state=self.state, stream_slice=stream_slice, next_page_token=next_page_token)


pass keyworded arguments

girarda · 2022-08-05T02:21:35Z

airbyte-cdk/python/airbyte_cdk/sources/declarative/retrievers/simple_retriever.py

        paginator_mapping_keys = set(paginator_mapping.keys())
-        stream_slicer_mapping = stream_slicer_method(stream_slice)
+        stream_slicer_mapping = stream_slicer_method(stream_slice=stream_slice)


pass keyworded arguments

airbyte-cdk/python/airbyte_cdk/sources/declarative/retrievers/simple_retriever.py

girarda · 2022-08-06T16:55:06Z

/publish-cdk dry-run=false

🕑 https://github.com/airbytehq/airbyte/actions/runs/2809620032
✅ https://github.com/airbytehq/airbyte/actions/runs/2809620032

girarda added 2 commits August 4, 2022 16:19

convert values to strings

b0a2e1e

introduce variable

726f61d

github-actions bot added the CDK Connector Development Kit label Aug 4, 2022

merge

151a1d8

girarda changed the title ~~Alex/requestheaders string~~ low-code connectors: convert request headers to string before submitting them Aug 5, 2022

girarda requested a review from brianjlai August 5, 2022 01:10

girarda marked this pull request as ready for review August 5, 2022 01:10

girarda requested a review from a team as a code owner August 5, 2022 01:10

kwargs

5c1e7a7

girarda commented Aug 5, 2022

View reviewed changes

sherifnada approved these changes Aug 5, 2022

View reviewed changes

airbyte-cdk/python/airbyte_cdk/sources/declarative/retrievers/simple_retriever.py Outdated Show resolved Hide resolved

merge

0b783f4

girarda force-pushed the alex/requestheadersString branch from fe753f1 to 0b783f4 Compare August 6, 2022 16:20

bump version

f21d16e

girarda merged commit 6f1715e into master Aug 6, 2022

girarda deleted the alex/requestheadersString branch August 6, 2022 17:10

octavia-squidington-iii mentioned this pull request Aug 10, 2022

Bump Airbyte version from 0.39.42-alpha to 0.40.0-alpha #15493

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

low-code connectors: convert request headers to string before submitting them #15336

low-code connectors: convert request headers to string before submitting them #15336

girarda commented Aug 4, 2022 •

edited

Loading

girarda Aug 5, 2022

girarda Aug 5, 2022

girarda Aug 5, 2022

girarda Aug 5, 2022

girarda Aug 5, 2022

girarda Aug 5, 2022

girarda Aug 5, 2022

girarda commented Aug 6, 2022 •

edited by github-actions bot

Loading

low-code connectors: convert request headers to string before submitting them #15336

low-code connectors: convert request headers to string before submitting them #15336

Conversation

girarda commented Aug 4, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

girarda Aug 5, 2022

Choose a reason for hiding this comment

girarda Aug 5, 2022

Choose a reason for hiding this comment

girarda Aug 5, 2022

Choose a reason for hiding this comment

girarda Aug 5, 2022

Choose a reason for hiding this comment

girarda Aug 5, 2022

Choose a reason for hiding this comment

girarda Aug 5, 2022

Choose a reason for hiding this comment

girarda Aug 5, 2022

Choose a reason for hiding this comment

girarda commented Aug 6, 2022 • edited by github-actions bot Loading

girarda commented Aug 4, 2022 •

edited

Loading

girarda commented Aug 6, 2022 •

edited by github-actions bot

Loading