🐛 Destination mssql\redshift: fixed normalization tests after changes on Python side #15388

etsybaev · 2022-08-07T08:19:44Z

What

Previously we had a datetime format stored in DB as a String type after normalization. Python team recently added support for those (datetime and datatype with time zone). So our java based tests for normalization started failing.

How

Fixed java-based tests for normalization

🚨 User Impact 🚨

No user impact, only tests fixed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

…after changes on Python side

etsybaev · 2022-08-07T08:35:37Z

/test connector=connectors/destination-mssql

🕑 connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/2811974105
✅ connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/2811974105
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 13      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    13      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     157      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         168     34    80%
normalization/transform_catalog/utils.py                             51     14    73%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 589    394    33%
-------------------------------------------------------------------------------------
TOTAL                                                              1403    609    57%

Build Passed

Test summary info:

All Passed

etsybaev · 2022-08-07T08:35:52Z

/test connector=connectors/destination-redshift

🕑 connectors/destination-redshift https://github.com/airbytehq/airbyte/actions/runs/2811974854
✅ connectors/destination-redshift https://github.com/airbytehq/airbyte/actions/runs/2811974854
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 13      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    13      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     157      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         168     34    80%
normalization/transform_catalog/utils.py                             51     14    73%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 589    394    33%
-------------------------------------------------------------------------------------
TOTAL                                                              1403    609    57%

Build Passed

Test summary info:

All Passed

etsybaev · 2022-08-07T10:17:11Z

/test connector=connectors/destination-snowflake

🕑 connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/2812255538
✅ connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/2812255538
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 13      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    13      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     157      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         168     34    80%
normalization/transform_catalog/utils.py                             51     14    73%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 589    394    33%
-------------------------------------------------------------------------------------
TOTAL                                                              1403    609    57%

Build Passed

Test summary info:

All Passed

etsybaev · 2022-08-07T11:20:37Z

/test connector=connectors/destination-oracle

🕑 connectors/destination-oracle https://github.com/airbytehq/airbyte/actions/runs/2812428657
✅ connectors/destination-oracle https://github.com/airbytehq/airbyte/actions/runs/2812428657
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 13      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    13      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     157      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         168     34    80%
normalization/transform_catalog/utils.py                             51     14    73%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 589    394    33%
-------------------------------------------------------------------------------------
TOTAL                                                              1403    609    57%

Build Passed

Test summary info:

All Passed

etsybaev · 2022-08-07T11:20:52Z

/test connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/2812429491
✅ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/2812429491
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 13      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    13      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     157      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         168     34    80%
normalization/transform_catalog/utils.py                             51     14    73%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 589    394    33%
-------------------------------------------------------------------------------------
TOTAL                                                              1403    609    57%

Build Passed

Test summary info:

All Passed

etsybaev · 2022-08-07T11:21:41Z

/test connector=connectors/destination-mysql

🕑 connectors/destination-mysql https://github.com/airbytehq/airbyte/actions/runs/2812431563
✅ connectors/destination-mysql https://github.com/airbytehq/airbyte/actions/runs/2812431563
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 13      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    13      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     157      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         168     34    80%
normalization/transform_catalog/utils.py                             51     14    73%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 589    394    33%
-------------------------------------------------------------------------------------
TOTAL                                                              1403    609    57%

Build Passed

Test summary info:

All Passed

etsybaev · 2022-08-07T11:23:09Z

/test connector=connectors/destination-clickhouse

🕑 connectors/destination-clickhouse https://github.com/airbytehq/airbyte/actions/runs/2812435113
✅ connectors/destination-clickhouse https://github.com/airbytehq/airbyte/actions/runs/2812435113
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 13      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    13      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     157      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         168     34    80%
normalization/transform_catalog/utils.py                             51     14    73%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 589    394    33%
-------------------------------------------------------------------------------------
TOTAL                                                              1403    609    57%

Build Passed

Test summary info:

All Passed

etsybaev · 2022-08-07T11:23:52Z

/test connector=connectors/destination-postgres

🕑 connectors/destination-postgres https://github.com/airbytehq/airbyte/actions/runs/2812436949
✅ connectors/destination-postgres https://github.com/airbytehq/airbyte/actions/runs/2812436949
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 13      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    13      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     157      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         168     34    80%
normalization/transform_catalog/utils.py                             51     14    73%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 589    394    33%
-------------------------------------------------------------------------------------
TOTAL                                                              1403    609    57%

Build Passed

Test summary info:

All Passed

etsybaev · 2022-08-07T14:07:54Z

/test connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/2812910818
✅ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/2812910818
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 13      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    13      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     157      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         168     34    80%
normalization/transform_catalog/utils.py                             51     14    73%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 589    394    33%
-------------------------------------------------------------------------------------
TOTAL                                                              1403    609    57%

Build Passed

Test summary info:

All Passed

alexandr-shegeda

LGTM. we can proceed with merging without airbyte review

[15246, 15247] Destination mssql\redshift: fixed normalization tests …

a8c55e2

…after changes on Python side

github-actions bot added the area/connectors Connector related issues label Aug 7, 2022

octavia-squidington-iii added connectors/destination/redshift connectors/destination/mysql connectors/destination/mssql connectors/source/mssql labels Aug 7, 2022

This was linked to issues Aug 7, 2022

Destination-redshift: fix java-based normalization tests for datetime #15247

Closed

Destination-mssql: fix java-based normalization tests for datetime #15246

Closed

etsybaev changed the title ~~[15246, 15247] Destination mssql\redshift: fixed normalization tests after changes on Python side~~ 🐛 Destination mssql\redshift: fixed normalization tests after changes on Python side Aug 7, 2022

etsybaev requested a review from alexandr-shegeda August 8, 2022 07:08

alexandr-shegeda approved these changes Aug 8, 2022

View reviewed changes

etsybaev marked this pull request as ready for review August 8, 2022 07:31

etsybaev requested a review from a team as a code owner August 8, 2022 07:31

etsybaev merged commit 6f90c45 into master Aug 8, 2022

etsybaev deleted the etsybaev/15246-15247-destination-mssql-redshift-fixed-norm-tests branch August 8, 2022 07:33

octavia-squidington-iii mentioned this pull request Aug 10, 2022

Bump Airbyte version from 0.39.42-alpha to 0.40.0-alpha #15493

Merged

grishick added the team/destinations Destinations team's backlog label Nov 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Destination mssql\redshift: fixed normalization tests after changes on Python side #15388

🐛 Destination mssql\redshift: fixed normalization tests after changes on Python side #15388

etsybaev commented Aug 7, 2022 •

edited

Loading

etsybaev commented Aug 7, 2022 •

edited by github-actions bot

Loading

etsybaev commented Aug 7, 2022 •

edited by github-actions bot

Loading

etsybaev commented Aug 7, 2022 •

edited by github-actions bot

Loading

etsybaev commented Aug 7, 2022 •

edited by github-actions bot

Loading

etsybaev commented Aug 7, 2022 •

edited by github-actions bot

Loading

etsybaev commented Aug 7, 2022 •

edited by github-actions bot

Loading

etsybaev commented Aug 7, 2022 •

edited by github-actions bot

Loading

etsybaev commented Aug 7, 2022 •

edited by github-actions bot

Loading

etsybaev commented Aug 7, 2022 •

edited by github-actions bot

Loading

alexandr-shegeda left a comment

🐛 Destination mssql\redshift: fixed normalization tests after changes on Python side #15388

🐛 Destination mssql\redshift: fixed normalization tests after changes on Python side #15388

Conversation

etsybaev commented Aug 7, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

etsybaev commented Aug 7, 2022 • edited by github-actions bot Loading

Build Passed

etsybaev commented Aug 7, 2022 • edited by github-actions bot Loading

Build Passed

etsybaev commented Aug 7, 2022 • edited by github-actions bot Loading

Build Passed

etsybaev commented Aug 7, 2022 • edited by github-actions bot Loading

Build Passed

etsybaev commented Aug 7, 2022 • edited by github-actions bot Loading

Build Passed

etsybaev commented Aug 7, 2022 • edited by github-actions bot Loading

Build Passed

etsybaev commented Aug 7, 2022 • edited by github-actions bot Loading

Build Passed

etsybaev commented Aug 7, 2022 • edited by github-actions bot Loading

Build Passed

etsybaev commented Aug 7, 2022 • edited by github-actions bot Loading

Build Passed

alexandr-shegeda left a comment

Choose a reason for hiding this comment

etsybaev commented Aug 7, 2022 •

edited

Loading

etsybaev commented Aug 7, 2022 •

edited by github-actions bot

Loading

etsybaev commented Aug 7, 2022 •

edited by github-actions bot

Loading

etsybaev commented Aug 7, 2022 •

edited by github-actions bot

Loading

etsybaev commented Aug 7, 2022 •

edited by github-actions bot

Loading

etsybaev commented Aug 7, 2022 •

edited by github-actions bot

Loading

etsybaev commented Aug 7, 2022 •

edited by github-actions bot

Loading

etsybaev commented Aug 7, 2022 •

edited by github-actions bot

Loading

etsybaev commented Aug 7, 2022 •

edited by github-actions bot

Loading

etsybaev commented Aug 7, 2022 •

edited by github-actions bot

Loading