Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

14899 Update tests instance type to ATLAS #15436

Merged
merged 3 commits into from
Aug 9, 2022
Merged

14899 Update tests instance type to ATLAS #15436

merged 3 commits into from
Aug 9, 2022

Conversation

suhomud
Copy link
Contributor

@suhomud suhomud commented Aug 9, 2022

What

Source mongodb strict encrypt integration tests used wrong STANDALONE connection type

How

Updated to use ATLAS one

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

No user impact

@github-actions github-actions bot added the area/connectors Connector related issues label Aug 9, 2022
@suhomud
Copy link
Contributor Author

suhomud commented Aug 9, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-mongodb-strict-encrypt

🕑 connectors/source-mongodb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2823854044
❌ connectors/source-mongodb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2823854044
🐛 https://gradle.com/s/r5kk3v4z66fxq

Build Failed

Test summary info:

Could not find result summary

@suhomud
Copy link
Contributor Author

suhomud commented Aug 9, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-mongodb-strict-encrypt

🕑 connectors/source-mongodb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2824278275
❌ connectors/source-mongodb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2824278275
🐛 https://gradle.com/s/vjo32fnb3bagm

Build Failed

Test summary info:

Could not find result summary

@suhomud
Copy link
Contributor Author

suhomud commented Aug 9, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-mongodb-strict-encrypt

🕑 connectors/source-mongodb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2824575480
✅ connectors/source-mongodb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2824575480
No Python unittests run

Build Passed

Test summary info:

All Passed

alexandr-shegeda
alexandr-shegeda approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@alexandr-shegeda alexandr-shegeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. we can proceed with merging without airbyte review

@suhomud suhomud merged commit d057555 into master Aug 9, 2022
@suhomud suhomud deleted the suhomud/14899_source_mongodb_strict_encrypt_failing_integration_test branch August 9, 2022 10:51
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Aug 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandr-shegeda alexandr-shegeda alexandr-shegeda approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues connectors/source/mongodb-strict-encrypt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suhomud @alexandr-shegeda @octavia-squidington-iii