Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Kube Acceptance Tests and properly close the created database. #15587

Merged
merged 3 commits into from
Aug 12, 2022
Merged

Fix Kube Acceptance Tests and properly close the created database. #15587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d93817
Properly close the created database.
davinchia Aug 12, 2022
28026aa
Merge branch 'master' into davinchia/fix-normalization-tests
davinchia Aug 12, 2022
1453e27
Fix the hanging kube tests.
davinchia Aug 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions airbyte-test-utils/src/main/java/io/airbyte/test/utils/AirbyteAcceptanceTestHarness.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,7 @@ public void cleanup() {
for (final UUID destinationId : destinationIds) {
deleteDestination(destinationId);
}
destinationPsql.stop();
} catch (final Exception e) {
LOGGER.error("Error tearing down test fixtures:", e);
}
Expand Down
4 changes: 3 additions & 1 deletion ...te-tests/src/acceptanceTests/java/io/airbyte/test/acceptance/AdvancedAcceptanceTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,9 @@ void testCheckpointing() throws Exception {
// now cancel it so that we freeze state!
try {
apiClient.getJobsApi().cancelJob(new JobIdRequestBody().id(connectionSyncRead1.getJob().getId()));
} catch (final Exception e) {}
} catch (final Exception e) {
LOGGER.error("error:", e);
}

final ConnectionState connectionState = waitForConnectionState(apiClient, connectionId);

Expand Down
6 changes: 6 additions & 0 deletions kube/overlays/dev-integration-test/.env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,11 @@ JOB_MAIN_CONTAINER_CPU_LIMIT=
JOB_MAIN_CONTAINER_MEMORY_REQUEST=
JOB_MAIN_CONTAINER_MEMORY_LIMIT=

NORMALIZATION_JOB_MAIN_CONTAINER_MEMORY_LIMIT=
NORMALIZATION_JOB_MAIN_CONTAINER_MEMORY_REQUEST=
NORMALIZATION_JOB_MAIN_CONTAINER_CPU_LIMIT=
NORMALIZATION_JOB_MAIN_CONTAINER_CPU_REQUEST=

# Worker pod tolerations, annotations and node selectors
JOB_KUBE_TOLERATIONS=
JOB_KUBE_ANNOTATIONS=
Expand All @@ -64,6 +69,7 @@ JOB_KUBE_MAIN_CONTAINER_IMAGE_PULL_POLICY=

# Launch a separate pod to orchestrate sync steps
CONTAINER_ORCHESTRATOR_ENABLED=true
CONTAINER_ORCHESTRATOR_IMAGE=

# Open Telemetry Configuration
METRIC_CLIENT=
Expand Down
1 change: 1 addition & 0 deletions kube/overlays/stable/.env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ JOB_KUBE_MAIN_CONTAINER_IMAGE_PULL_POLICY=

# Launch a separate pod to orchestrate sync steps
CONTAINER_ORCHESTRATOR_ENABLED=true
CONTAINER_ORCHESTRATOR_IMAGE=

# Open Telemetry Configuration
METRIC_CLIENT=
Expand Down