Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MySQL file reader now assumes UTF8 #15709

Merged
merged 1 commit into from
Aug 17, 2022
Merged

MySQL file reader now assumes UTF8 #15709

merged 1 commit into from
Aug 17, 2022

Conversation

evantahler
Copy link
Contributor

Just like #15697, but now for MySQL - this fixes a CI/Build issue

@evantahler evantahler mentioned this pull request Aug 17, 2022
Merged
@evantahler
Copy link
Contributor Author

evantahler commented Aug 17, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/2872051473
✅ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/2872051473
No Python unittests run

Build Passed

Test summary info:

All Passed

@evantahler evantahler marked this pull request as ready for review August 17, 2022 00:52
@evantahler evantahler requested a review from a team as a code owner August 17, 2022 00:52
@evantahler evantahler requested review from lmossman and edgao and removed request for a team August 17, 2022 00:52
edgao
edgao approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm pending test success

@evantahler evantahler merged commit d009c3e into master Aug 17, 2022
@evantahler evantahler deleted the evan/mysqlCharset branch August 17, 2022 02:32
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Aug 19, 2022
Closed
@evantahler evantahler mentioned this pull request Aug 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmossman lmossman lmossman approved these changes

@edgao edgao edgao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evantahler @edgao @lmossman