Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪟 🐛 Fix transferred bytes showing as NaN #15795

Merged
merged 2 commits into from
Aug 31, 2022
Merged

🪟 🐛 Fix transferred bytes showing as NaN #15795

merged 2 commits into from
Aug 31, 2022

Conversation

robgleason
Copy link
Contributor

Show 0 bytes for cancelled sync job

What

Closes #15321

How

The UI error for ticket #15321 is being displayed by the AttemptDetails component. Within it is the FormattedMessage component that is expecting a number. I added the "or" operator, so if in case it is null then it will return zero.

Before:

Before

After:

After

Recommended reading order

  1. AttemptDetails.tsx

LOOM

https://www.loom.com/share/3c5e964138504ba6a02b05b9502233fe

@robgleason
Update AttemptDetails.tsx
7b8da50 
Show 0 bytes for cancelled sync job
@robgleason robgleason requested a review from a team as a code owner August 19, 2022 16:49
@CLAassistant
Copy link

CLAassistant commented Aug 19, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Aug 19, 2022
@timroes timroes self-assigned this Aug 19, 2022
@timroes timroes changed the title Update AttemptDetails.tsx 🪟 🐛 Fix transfered bytes showing as NaN Aug 22, 2022
@timroes timroes changed the title 🪟 🐛 Fix transfered bytes showing as NaN 🪟 🐛 Fix transferred bytes showing as NaN Aug 22, 2022
@marcosmarxm marcosmarxm mentioned this pull request Aug 29, 2022
Closed
37 tasks
@marcosmarxm marcosmarxm requested a review from timroes August 30, 2022 16:13
marcosmarxm
marcosmarxm approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @robgleason

@marcosmarxm marcosmarxm merged commit 4892a08 into airbytehq:master Aug 31, 2022
@robgleason
Copy link
Contributor Author

thanks @robgleason
@marcosmarxm Thank you! I've worked with git and PR's before, but this is my first time contributing to an Open Source project! I have also found some Java/Python issues that looked interesting, and I've been getting deep into documentation/code. I plan to offer more contributions and PR's!

@edmundito edmundito mentioned this pull request Sep 2, 2022
Merged
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Sep 2, 2022
Merged
This was referenced Sep 20, 2022
Closed
Merged
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
@robgleason @robbinhan
Frontend: update AttemptDetails.tsx (airbytehq#15795)
dc020d0 
Show 0 bytes for cancelled sync job
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmarxm marcosmarxm marcosmarxm approved these changes

@timroes timroes Awaiting requested review from timroes

Assignees

@timroes timroes

@marcosmarxm marcosmarxm

Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[webapp] Cancelled sync job shows NaN Bytes
5 participants
@robgleason @CLAassistant @marcosmarxm @timroes @octavia-squidington-iii