🐛 Source Amazon Ads: set default value for 'region' if needed #15822

grubberr · 2022-08-21T11:19:10Z

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

config.region has default value and it's non-required field
Probably better solution was initially make it 'required', but to keep backward compatibility we cannot make it 'required' now
If field 'region' is not provided we set it with default value from spec

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-08-21T11:25:05Z

/test connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2898277967
✅ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2898277967
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
source_amazon_ads/utils.py                                            9      0   100%
source_amazon_ads/streams/sponsored_products.py                      32      0   100%
source_amazon_ads/streams/sponsored_display.py                       22      0   100%
source_amazon_ads/streams/sponsored_brands.py                        17      0   100%
source_amazon_ads/streams/report_streams/products_report.py          18      0   100%
source_amazon_ads/streams/report_streams/display_report.py           16      0   100%
source_amazon_ads/streams/report_streams/brands_video_report.py      10      0   100%
source_amazon_ads/streams/report_streams/brands_report.py            10      0   100%
source_amazon_ads/streams/report_streams/__init__.py                  5      0   100%
source_amazon_ads/streams/profiles.py                                21      0   100%
source_amazon_ads/streams/__init__.py                                 6      0   100%
source_amazon_ads/schemas/sponsored_products.py                      37      0   100%
source_amazon_ads/schemas/sponsored_display.py                       31      0   100%
source_amazon_ads/schemas/sponsored_brands.py                        22      0   100%
source_amazon_ads/schemas/profile.py                                 16      0   100%
source_amazon_ads/schemas/__init__.py                                 6      0   100%
source_amazon_ads/constants.py                                        6      0   100%
source_amazon_ads/__init__.py                                         2      0   100%
source_amazon_ads/streams/common.py                                  76      1    99%
source_amazon_ads/schemas/common.py                                  51      1    98%
source_amazon_ads/streams/report_streams/report_streams.py          215     20    91%
source_amazon_ads/source.py                                          38      8    79%
-------------------------------------------------------------------------------------
TOTAL                                                               666     30    95%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       121     25    79%   21-23, 29-31, 36-43, 48-61, 208-216
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       110     48    56%   23-26, 32, 36, 39-64, 67-69, 72-74, 77-79, 82-84, 87-89, 92-110, 144-146
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1321    463    65%

Build Passed

Test summary info:

All Passed

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-08-22T13:07:44Z

/test connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2904109861
✅ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2904109861
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
source_amazon_ads/utils.py                                            9      0   100%
source_amazon_ads/streams/sponsored_products.py                      32      0   100%
source_amazon_ads/streams/sponsored_display.py                       22      0   100%
source_amazon_ads/streams/sponsored_brands.py                        17      0   100%
source_amazon_ads/streams/report_streams/products_report.py          18      0   100%
source_amazon_ads/streams/report_streams/display_report.py           16      0   100%
source_amazon_ads/streams/report_streams/brands_video_report.py      10      0   100%
source_amazon_ads/streams/report_streams/brands_report.py            10      0   100%
source_amazon_ads/streams/report_streams/__init__.py                  5      0   100%
source_amazon_ads/streams/profiles.py                                21      0   100%
source_amazon_ads/streams/__init__.py                                 6      0   100%
source_amazon_ads/schemas/sponsored_products.py                      37      0   100%
source_amazon_ads/schemas/sponsored_display.py                       31      0   100%
source_amazon_ads/schemas/sponsored_brands.py                        22      0   100%
source_amazon_ads/schemas/profile.py                                 16      0   100%
source_amazon_ads/schemas/__init__.py                                 6      0   100%
source_amazon_ads/constants.py                                        1      0   100%
source_amazon_ads/__init__.py                                         2      0   100%
source_amazon_ads/streams/common.py                                  76      1    99%
source_amazon_ads/schemas/common.py                                  51      1    98%
source_amazon_ads/streams/report_streams/report_streams.py          215     20    91%
source_amazon_ads/source.py                                          38      8    79%
-------------------------------------------------------------------------------------
TOTAL                                                               661     30    95%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       121     25    79%   21-23, 29-31, 36-43, 48-61, 208-216
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       110     48    56%   23-26, 32, 36, 39-64, 67-69, 72-74, 77-79, 82-84, 87-89, 92-110, 144-146
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1321    463    65%

Build Passed

Test summary info:

All Passed

animer3009 · 2022-08-22T15:15:13Z

Hi @grubberr why you removed regions?
We need to have regions, cuz we are getting different data by regions.
p.s. when this changes will be merged?

animer3009 · 2022-08-22T15:41:53Z

@midavadim @lazebnyi Please ASAP review changes to merge.
We are waiting to get bug fix for 11day + lol.

grubberr · 2022-08-22T17:20:56Z

@animer3009 now list of regions taken from here only
https://github.com/airbytehq/airbyte/blob/master/airbyte-integrations/connectors/source-amazon-ads/source_amazon_ads/spec.yaml#L43

OK will ask team to speed up review process

Signed-off-by: Serhii Chvaliuk <grubberr@gmail.com>

grubberr · 2022-08-23T09:39:16Z

/test connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2910485472
✅ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2910485472
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
source_amazon_ads/utils.py                                            9      0   100%
source_amazon_ads/streams/sponsored_products.py                      32      0   100%
source_amazon_ads/streams/sponsored_display.py                       22      0   100%
source_amazon_ads/streams/sponsored_brands.py                        17      0   100%
source_amazon_ads/streams/report_streams/products_report.py          18      0   100%
source_amazon_ads/streams/report_streams/display_report.py           16      0   100%
source_amazon_ads/streams/report_streams/brands_video_report.py      10      0   100%
source_amazon_ads/streams/report_streams/brands_report.py            10      0   100%
source_amazon_ads/streams/report_streams/__init__.py                  5      0   100%
source_amazon_ads/streams/profiles.py                                21      0   100%
source_amazon_ads/streams/__init__.py                                 6      0   100%
source_amazon_ads/schemas/sponsored_products.py                      37      0   100%
source_amazon_ads/schemas/sponsored_display.py                       31      0   100%
source_amazon_ads/schemas/sponsored_brands.py                        22      0   100%
source_amazon_ads/schemas/profile.py                                 16      0   100%
source_amazon_ads/schemas/__init__.py                                 6      0   100%
source_amazon_ads/constants.py                                        1      0   100%
source_amazon_ads/__init__.py                                         2      0   100%
source_amazon_ads/streams/common.py                                  76      1    99%
source_amazon_ads/schemas/common.py                                  51      1    98%
source_amazon_ads/streams/report_streams/report_streams.py          222      8    96%
source_amazon_ads/source.py                                          38      8    79%
-------------------------------------------------------------------------------------
TOTAL                                                               668     18    97%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       121     25    79%   21-23, 29-31, 36-43, 48-61, 208-216
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       110     48    56%   23-26, 32, 36, 39-64, 67-69, 72-74, 77-79, 82-84, 87-89, 92-110, 144-146
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1322    463    65%

Build Passed

Test summary info:

All Passed

grubberr · 2022-08-23T11:52:15Z

/publish connector=connectors/source-amazon-ads

grubberr · 2022-08-23T15:53:50Z

/publish connector=connectors/source-amazon-ads

🕑 Publishing the following connectors:
connectors/source-amazon-ads
https://github.com/airbytehq/airbyte/actions/runs/2912951132

Connector	Did it publish?	Were definitions generated?
connectors/source-amazon-ads	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

grubberr · 2022-08-23T20:23:44Z

@animer3009 published to docker-hub airbyte/source-amazon-ads:0.1.16
can you please test?

animer3009 · 2022-08-24T04:20:35Z

@grubberr Thank You!
It is good for now.

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

re-define configure, set default value for 'region' if needed

477dc61

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

octavia-squidington-iii added the connectors/source/amazon-ads label Aug 21, 2022

github-actions bot added the area/connectors Connector related issues label Aug 21, 2022

amazon-ads.md updated

91d8368

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

github-actions bot added the area/documentation Improvements or additions to documentation label Aug 21, 2022

grubberr self-assigned this Aug 22, 2022

grubberr requested review from lazebnyi and midavadim August 22, 2022 12:55

grubberr mentioned this pull request Aug 22, 2022

Source Amazon Ads: add case for checking if a user specified a region #15762

Closed

37 tasks

AmazonAdsRegion removed

c18a750

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr requested a review from Phlair August 22, 2022 17:21

Merge branch 'master' into grubberr/source-amazon-ads-config-default

8b477df

Signed-off-by: Serhii Chvaliuk <grubberr@gmail.com>

grubberr requested a review from davydov-d August 23, 2022 09:43

davydov-d approved these changes Aug 23, 2022

View reviewed changes

lazebnyi approved these changes Aug 23, 2022

View reviewed changes

auto-bump connector version [ci skip]

86c23ee

grubberr merged commit ccdaae4 into master Aug 23, 2022

grubberr deleted the grubberr/source-amazon-ads-config-default branch August 23, 2022 17:25

grubberr mentioned this pull request Aug 23, 2022

[EPIC] Source Amazon Ads to GA #14686

Closed

15 tasks

octavia-squidington-iii mentioned this pull request Aug 23, 2022

Bump Airbyte version from 0.40.1 to 0.40.2 #15909

Closed

octavia-squidington-iii mentioned this pull request Aug 24, 2022

Bump Airbyte version from 0.40.1 to 0.40.2 #15931

Merged

rodireich pushed a commit that referenced this pull request Aug 25, 2022

🐛 Source Amazon Ads: set default value for 'region' if needed (#15822)

9501da9

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Source Amazon Ads: set default value for 'region' if needed #15822

🐛 Source Amazon Ads: set default value for 'region' if needed #15822

grubberr commented Aug 21, 2022 •

edited

Loading

grubberr commented Aug 21, 2022 •

edited by github-actions bot

Loading

grubberr commented Aug 22, 2022 •

edited by github-actions bot

Loading

animer3009 commented Aug 22, 2022 •

edited

Loading

animer3009 commented Aug 22, 2022

grubberr commented Aug 22, 2022

grubberr commented Aug 23, 2022 •

edited by github-actions bot

Loading

grubberr commented Aug 23, 2022

grubberr commented Aug 23, 2022 •

edited by github-actions bot

Loading

grubberr commented Aug 23, 2022

animer3009 commented Aug 24, 2022 •

edited

Loading

🐛 Source Amazon Ads: set default value for 'region' if needed #15822

🐛 Source Amazon Ads: set default value for 'region' if needed #15822

Conversation

grubberr commented Aug 21, 2022 • edited Loading

What

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Tests

grubberr commented Aug 21, 2022 • edited by github-actions bot Loading

Build Passed

grubberr commented Aug 22, 2022 • edited by github-actions bot Loading

Build Passed

animer3009 commented Aug 22, 2022 • edited Loading

animer3009 commented Aug 22, 2022

grubberr commented Aug 22, 2022

grubberr commented Aug 23, 2022 • edited by github-actions bot Loading

Build Passed

grubberr commented Aug 23, 2022

grubberr commented Aug 23, 2022 • edited by github-actions bot Loading

grubberr commented Aug 23, 2022

animer3009 commented Aug 24, 2022 • edited Loading

grubberr commented Aug 21, 2022 •

edited

Loading

grubberr commented Aug 21, 2022 •

edited by github-actions bot

Loading

grubberr commented Aug 22, 2022 •

edited by github-actions bot

Loading

animer3009 commented Aug 22, 2022 •

edited

Loading

grubberr commented Aug 23, 2022 •

edited by github-actions bot

Loading

grubberr commented Aug 23, 2022 •

edited by github-actions bot

Loading

animer3009 commented Aug 24, 2022 •

edited

Loading