Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source:Kafka - Avro format message support #15827

Merged
merged 28 commits into from
Sep 13, 2022
Merged

Conversation

sivankumar86
Copy link
Contributor

What

Describe what the change is solving
User would be able to read/sync avro format message from kafka queue

How

I have added KafkaAvroSerializer API to deserialize the Avro message. Please refer
https://docs.confluent.io/platform/current/schema-registry/serdes-develop/serdes-avro.html for more details.

🚨 User Impact 🚨

This would be helpful to many users who are using avro format and want to integrate with Aribyte

It would resovles #15640 #15641

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Aug 22, 2022
@sajarin sajarin added the bounty-L Maintainer program: claimable large bounty PR label Aug 22, 2022
@sivankumar86
Copy link
Contributor Author

@marcosmarxm would it be possible to you to assist on this change review ? I would appreciate it.

@sajarin
Copy link
Contributor

sajarin commented Aug 24, 2022

Assigned to @prasrvenkat Edit: now open to maintainers

@sivankumar86
Copy link
Contributor Author

@sajarin @prasrvenkat Thanks for checking the pull request. I would appreciate your feedback and marge to master asap.

@dariof28
Copy link

dariof28 commented Sep 2, 2022

Cool! When will this be available on master?

@claudiocnc
Copy link

Waiting for this merge too... 👍

@ptkdev
Copy link

ptkdev commented Sep 2, 2022

Any news on this merge?

Copy link
Contributor

@vincentkoc vincentkoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sivankumar86 all the unit testing and changes are all good, just some cosmetic change:

  • Adding confluent maven packages to the main deps.toml
  • Reword some markdown files and spec
  • Update the rest of the docs in relation to AVRO, Schema Registry and Max Topic support ondocs/integrations/sources/kafka.md

@sivankumar86
Copy link
Contributor Author

@koconder thank you for taking a look. Could you take a look on new changes ?

@vincentkoc
Copy link
Contributor

@sivankumar86 its all good, just waiting on a final confirmation from team if we need to add new maven dep to toml file and a final intergation test

@sajarin sajarin requested a review from a team September 9, 2022 16:09
@sivankumar86
Copy link
Contributor Author

@koconder @sajarin @grishick Thank you for reviewing the changes. Could you merge to master ?

@sajarin
Copy link
Contributor

sajarin commented Sep 13, 2022

/test connector=connectors/source-kafka

🕑 connectors/source-kafka https://github.com/airbytehq/airbyte/actions/runs/3046110561
✅ connectors/source-kafka https://github.com/airbytehq/airbyte/actions/runs/3046110561
No Python unittests run

Build Passed

Test summary info:

All Passed

@sajarin
Copy link
Contributor

sajarin commented Sep 13, 2022

/publish connector=connectors/source-kafka

🕑 Publishing the following connectors:
connectors/source-kafka
https://github.com/airbytehq/airbyte/actions/runs/3046209554


Connector Did it publish? Were definitions generated?
connectors/source-kafka

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@sajarin sajarin merged commit ce64e96 into airbytehq:master Sep 13, 2022
@sajarin
Copy link
Contributor

sajarin commented Sep 13, 2022

Thanks @sivankumar86 for the PR and thank you @koconder for the review!

robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
* new format is added

* Avro support

Avro support

* new format is added

* schema namespace updated

* multi topic schema name is added

* max_records_process param is added

* review 1

* Schema registry details are added

* note update

* auto-bump connector version [ci skip]

Co-authored-by: Sajarin <sajarindider@gmail.com>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
* new format is added

* Avro support

Avro support

* new format is added

* schema namespace updated

* multi topic schema name is added

* max_records_process param is added

* review 1

* Schema registry details are added

* note update

* auto-bump connector version [ci skip]

Co-authored-by: Sajarin <sajarindider@gmail.com>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation bounty bounty-L Maintainer program: claimable large bounty PR community connectors/source/kafka reward-150
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

9 participants