-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source:Kafka - Avro format message support #15827
Conversation
@marcosmarxm would it be possible to you to assist on this change review ? I would appreciate it. |
|
@sajarin @prasrvenkat Thanks for checking the pull request. I would appreciate your feedback and marge to master asap. |
Cool! When will this be available on master? |
Waiting for this merge too... 👍 |
Any news on this merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sivankumar86 all the unit testing and changes are all good, just some cosmetic change:
- Adding confluent maven packages to the main deps.toml
- Reword some markdown files and spec
- Update the rest of the docs in relation to AVRO, Schema Registry and Max Topic support on
docs/integrations/sources/kafka.md
...tors/source-kafka/src/main/java/io/airbyte/integrations/source/kafka/KafkaFormatFactory.java
Outdated
Show resolved
Hide resolved
...s/source-kafka/src/main/java/io/airbyte/integrations/source/kafka/format/AbstractFormat.java
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-kafka/src/main/resources/spec.json
Show resolved
Hide resolved
airbyte-integrations/connectors/source-kafka/src/main/resources/spec.json
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-kafka/src/main/resources/spec.json
Show resolved
Hide resolved
@koconder thank you for taking a look. Could you take a look on new changes ? |
@sivankumar86 its all good, just waiting on a final confirmation from team if we need to add new maven dep to toml file and a final intergation test |
/test connector=connectors/source-kafka
Build PassedTest summary info:
|
/publish connector=connectors/source-kafka
if you have connectors that successfully published but failed definition generation, follow step 4 here |
Thanks @sivankumar86 for the PR and thank you @koconder for the review! |
* new format is added * Avro support Avro support * new format is added * schema namespace updated * multi topic schema name is added * max_records_process param is added * review 1 * Schema registry details are added * note update * auto-bump connector version [ci skip] Co-authored-by: Sajarin <sajarindider@gmail.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
* new format is added * Avro support Avro support * new format is added * schema namespace updated * multi topic schema name is added * max_records_process param is added * review 1 * Schema registry details are added * note update * auto-bump connector version [ci skip] Co-authored-by: Sajarin <sajarindider@gmail.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
What
Describe what the change is solving
User would be able to read/sync avro format message from kafka queue
How
I have added KafkaAvroSerializer API to deserialize the Avro message. Please refer
https://docs.confluent.io/platform/current/schema-registry/serdes-develop/serdes-avro.html for more details.
🚨 User Impact 🚨
This would be helpful to many users who are using avro format and want to integrate with Aribyte
It would resovles #15640 #15641