Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source google ads: mark custom query fields required #15858

Merged
merged 11 commits into from
Sep 15, 2022
Merged

🐛 Source google ads: mark custom query fields required #15858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e1c8031
Mark query and table_name as required
tuliren Aug 22, 2022
8ed3a65
Bump version
tuliren Aug 24, 2022
c27b6ba
bypass backward compat tests
alafanechere Aug 25, 2022
124625b
bypass backward compat tests
alafanechere Aug 25, 2022
d29f677
revert change on source-google-sheets/acceptance-test-config
alafanechere Aug 25, 2022
4620e23
Merge branch 'master' of github.com:airbytehq/airbyte into liren/onca…
tuliren Sep 5, 2022
bb7b1bc
Merge branch 'master' into liren/oncall-467-add-required-fields
davydov-d Sep 14, 2022
c010476
Merge branch 'master' into liren/oncall-467-add-required-fields
davydov-d Sep 15, 2022
c60c288
oncall 467 - source google ads: fix sats
davydov-d Sep 15, 2022
c34e205
oncall #467 source google-ads: one more SATs fix
davydov-d Sep 15, 2022
8e014dc
auto-bump connector version [ci skip]
octavia-squidington-iii Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/source_definitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@
- name: Google Ads
sourceDefinitionId: 253487c0-2246-43ba-a21f-5116b20a2c50
dockerRepository: airbyte/source-google-ads
dockerImageTag: 0.1.45
dockerImageTag: 0.2.0
documentationUrl: https://docs.airbyte.io/integrations/sources/google-ads
icon: google-adwords.svg
sourceType: api
Expand Down
5 changes: 4 additions & 1 deletion airbyte-config/init/src/main/resources/seed/source_specs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3318,7 +3318,7 @@
supportsNormalization: false
supportsDBT: false
supported_destination_sync_modes: []
- dockerImage: "airbyte/source-google-ads:0.1.45"
- dockerImage: "airbyte/source-google-ads:0.2.0"
spec:
documentationUrl: "https://docs.airbyte.com/integrations/sources/google-ads"
connectionSpecification:
Expand Down Expand Up @@ -3418,6 +3418,9 @@
order: 3
items:
type: "object"
required:
- "query"
- "table_name"
properties:
query:
type: "string"
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-google-ads/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ COPY main.py ./

ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.45
LABEL io.airbyte.version=0.2.0
LABEL io.airbyte.name=airbyte/source-google-ads
2 changes: 2 additions & 0 deletions airbyte-integrations/connectors/source-google-ads/acceptance-test-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ connector_image: airbyte/source-google-ads:dev
tests:
spec:
- spec_path: "source_google_ads/spec.json"
backward_compatibility_tests_config:
disable_for_version: "0.1.45"
connection:
- config_path: "secrets/config.json"
status: "succeed"
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-google-ads/integration_tests/test_incremental.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def test_incremental_sync(config, configured_catalog):
today = pendulum.now().date()
start_date = today.subtract(months=3)
config["start_date"] = start_date.to_date_string()

config.pop("end_date", "")
google_ads_client = SourceGoogleAds()
records = list(google_ads_client.read(logging.getLogger("airbyte"), config, ConfiguredAirbyteCatalog.parse_obj(configured_catalog)))
latest_state = None
Expand Down
1 change: 1 addition & 0 deletions airbyte-integrations/connectors/source-google-ads/source_google_ads/spec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@
"order": 3,
"items": {
"type": "object",
"required": ["query", "table_name"],
"properties": {
"query": {
"type": "string",
Expand Down
2 changes: 0 additions & 2 deletions airbyte-integrations/connectors/source-google-sheets/acceptance-test-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,3 @@ tests:
full_refresh:
- config_path: "secrets/service_config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"


89 changes: 45 additions & 44 deletions docs/integrations/sources/google-ads.md
View file
Open in desktop

Large diffs are not rendered by default.