Mssql source: add schemas during discovery #16002

sashaNeshcheret · 2022-08-26T11:02:12Z

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

sashaNeshcheret · 2022-08-26T14:16:14Z

/test connector=connectors/source-mssql

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/2934349861
❌ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/2934349861
🐛 https://gradle.com/s/ns2xk74ag3hys

Build Failed

Test summary info:

Could not find result summary

sashaNeshcheret · 2022-08-29T07:03:26Z

/test connector=connectors/source-mssql

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/2946558779
❌ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/2946558779
🐛 https://gradle.com/s/vdsxwrh5x7z3c

Build Failed

Test summary info:

Could not find result summary

…during-discovery

sashaNeshcheret · 2022-08-30T10:18:44Z

/test connector=connectors/source-mssql

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/2955429972
❌ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/2955429972
🐛 https://gradle.com/s/jyq2k3uhx5uwg

Build Failed

Test summary info:

Could not find result summary

…dd-schema-during-discovery' into omneshcheret/8014-mssql-source-add-schema-during-discovery

sashaNeshcheret · 2022-08-31T09:35:33Z

/test connector=connectors/source-mssql

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/2962809812
❌ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/2962809812
🐛 https://gradle.com/s/lns3slih3olb4

Build Failed

Test summary info:

Could not find result summary

…during-discovery

sashaNeshcheret · 2022-08-31T09:36:16Z

/test connector=connectors/source-mssql-strict-encrypt

🕑 connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2962814625
❌ connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2962814625
🐛 https://gradle.com/s/rls2vn4c27ula

Build Failed

Test summary info:

Could not find result summary

sashaNeshcheret · 2022-08-31T10:28:16Z

/test connector=connectors/source-mssql

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/2963129413
✅ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/2963129413
No Python unittests run

Build Passed

Test summary info:

All Passed

…dd-schema-during-discovery' into omneshcheret/8014-mssql-source-add-schema-during-discovery

github-actions · 2022-08-31T11:29:25Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

source-mssql
source-mssql-strict-encrypt

sashaNeshcheret · 2022-08-31T11:29:29Z

/test connector=connectors/source-mssql-strict-encrypt

🕑 connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2963483160
❌ connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2963483160
🐛 https://gradle.com/s/mpo5fg5y7q37a

Build Failed

Test summary info:

Could not find result summary

🕑 connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2963483160
✅ connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2963483160
No Python unittests run

Build Passed

Test summary info:

All Passed

github-actions · 2022-08-31T13:14:42Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

source-mssql
source-mssql-strict-encrypt

sashaNeshcheret · 2022-09-01T14:17:57Z

/test connector=connectors/source-mssql

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/2972392031
✅ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/2972392031
No Python unittests run

Build Passed

Test summary info:

All Passed

…ssql-source-add-schema-during-discovery # Conflicts: # airbyte-integrations/connectors/source-mssql/src/main/java/io/airbyte/integrations/source/mssql/MssqlSource.java

github-actions · 2022-09-02T08:30:44Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

source-mssql-strict-encrypt
source-mssql

sashaNeshcheret · 2022-09-02T08:33:24Z

/test connector=connectors/source-mssql

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/2977703425
✅ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/2977703425
No Python unittests run

Build Passed

Test summary info:

All Passed

sashaNeshcheret · 2022-09-02T08:33:46Z

/test connector=connectors/source-mssql-strict-encrypt

🕑 connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2977704648
✅ connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2977704648
No Python unittests run

Build Passed

Test summary info:

All Passed

…during-discovery

github-actions · 2022-09-05T08:33:21Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

source-mssql
source-mssql-strict-encrypt

github-actions · 2022-09-05T09:49:15Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

source-mssql-strict-encrypt
source-mssql

github-actions · 2022-09-05T10:34:02Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

source-mssql
source-mssql-strict-encrypt

sashaNeshcheret · 2022-09-05T10:34:05Z

/publish connector=connectors/source-mssql

🕑 Publishing the following connectors:
connectors/source-mssql
https://github.com/airbytehq/airbyte/actions/runs/2992533176

Connector	Did it publish?	Were definitions generated?
connectors/source-mssql	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

sashaNeshcheret · 2022-09-05T11:44:50Z

/publish connector=connectors/source-mssql-strict-encrypt

🕑 Publishing the following connectors:
connectors/source-mssql-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/2992934313

Connector	Did it publish?	Were definitions generated?
connectors/source-mssql-strict-encrypt	✅	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

* Mssql source: add schemas during discovery * Source mssql: temp changes for testing ci * Source mssql: update expected version for strict encrypt version * Source mssql: update order in spec * Source mssql: added filter by requested schemas * Source mssql: bump versions * Source mssql: format * auto-bump connector version [ci skip] Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

Mssql source: add schemas during discovery

0de35ca

github-actions bot added the area/connectors Connector related issues label Aug 26, 2022

octavia-squidington-iii added the connectors/source/mssql label Aug 26, 2022

airbytehq deleted a comment from github-actions bot Aug 26, 2022

sashaNeshcheret and others added 2 commits August 29, 2022 22:49

Merge branch 'master' into omneshcheret/8014-mssql-source-add-schema-…

2751415

…during-discovery

Merge branch 'master' into omneshcheret/8014-mssql-source-add-schema-…

5642bae

…during-discovery

sashaNeshcheret added 2 commits August 31, 2022 12:29

Source mssql: temp changes for testing ci

703e2ac

Merge remote-tracking branch 'origin/omneshcheret/8014-mssql-source-a…

3eb21a1

…dd-schema-during-discovery' into omneshcheret/8014-mssql-source-add-schema-during-discovery

Merge branch 'master' into omneshcheret/8014-mssql-source-add-schema-…

5b38aa4

…during-discovery

airbytehq deleted a comment from github-actions bot Aug 31, 2022

Source mssql: update expected version for strict encrypt version

1749f7f

octavia-squidington-iii added the connectors/source/mssql-strict-encrypt label Aug 31, 2022

Merge remote-tracking branch 'origin/omneshcheret/8014-mssql-source-a…

447586d

…dd-schema-during-discovery' into omneshcheret/8014-mssql-source-add-schema-during-discovery

Source mssql: update order in spec

74ed2fe

sashaNeshcheret added 2 commits September 2, 2022 11:27

Source mssql: added filter by requested schemas

0e18e73

Merge remote-tracking branch 'origin/master' into omneshcheret/8014-m…

5d666c3

…ssql-source-add-schema-during-discovery # Conflicts: # airbyte-integrations/connectors/source-mssql/src/main/java/io/airbyte/integrations/source/mssql/MssqlSource.java

sashaNeshcheret marked this pull request as ready for review September 2, 2022 10:07

sashaNeshcheret requested a review from a team as a code owner September 2, 2022 10:07

sashaNeshcheret requested review from VitaliiMaltsev, kimerinn and DoNotPanicUA September 2, 2022 10:08

VitaliiMaltsev approved these changes Sep 2, 2022

View reviewed changes

sashaNeshcheret linked an issue Sep 2, 2022 that may be closed by this pull request

Add ability to specify schemas to MS SQL source connector #8014

Closed

sashaNeshcheret requested review from VitaliiMaltsev and grishick September 2, 2022 12:08

grishick approved these changes Sep 2, 2022

View reviewed changes

Merge branch 'master' into omneshcheret/8014-mssql-source-add-schema-…

b6fc830

…during-discovery

github-actions bot added the area/documentation Improvements or additions to documentation label Sep 5, 2022

Source mssql: bump versions

4bd7faa

Source mssql: format

d4f4f6c

auto-bump connector version [ci skip]

d993fba

sashaNeshcheret merged commit be36bb2 into master Sep 5, 2022

sashaNeshcheret deleted the omneshcheret/8014-mssql-source-add-schema-during-discovery branch September 5, 2022 12:03

octavia-squidington-iii mentioned this pull request Sep 12, 2022

Bump Airbyte version from 0.40.4 to 0.40.5 #16610

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mssql source: add schemas during discovery #16002

Mssql source: add schemas during discovery #16002

sashaNeshcheret commented Aug 26, 2022

sashaNeshcheret commented Aug 26, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Aug 29, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Aug 30, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Aug 31, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Aug 31, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Aug 31, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Aug 31, 2022

sashaNeshcheret commented Aug 31, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Aug 31, 2022

sashaNeshcheret commented Sep 1, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Sep 2, 2022

sashaNeshcheret commented Sep 2, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Sep 2, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Sep 5, 2022

github-actions bot commented Sep 5, 2022

github-actions bot commented Sep 5, 2022

sashaNeshcheret commented Sep 5, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Sep 5, 2022 •

edited by github-actions bot

Loading

Mssql source: add schemas during discovery #16002

Mssql source: add schemas during discovery #16002

Conversation

sashaNeshcheret commented Aug 26, 2022

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

sashaNeshcheret commented Aug 26, 2022 • edited by github-actions bot Loading

Build Failed

sashaNeshcheret commented Aug 29, 2022 • edited by github-actions bot Loading

Build Failed

sashaNeshcheret commented Aug 30, 2022 • edited by github-actions bot Loading

Build Failed

sashaNeshcheret commented Aug 31, 2022 • edited by github-actions bot Loading

Build Failed

sashaNeshcheret commented Aug 31, 2022 • edited by github-actions bot Loading

Build Failed

sashaNeshcheret commented Aug 31, 2022 • edited by github-actions bot Loading

Build Passed

github-actions bot commented Aug 31, 2022

sashaNeshcheret commented Aug 31, 2022 • edited by github-actions bot Loading

Build Failed

Build Passed

github-actions bot commented Aug 31, 2022

sashaNeshcheret commented Sep 1, 2022 • edited by github-actions bot Loading

Build Passed

github-actions bot commented Sep 2, 2022

sashaNeshcheret commented Sep 2, 2022 • edited by github-actions bot Loading

Build Passed

sashaNeshcheret commented Sep 2, 2022 • edited by github-actions bot Loading

Build Passed

github-actions bot commented Sep 5, 2022

github-actions bot commented Sep 5, 2022

github-actions bot commented Sep 5, 2022

sashaNeshcheret commented Sep 5, 2022 • edited by github-actions bot Loading

sashaNeshcheret commented Sep 5, 2022 • edited by github-actions bot Loading

sashaNeshcheret commented Aug 26, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Aug 29, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Aug 30, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Aug 31, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Aug 31, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Aug 31, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Aug 31, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Sep 1, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Sep 2, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Sep 2, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Sep 5, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Sep 5, 2022 •

edited by github-actions bot

Loading