🐛 Source Facebook Marketing: remove "end_date" from config if empty value #16096

grubberr · 2022-08-29T17:38:40Z

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

Try to fix this PR https://github.com/airbytehq/oncall/issues/503
If end_date is provided as an empty string we can treat this case as missed value.

How

If end_date is provided as an empty string we remove end_date key from config.json

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-08-29T17:41:55Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2950555681
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2950555681
🐛 https://gradle.com/s/c4bmjxfeawiv6

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
================== 1 failed, 28 passed in 1340.63s (0:22:20) ===================

grubberr · 2022-08-30T09:30:22Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2955120962
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2955120962
Python tests coverage:

Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
source_facebook_marketing/streams/__init__.py                   2      0   100%
source_facebook_marketing/spec.py                              37      0   100%
source_facebook_marketing/__init__.py                           2      0   100%
source_facebook_marketing/api.py                               96     12    88%
source_facebook_marketing/streams/base_streams.py             128     27    79%
source_facebook_marketing/streams/common.py                    40     13    68%
source_facebook_marketing/streams/streams.py                  113     44    61%
source_facebook_marketing/utils.py                             25     10    60%
source_facebook_marketing/streams/base_insight_streams.py     132     54    59%
source_facebook_marketing/source.py                            53     24    55%
source_facebook_marketing/streams/async_job.py                214    134    37%
source_facebook_marketing/streams/async_job_manager.py         78     60    23%
-------------------------------------------------------------------------------
TOTAL                                                         920    378    59%
Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
source_facebook_marketing/utils.py                             25      0   100%
source_facebook_marketing/streams/common.py                    40      0   100%
source_facebook_marketing/streams/async_job.py                214      0   100%
source_facebook_marketing/streams/__init__.py                   2      0   100%
source_facebook_marketing/spec.py                              37      0   100%
source_facebook_marketing/__init__.py                           2      0   100%
source_facebook_marketing/streams/async_job_manager.py         78      3    96%
source_facebook_marketing/api.py                               96      9    91%
source_facebook_marketing/streams/base_insight_streams.py     132     13    90%
source_facebook_marketing/source.py                            53      9    83%
source_facebook_marketing/streams/streams.py                  113     26    77%
source_facebook_marketing/streams/base_streams.py             128     30    77%
-------------------------------------------------------------------------------
TOTAL                                                         920     90    90%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       121     25    79%   21-23, 29-31, 36-43, 48-61, 208-216
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       110     48    56%   23-26, 32, 36, 39-64, 67-69, 72-74, 77-79, 82-84, 87-89, 92-110, 144-146
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1322    463    65%

Build Passed

Test summary info:

All Passed

grubberr · 2022-08-30T14:49:07Z

/publish connector=connectors/source-facebook-marketing

grubberr · 2022-08-30T15:29:26Z

/publish connector=connectors/source-facebook-marketing

grubberr · 2022-08-30T18:44:16Z

/publish connector=connectors/source-facebook-marketing

🕑 Publishing the following connectors:
connectors/source-facebook-marketing
https://github.com/airbytehq/airbyte/actions/runs/2958721422

Connector	Did it publish?	Were definitions generated?
connectors/source-facebook-marketing	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

grubberr · 2022-08-30T19:28:09Z

/publish connector=connectors/source-facebook-marketing

🕑 Publishing the following connectors:
connectors/source-facebook-marketing
https://github.com/airbytehq/airbyte/actions/runs/2958987207

Connector	Did it publish?	Were definitions generated?
connectors/source-facebook-marketing	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-08-30T21:14:47Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2959610570
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2959610570
Python tests coverage:

Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
source_facebook_marketing/streams/__init__.py                   2      0   100%
source_facebook_marketing/spec.py                              37      0   100%
source_facebook_marketing/__init__.py                           2      0   100%
source_facebook_marketing/api.py                               96     12    88%
source_facebook_marketing/streams/base_streams.py             128     27    79%
source_facebook_marketing/source.py                            53     16    70%
source_facebook_marketing/streams/common.py                    40     13    68%
source_facebook_marketing/streams/streams.py                  113     44    61%
source_facebook_marketing/utils.py                             25     10    60%
source_facebook_marketing/streams/base_insight_streams.py     132     54    59%
source_facebook_marketing/streams/async_job.py                214    134    37%
source_facebook_marketing/streams/async_job_manager.py         78     60    23%
-------------------------------------------------------------------------------
TOTAL                                                         920    370    60%
Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
source_facebook_marketing/utils.py                             25      0   100%
source_facebook_marketing/streams/common.py                    40      0   100%
source_facebook_marketing/streams/async_job.py                214      0   100%
source_facebook_marketing/streams/__init__.py                   2      0   100%
source_facebook_marketing/spec.py                              37      0   100%
source_facebook_marketing/__init__.py                           2      0   100%
source_facebook_marketing/streams/async_job_manager.py         78      3    96%
source_facebook_marketing/api.py                               96      9    91%
source_facebook_marketing/streams/base_insight_streams.py     132     13    90%
source_facebook_marketing/source.py                            53      9    83%
source_facebook_marketing/streams/streams.py                  113     26    77%
source_facebook_marketing/streams/base_streams.py             128     30    77%
-------------------------------------------------------------------------------
TOTAL                                                         920     90    90%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       121     25    79%   21-23, 29-31, 36-43, 48-61, 208-216
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       110     48    56%   23-26, 32, 36, 39-64, 67-69, 72-74, 77-79, 82-84, 87-89, 92-110, 144-146
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1322    463    65%

Build Passed

Test summary info:

All Passed

grubberr · 2022-08-30T22:01:37Z

/publish connector=connectors/source-facebook-marketing

grubberr · 2022-08-31T06:51:20Z

/publish connector=connectors/source-facebook-marketing

🕑 Publishing the following connectors:
connectors/source-facebook-marketing
https://github.com/airbytehq/airbyte/actions/runs/2961837767

Connector	Did it publish?	Were definitions generated?
connectors/source-facebook-marketing	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

…alue (re-implement #16096) (#16222) Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

* master: (47 commits) Add email to identify users analytics call (#16327) 🎉 Source Amazon Ads: improve `config.start_date` validation (#16191) Add comments about intermediate state emission (#16262) MySQL Source : Standardize spec.json for DB connectors that support log-based CDC replication (#16216) MSSQL Source : Standardize spec.json for DB connectors that support log-based CDC replication (#16215) Hide a bunch more destination with potential unsecure API access (#16320) Skip unit tests when run-tests is false (#16267) Hide Destination connections from UI (#16310) Add scheduled task to clean up old files from workspace (#16247) Source Google Analytics v4: Re-name google analytics connector (#16306) 🐛 Source Facebook Marketing: remove "end_date" from config if empty value (re-implement #16096) (#16222) Fix github action syntax (#16277) Re-name google analytics cionnectors (#16287) Bump Airbyte version from 0.40.3 to 0.40.4 (#16275) Hide ES and Redis destination connectors from Cloud (#16276) 15700 add tests for PokeAPI (#15701) Add ProtocolVersion to StandardDefs (#16237) 🪟 🔧 🧹 Migrate attempt `bytesSynced` to `totalStats.bytesEmitted` and cleanup `AttemptDetails` component (#16126) Improve behavior of password input field (#16011) Improve airbyte-metrics support in the Helm chart (#16166) ...

…alue (airbytehq#16096) Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

…alue (re-implement airbytehq#16096) (airbytehq#16222) Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

configure added

fd7aa60

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

octavia-squidington-iii added the connectors/source/facebook-marketing label Aug 29, 2022

github-actions bot added the area/connectors Connector related issues label Aug 29, 2022

facebook-marketing.md updated

8168e23

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

github-actions bot added the area/documentation Improvements or additions to documentation label Aug 29, 2022

grubberr requested review from bazarnov and roman-yermilov-gl August 29, 2022 17:45

grubberr self-assigned this Aug 29, 2022

grubberr requested a review from edgao August 30, 2022 12:25

bazarnov approved these changes Aug 30, 2022

View reviewed changes

edgao approved these changes Aug 30, 2022

View reviewed changes

bazarnov approved these changes Aug 30, 2022

View reviewed changes

grubberr added 3 commits August 30, 2022 23:18

Merge branch 'master' into grubberr/oncall-503-source-facebook-marketing

38e4284

improve integration_tests

9e92a46

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

fix labels for new pydantic

23e86ef

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

auto-bump connector version [ci skip]

8201040

grubberr merged commit 3ed7f75 into master Aug 31, 2022

grubberr deleted the grubberr/oncall-503-source-facebook-marketing branch August 31, 2022 08:24

octavia-squidington-iii mentioned this pull request Sep 2, 2022

Bump Airbyte version from 0.40.3 to 0.40.4 #16275

Merged

grubberr added a commit that referenced this pull request Sep 2, 2022

🐛 Source Facebook Marketing: remove "end_date" from config if empty v…

89ae9e0

…alue (re-implement #16096) (#16222) Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

octavia-squidington-iii mentioned this pull request Sep 12, 2022

Bump Airbyte version from 0.40.4 to 0.40.5 #16610

Merged

robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022

🐛 Source Facebook Marketing: remove "end_date" from config if empty v…

235717a

…alue (airbytehq#16096) Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022

🐛 Source Facebook Marketing: remove "end_date" from config if empty v…

21682a5

…alue (re-implement airbytehq#16096) (airbytehq#16222) Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022

🐛 Source Facebook Marketing: remove "end_date" from config if empty v…

c3f0477

…alue (re-implement airbytehq#16096) (airbytehq#16222) Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Source Facebook Marketing: remove "end_date" from config if empty value #16096

🐛 Source Facebook Marketing: remove "end_date" from config if empty value #16096

grubberr commented Aug 29, 2022 •

edited

Loading

grubberr commented Aug 29, 2022 •

edited by github-actions bot

Loading

grubberr commented Aug 30, 2022 •

edited by github-actions bot

Loading

grubberr commented Aug 30, 2022

grubberr commented Aug 30, 2022

grubberr commented Aug 30, 2022 •

edited by github-actions bot

Loading

grubberr commented Aug 30, 2022 •

edited by github-actions bot

Loading

grubberr commented Aug 30, 2022 •

edited by github-actions bot

Loading

grubberr commented Aug 30, 2022

grubberr commented Aug 31, 2022 •

edited by github-actions bot

Loading

🐛 Source Facebook Marketing: remove "end_date" from config if empty value #16096

🐛 Source Facebook Marketing: remove "end_date" from config if empty value #16096

Conversation

grubberr commented Aug 29, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Tests

grubberr commented Aug 29, 2022 • edited by github-actions bot Loading

Build Failed

grubberr commented Aug 30, 2022 • edited by github-actions bot Loading

Build Passed

grubberr commented Aug 30, 2022

grubberr commented Aug 30, 2022

grubberr commented Aug 30, 2022 • edited by github-actions bot Loading

grubberr commented Aug 30, 2022 • edited by github-actions bot Loading

grubberr commented Aug 30, 2022 • edited by github-actions bot Loading

Build Passed

grubberr commented Aug 30, 2022

grubberr commented Aug 31, 2022 • edited by github-actions bot Loading

grubberr commented Aug 29, 2022 •

edited

Loading

grubberr commented Aug 29, 2022 •

edited by github-actions bot

Loading

grubberr commented Aug 30, 2022 •

edited by github-actions bot

Loading

grubberr commented Aug 30, 2022 •

edited by github-actions bot

Loading

grubberr commented Aug 30, 2022 •

edited by github-actions bot

Loading

grubberr commented Aug 30, 2022 •

edited by github-actions bot

Loading

grubberr commented Aug 31, 2022 •

edited by github-actions bot

Loading