-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Add airbyte-metrics to list of charts to be packaged #16270
Fix: Add airbyte-metrics to list of charts to be packaged #16270
Conversation
@xpuska513 Thanks for approving / merging #16166 This PR fixes the packaging of the new Helm chart that I missed in the previous PR. |
I already fixed this one in my #16131 |
@xpuska513 thanks, however would you mind merging this PR first? It seems like yours will take a little while to get reviewed/merged, and Helm chart releases are failing on master until this is fixed (also it's blocking us at Duffel as we need the metrics chart in place!) |
@xpuska513 do you think we can merge this contribution? |
Sure, don't see problem at all |
Just make sure you started https://github.com/airbytehq/airbyte/actions/workflows/publish-helm-charts.yml so the chart will be released |
Started after merging ofc 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @milesarmstrong
@xpuska513 @marcosmarxm thanks for the merge! Could one of you run the release action please? Looks like it was cancelled last night 😕? |
What
Ensure we package the new
airbyte-metrics
chart before we try to package the main chart.A follow up to #16166
Fixes the failure seen in a43c098