🐛 Source Notion: Update spec description to include working timestamp example #16272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ArneZsng
changed the title
vincentkoc
approved these changes
Sep 4, 2022
|
/test connector=connectors/source-notion |
marcosmarxm
approved these changes
Sep 5, 2022
|
@ArneZsng can you give me access to your branch to run tests and publish the new version of the connector. Also please update the Dockerfile version and connector's docuemntation changelog. |
marcosmarxm
changed the title
marcosmarxm
changed the title
github-actions
bot
added
the
area/documentation
|
@marcosmarxm Done! |
sajarin
added
internal
and removed
bounty
bounty-S
|
/publish connector=connectors/source-notion
if you have connectors that successfully published but failed definition generation, follow step 4 here |
This was referenced Sep 14, 2022
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
… example (airbytehq#16272) * Update description to include working timestamp example * Update Docker version * Update docs for Notion source connector * auto-bump connector version [ci skip] Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
… example (airbytehq#16272) * Update description to include working timestamp example * Update Docker version * Update docs for Notion source connector * auto-bump connector version [ci skip] Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Changes the description to include an actually working example for the timestamp.
How
Updating the description for the Notion source connector
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing/publishcommand described here