Add tests to various hooks #16293
Merged
Add tests to various hooks #16293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
teallarson
reviewed
Sep 6, 2022
|
I said the incorrect service above, I meant |
teallarson
approved these changes
Sep 7, 2022
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
* Move testutils to test-utils folder * Add mock data * Add analytics provider to test renderer * Add hooks.test.ts, test useUniqueFormId * Add tests for mapFormPropsToOperation and useInitialValues
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
* Move testutils to test-utils folder * Add mock data * Add analytics provider to test renderer * Add hooks.test.ts, test useUniqueFormId * Add tests for mapFormPropsToOperation and useInitialValues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Due to the size of the Connection Form Refactor PR I've split out some of the testing done there into its own PR.
Additionally,
src/test-utilswas created to hold ourtestutils.tsas well as some mock data.The AnalyticsProvider was added to our central test render wrapper.
The snapshot tests for
useInitialValueswill let us know if any changes made to the code there have unexpected consequences.Recommended reading order
Any, filter out the mock data json files.
🚨 User Impact 🚨
None. Tests will fail or the app will fail to build if this breaks anything.