Add the Osano snippet #16365
Merged
Add the Osano snippet #16365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
timroes
commented
Sep 6, 2022
| @@ -13,6 +13,12 @@ | |||
| <link rel="manifest" href="%PUBLIC_URL%/manifest.json" /> | |||
| <link rel="stylesheet" href="%PUBLIC_URL%/index.css"> | |||
| <title>Airbyte</title> | |||
| <% if (process.env.REACT_APP_OSANO) { %> | |||
| <style> | |||
| .osano-cm-widget { display: none; } | |||
There was a problem hiding this comment.
ℹ️ This is the official way to hide their widget (cookie button on the bottom of the page): https://docs.osano.com/hiding-the-cookie-widget
krishnaglick
reviewed
Sep 6, 2022
|
@krishnaglick yes That's currently expected. The widget would only show up once we activate the modal (i.e. it's not longer in just discovering mode). |
krishnaglick
approved these changes
Sep 7, 2022
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Part of https://github.com/airbytehq/airbyte-cloud/issues/2426 (Step 1)
Adds the Osano snippet to the code. At the moment this is configured only as "Scanning" in the Osano UI to collect which scripts exist.
In a separate step later we'll need to activate it to block in the UI as well as adding a link to the UI to open the drawer for users who want to open it (since we hide the default widget button).
How
I've used an environment variable to inject that directly into the index.html, since the Osano script should load as early as possible to prevent all further scripts from loading, unless the user gave consent to them.
This currently requires though to have that parameter available at build time. Thus if we'd later only want to enable that in Cloud we'll need to either move this into index.tsx and use the window.CLOUD parameter or need to build the frontend for each environment. Since the latter is anyway our plan I already added that, and try to move forward with Infra and the Config Provider refactoring, that we can actually move the FE to be build separate for each environment until we want to enable this (it's anyway not clear right now if we want to enable that only in CLoud or also in OSS).