Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove US/Pacific-New timezone #16385

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Remove US/Pacific-New timezone #16385

merged 1 commit into from
Sep 7, 2022

Conversation

pmossman
Copy link
Contributor

@pmossman pmossman commented Sep 6, 2022

This timezone causes an issue on our branch with Micronaut, some sort of dependency disagreement about whether or not this timezone exists. Also, apparently it's a whole thing moment/moment-timezone#498

I don't think anybody would intentionally choose 'US/Pacific-New' over 'US/Pacific' regardless of whether or not it was valid.

@pmossman pmossman requested a review from a team as a code owner September 6, 2022 23:38
@github-actions github-actions bot added area/platform issues related to the platform area/server area/frontend Related to the Airbyte webapp labels Sep 6, 2022
@pmossman pmossman temporarily deployed to more-secrets September 6, 2022 23:39 Inactive
Copy link
Contributor

@mfsiega-airbyte mfsiega-airbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pmossman pmossman merged commit 790343e into master Sep 7, 2022
@pmossman pmossman deleted the parker/timezone-fix branch September 7, 2022 03:03
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform area/server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants