Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proplerly render extraContainers #16474

Merged
merged 10 commits into from
Sep 13, 2022
2 changes: 2 additions & 0 deletions charts/airbyte-bootloader/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# Charts are downloaded at install time with `helm dep build`.
charts
2 changes: 1 addition & 1 deletion charts/airbyte-bootloader/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: "0.39.36"
version: "0.45.2"

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
29 changes: 17 additions & 12 deletions charts/airbyte-bootloader/templates/pod.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -90,18 +90,23 @@ spec:
{{- toYaml .Values.extraEnv | nindent 8 }}
{{- end }}

{{- if .Values.resources }}
resources: {{- toYaml .Values.resources | nindent 8 }}
{{- if .Values.extraVolumeMounts }}
{{- end }}
{{- if .Values.extraVolumeMounts }}
volumeMounts:
{{- toYaml .Values.extraVolumeMounts | nindent 8 }}
{{- end }}
{{- if .Values.extraContainers }}
{{ toYaml .Values.extraContainers | indent 4 }}
{{- end }}
{{- if .Values.global.extraContainers }}
{{ toYaml .Values.global.extraContainers | indent 4 }}
{{- end }}
{{- if .Values.extraVolumes }}
{{- toYaml .Values.extraVolumeMounts | nindent 8 }}
{{- end }}
{{- if .Values.containerSecurityContext }}
securityContext: {{- toYaml .Values.containerSecurityContext | nindent 8 }}
{{- end }}
{{- if .Values.extraContainers }}
{{ toYaml .Values.extraContainers | nindent 4 }}
{{- end }}
{{- if .Values.global.extraContainers }}
{{ toYaml .Values.global.extraContainers | indent 4 }}
{{- end }}
{{- if .Values.extraVolumes }}
volumes:
{{- toYaml .Values.extraVolumes | nindent 2 }}
{{- end }}
{{- toYaml .Values.extraVolumes | nindent 4 }}
{{- end }}
26 changes: 16 additions & 10 deletions charts/airbyte-bootloader/values.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

## global.serviceAccountName Name of service account to be associated with service
## deploymentMode Determines deployment mode of airbyte
## secretName Overrides the secrate name with with credentials to S3 Bucket and logging
Expand All @@ -13,6 +12,8 @@ global:
database:
secretName: ""
secretValue: ""
host: "example.com"
port: "5432"
secrets: {}
env_vars: {}
extraContainers: []
Expand All @@ -30,6 +31,14 @@ image:
##
podAnnotations: {}

## containerSecurityContext Security context for the container
## Examples:
## containerSecurityContext:
## runAsNonRoot: true
## runAsUser: 1000
## readOnlyRootFilesystem: true
containerSecurityContext: {}

## nodeSelector [object] Node labels for pod assignment
## Ref: https://kubernetes.io/docs/user-guide/node-selection/
##
Expand All @@ -49,16 +58,15 @@ tolerations: []
## bootloader.resources.limits [object] The resources limits for the airbyte bootloader image
## bootloader.resources.requests [object] The requested resources for the airbyte bootloader image
resources:
## Example:
## requests:
## memory: 256Mi
## cpu: 250m
requests: {}
## Example:
## limits:
## cpu: 200m
## memory: 1Gi
limits: {}
## requests:
## memory: 256Mi
## cpu: 250m
requests: {}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This aligns this section to be the same as the other charts in the repo.


## affinity [object] Affinity and anti-affinity for bootloader pod assignment.
## ref: https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#affinity-and-anti-affinity
Expand Down Expand Up @@ -100,14 +108,14 @@ affinity: {}
## key: DATABASE_USER
##
extraEnv: []

## secrets [object] Supply additional secrets to container
## Example:
## secrets:
## DATABASE_PASSWORD: strong-password
## DATABASE_USER: my-db-user
secrets: {}


## extraContainer [array] Additional container for server pod(s)
## Example:
# extraContainers:
Expand Down Expand Up @@ -161,6 +169,4 @@ extraVolumes: []
# DATABASE_URL: jdbc:postgresql://airbyte-db-svc:5432/airbyte
# DATABASE_PASSWORD: 12345
# DATABASE_USER: airbyte


env_vars: {}
env_vars: {}
2 changes: 1 addition & 1 deletion charts/airbyte-metrics/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: "0.39.36"
version: "0.45.2"

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
18 changes: 10 additions & 8 deletions charts/airbyte-metrics/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -107,24 +107,26 @@ spec:
{{- if .Values.extraEnv }}
{{- toYaml .Values.extraEnv | nindent 8 }}
{{- end }}

{{- if .Values.resources }}
resources: {{- toYaml .Values.resources | nindent 10 }}
resources:
{{- toYaml .Values.resources | nindent 10 }}
{{- end }}
{{- if .Values.containerSecurityContext }}
securityContext: {{- toYaml .Values.containerSecurityContext | nindent 10 }}
securityContext:
{{- toYaml .Values.containerSecurityContext | nindent 10 }}
{{- end }}
volumeMounts:
{{- if .Values.extraVolumeMounts }}
{{ toYaml .Values.extraVolumeMounts | nindent 8 }}
volumeMounts:
{{ toYaml .Values.extraVolumeMounts | nindent 10 }}
{{- end }}
{{- if .Values.extraContainers }}
{{ toYaml .Values.extraContainers | indent 8 }}
{{ toYaml .Values.extraContainers | nindent 6 }}
{{- end }}
{{- if .Values.global.extraContainers }}
{{ toYaml .Values.global.extraContainers | indent 8 }}
{{ toYaml .Values.global.extraContainers | nindent 6 }}
{{- end }}
volumes:
{{- if .Values.extraVolumes }}
{{ toYaml .Values.extraVolumes | nindent 6 }}
{{ toYaml .Values.extraVolumes | nindent 6 }}
{{- end }}
2 changes: 2 additions & 0 deletions charts/airbyte-server/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# Charts are downloaded at install time with `helm dep build`.
charts
2 changes: 1 addition & 1 deletion charts/airbyte-server/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: "0.39.36"
version: 0.45.2

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
2 changes: 1 addition & 1 deletion charts/airbyte-server/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ spec:
{{- if .Values.extraEnv }}
{{- toYaml .Values.extraEnv | nindent 8 }}
{{- end }}

{{- if .Values.livenessProbe.enabled }}
livenessProbe:
httpGet:
Expand Down
2 changes: 2 additions & 0 deletions charts/airbyte-temporal/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# Charts are downloaded at install time with `helm dep build`.
charts
2 changes: 1 addition & 1 deletion charts/airbyte-temporal/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: "0.39.36"
version: "0.45.2"

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
2 changes: 1 addition & 1 deletion charts/airbyte-temporal/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ spec:
{{- if .Values.extraContainers }}
{{ toYaml .Values.extraContainers | indent 6 }}
{{- end }}
{{- if .Values.global.extraConrainers }}
{{- if .Values.global.extraContainers }}
{{ toYaml .Values.global.extraContainers | indent 6 }}
{{- end }}
volumes:
Expand Down
2 changes: 2 additions & 0 deletions charts/airbyte-webapp/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# Charts are downloaded at install time with `helm dep build`.
charts
2 changes: 1 addition & 1 deletion charts/airbyte-webapp/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: "0.39.36"
version: "0.45.2"

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
6 changes: 3 additions & 3 deletions charts/airbyte-webapp/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -125,10 +125,10 @@ spec:
{{ toYaml .Values.global.extraVolumeMounts | nindent 8 }}
{{- end }}
{{- if .Values.extraContainers }}
{{ toYaml .Values.extraContainers | indent 8 }}
{{ toYaml .Values.extraContainers | nindent 6 }}
{{- end }}
{{- if .Values.global.extraConrainers }}
{{ toYaml .Values.global.extraContainers | indent 8 }}
{{- if .Values.global.extraContainers }}
{{ toYaml .Values.global.extraContainers | nindent 6 }}
{{- end }}
volumes:
{{- if .Values.extraVolumes }}
Expand Down
2 changes: 2 additions & 0 deletions charts/airbyte-worker/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# Charts are downloaded at install time with `helm dep build`.
charts
2 changes: 1 addition & 1 deletion charts/airbyte-worker/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: "0.39.36"
version: "0.45.2"

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
2 changes: 1 addition & 1 deletion charts/airbyte/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.39.36
version: 0.45.2

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
2 changes: 2 additions & 0 deletions charts/airbyte/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -789,6 +789,8 @@ worker:
##
extraVolumes: []

extraContainers: []

hpa:
enabled: false
## Container Orchestrator
Expand Down