Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪟 🐛 Namespace changes should be reflected in sync catalog table #16643

Merged
merged 5 commits into from
Sep 14, 2022
Merged

🪟 🐛 Namespace changes should be reflected in sync catalog table #16643

merged 5 commits into from
Sep 14, 2022

Conversation

teallarson
Copy link
Contributor

@teallarson teallarson commented Sep 13, 2022 •
edited
Loading

What

Previously, the Namespace column in the sync catalog always showed <destination schema> regardless of what namespace option was chosen. This was a regression that was introduced when we moved typings around with the Generated API Client.

Screen Shot 2022-09-13 at 11 54 04 AM

How

Fixed a broken switch statement

@github-actions github-actions bot added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Sep 13, 2022
@teallarson
Copy link
Contributor Author

@andyjih I think you're the right person to ask. New behavior with this PR:

  • User picks "Destination Default" --> sync catalog shows <destination schema>
  • User picks "Custom Format" --> sync catalog shows whatever is entered in the custom format input
  • User picks "Mirror Source Structure" --> sync catalog shows ??

The options are:

  • ${SOURCE_NAMESPACE} which is the default custom format, and is how our backend saves the data
  • I think <source schema> would make more sense in this table to have parity with the Destination option? But maybe there is more significance to option 1 than I understand.

@teallarson teallarson marked this pull request as ready for review September 13, 2022 15:56
@teallarson teallarson requested a review from a team as a code owner September 13, 2022 15:56
@teallarson teallarson changed the title 🪟 🐛 bug fix for custom namespace 🪟 🐛 Namespace changes should be reflected in sync catalog table Sep 13, 2022
@SofiiaZaitseva SofiiaZaitseva mentioned this pull request Sep 14, 2022
Closed
@teallarson teallarson merged commit 5687cef into master Sep 14, 2022
@teallarson teallarson deleted the teal/custom-namespace-bug-fix branch September 14, 2022 16:49
This was referenced Sep 14, 2022
Closed
Merged
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
@teallarson @robbinhan
🪟 🐛 Namespace changes should be reflected in sync catalog table (airb…
d2aedcb 
…ytehq#16643)

* bug fix for custom namespace

* cleanup types and returns
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
@teallarson @jhammarstedt
🪟 🐛 Namespace changes should be reflected in sync catalog table (airb…
54c6b46 
…ytehq#16643)

* bug fix for custom namespace

* cleanup types and returns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishnaglick krishnaglick krishnaglick approved these changes

Assignees
No one assigned
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teallarson @krishnaglick