🎉 Source Snowflake : Update JDBC driver for Snowflake to 3.13.22 #16766

akashkulk · 2022-09-15T00:16:57Z

What

🎉 Source Snowflake : Per this build, Airbyte is currently using version 3.13.9 of the JDBC drive for Snowflake. That driver is almost a year old and should be updated to the latest version 3.13.22, as of the creation of this ticket. We should consider updating our driver as well as putting in a mechanism to keep it updated on an ongoing basis.

Link for the repo with all of the drivers:
https://repo1.maven.org/maven2/net/snowflake/snowflake-jdbc/

Resolve #16552

How

Update the driver to the latest version (3.13.22)

Pre-merge Checklist (connector update)

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

CLAassistant · 2022-09-15T00:17:02Z

All committers have signed the CLA.

github-actions · 2022-09-15T00:17:43Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

destination-snowflake
source-snowflake

tuliren · 2022-09-15T00:51:46Z

@akashkulk, don't forget to sign the CLA.

tuliren

Please also bump the connector version in the dockerfile.

tuliren · 2022-09-15T02:35:27Z

/test connector=connectors/source-snowflake

🕑 connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/3057412352
❌ connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/3057412352
🐛 https://gradle.com/s/rgprbtrm2arsq

Build Failed

Test summary info:

Could not find result summary

tuliren · 2022-09-15T02:35:33Z

/test connector=connectors/destination-snowflake

🕑 connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/3057413050
❌ connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/3057413050
🐛 https://gradle.com/s/tfmwancrq4cec

Build Failed

Test summary info:

Could not find result summary

akashkulk · 2022-09-15T14:54:31Z

/test connector=connectors/destination-snowflake

🕑 connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/3061470044
❌ connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/3061470044
🐛 https://gradle.com/s/zkrlq64g73ioi

Build Failed

Test summary info:

Could not find result summary

akashkulk · 2022-09-15T14:55:16Z

/test connector=connectors/source-snowflake

🕑 connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/3061477663
❌ connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/3061477663
🐛 https://gradle.com/s/k2q6cqjipkdqi

Build Failed

Test summary info:

Could not find result summary

github-actions · 2022-09-15T14:55:49Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

source-snowflake
destination-snowflake

… into akashkulk/snowflake-jdbc-driver

github-actions · 2022-09-15T16:55:41Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

destination-snowflake
source-snowflake

akashkulk · 2022-09-15T16:56:37Z

/test connector=connectors/source-snowflake

🕑 connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/3062256924
❌ connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/3062256924
🐛 https://gradle.com/s/dyaqz5makpdys

Build Failed

Test summary info:

Could not find result summary

akashkulk · 2022-09-15T16:56:51Z

/test connector=connectors/destination-snowflake

🕑 connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/3062258072
❌ connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/3062258072
🐛 https://gradle.com/s/yke74alvxmb6y

Build Failed

Test summary info:

Could not find result summary

github-actions · 2022-09-15T16:57:51Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

source-snowflake
destination-snowflake

tuliren

The version bump is correct~~
You should also update the changelog in source/snowflake.md and destination/snowflake.md.
The test failure seems persistent and related to the version bump. For example, the source always had two failed integration tests. Can you take a look into the root cause? Do they pass locally?

… into akashkulk/snowflake-jdbc-driver

github-actions · 2022-09-15T19:10:06Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

destination-snowflake
source-snowflake

akashkulk · 2022-09-15T19:10:34Z

/test connector=connectors/source-snowflake

🕑 connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/3063044233
❌ connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/3063044233
🐛 https://gradle.com/s/pilrnepownraa

Build Failed

Test summary info:

Could not find result summary

… into akashkulk/snowflake-jdbc-driver

github-actions · 2022-09-19T15:18:13Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

source-snowflake

github-actions · 2022-09-21T17:24:14Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

source-snowflake

akashkulk · 2022-09-21T17:50:41Z

/test connector=connectors/source-snowflake

🕑 connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/3099970026
✅ connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/3099970026
No Python unittests run

Build Passed

Test summary info:

All Passed

tuliren

Nice!

Can you go through the pre-merge checklist and check off the items accordingly? For example, you should update the CHANGELOG in snowflake.md to add the information about the new version.

github-actions · 2022-09-21T22:37:45Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

source-snowflake

github-actions · 2022-09-21T22:39:19Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

source-snowflake

akashkulk · 2022-09-21T22:48:47Z

Nice!

Can you go through the pre-merge checklist and check off the items accordingly? For example, you should update the CHANGELOG in snowflake.md to add the information about the new version.

Thanks. I've checked off the relevant items. Just to confirm - after you approve these changes, I should (i) publish the new docker image and then (ii) merge the PR, correct?

github-actions · 2022-09-21T22:49:53Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

source-snowflake

akashkulk · 2022-09-21T22:51:16Z

/publish connector=connectors/source-snowflake run-tests=false

🕑 Publishing the following connectors:
connectors/source-snowflake
https://github.com/airbytehq/airbyte/actions/runs/3101628032

Connector	Did it publish?	Were definitions generated?
connectors/source-snowflake	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

github-actions · 2022-09-21T23:04:34Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

source-snowflake

…bytehq#16766) Update JDBC driver for Snowflake Co-authored-by: Liren Tu <tuliren.git@outlook.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

Update JDBC driver for Snowflake

1c1727f

akashkulk requested a review from a team as a code owner September 15, 2022 00:16

github-actions bot added the area/connectors Connector related issues label Sep 15, 2022

octavia-squidington-iii added connectors/destination/snowflake connectors/source/snowflake labels Sep 15, 2022

tuliren reviewed Sep 15, 2022

View reviewed changes

Merge branch 'master' into akashkulk/snowflake-jdbc-driver

398bd5b

akashkulk added 2 commits September 15, 2022 09:54

Update JDBC driver for Snowflake

0570b89

Merge remote-tracking branch 'origin/akashkulk/snowflake-jdbc-driver'…

1054bba

… into akashkulk/snowflake-jdbc-driver

Merge branch 'master' into akashkulk/snowflake-jdbc-driver

824f921

tuliren reviewed Sep 15, 2022

View reviewed changes

akashkulk added 2 commits September 15, 2022 12:08

Merge remote-tracking branch 'origin/akashkulk/snowflake-jdbc-driver'…

ee3f408

… into akashkulk/snowflake-jdbc-driver

Merge remote-tracking branch 'origin/akashkulk/snowflake-jdbc-driver'…

e133840

… into akashkulk/snowflake-jdbc-driver

github-actions bot added the area/documentation Improvements or additions to documentation label Sep 15, 2022

akashkulk added 2 commits September 15, 2022 17:36

Merge remote-tracking branch 'origin/akashkulk/snowflake-jdbc-driver'…

17eb0b0

… into akashkulk/snowflake-jdbc-driver

Merge remote-tracking branch 'origin/akashkulk/snowflake-jdbc-driver'…

06c1660

… into akashkulk/snowflake-jdbc-driver

akashkulk changed the title ~~🎉 Destination & Source Snowflake : Update JDBC driver for Snowflake~~ 🎉 Source Snowflake : Update JDBC driver for Snowflake Sep 19, 2022

Merge branch 'master' into akashkulk/snowflake-jdbc-driver

ed26fec

Merge branch 'master' into akashkulk/snowflake-jdbc-driver

c614fbe

akashkulk marked this pull request as ready for review September 21, 2022 17:24

akashkulk changed the title ~~🎉 Source Snowflake : Update JDBC driver for Snowflake~~ 🎉 Source Snowflake : Update JDBC driver for Snowflake to 3.13.22 Sep 21, 2022

tuliren approved these changes Sep 21, 2022

View reviewed changes

Update snowflake.md

96af8b3

Update snowflake.md

eff4945

Merge branch 'master' into akashkulk/snowflake-jdbc-driver

d004100

octavia-squidington-iii and others added 2 commits September 21, 2022 23:00

auto-bump connector version [ci skip]

22b8e6f

Merge branch 'master' into akashkulk/snowflake-jdbc-driver

8374a84

akashkulk temporarily deployed to more-secrets September 21, 2022 23:06 Inactive

akashkulk merged commit 44ef1c4 into master Sep 21, 2022

akashkulk deleted the akashkulk/snowflake-jdbc-driver branch September 21, 2022 23:07

This was referenced Sep 22, 2022

Bump Airbyte version from 0.40.8 to 0.40.9 #17060

Closed

Bump Airbyte version from 0.40.8 to 0.40.9 #17093

Merged

prateekmukhedkar mentioned this pull request Sep 27, 2023

[source-snowflake] Update Snowflake JDBC drivers #30548

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Source Snowflake : Update JDBC driver for Snowflake to 3.13.22 #16766

🎉 Source Snowflake : Update JDBC driver for Snowflake to 3.13.22 #16766

akashkulk commented Sep 15, 2022 •

edited

Loading

CLAassistant commented Sep 15, 2022 •

edited

Loading

github-actions bot commented Sep 15, 2022

tuliren commented Sep 15, 2022

tuliren left a comment

tuliren commented Sep 15, 2022 •

edited by github-actions bot

Loading

tuliren commented Sep 15, 2022 •

edited by github-actions bot

Loading

akashkulk commented Sep 15, 2022 •

edited by github-actions bot

Loading

akashkulk commented Sep 15, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Sep 15, 2022

github-actions bot commented Sep 15, 2022

akashkulk commented Sep 15, 2022 •

edited by github-actions bot

Loading

akashkulk commented Sep 15, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Sep 15, 2022

tuliren left a comment

github-actions bot commented Sep 15, 2022

akashkulk commented Sep 15, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Sep 19, 2022

github-actions bot commented Sep 21, 2022

akashkulk commented Sep 21, 2022 •

edited by github-actions bot

Loading

tuliren left a comment

github-actions bot commented Sep 21, 2022

github-actions bot commented Sep 21, 2022

akashkulk commented Sep 21, 2022

github-actions bot commented Sep 21, 2022

akashkulk commented Sep 21, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Sep 21, 2022

🎉 Source Snowflake : Update JDBC driver for Snowflake to 3.13.22 #16766

🎉 Source Snowflake : Update JDBC driver for Snowflake to 3.13.22 #16766

Conversation

akashkulk commented Sep 15, 2022 • edited Loading

What

How

Pre-merge Checklist (connector update)

Community member or Airbyter

Airbyter

CLAassistant commented Sep 15, 2022 • edited Loading

github-actions bot commented Sep 15, 2022

tuliren commented Sep 15, 2022

tuliren left a comment

Choose a reason for hiding this comment

tuliren commented Sep 15, 2022 • edited by github-actions bot Loading

Build Failed

tuliren commented Sep 15, 2022 • edited by github-actions bot Loading

Build Failed

akashkulk commented Sep 15, 2022 • edited by github-actions bot Loading

Build Failed

akashkulk commented Sep 15, 2022 • edited by github-actions bot Loading

Build Failed

github-actions bot commented Sep 15, 2022

github-actions bot commented Sep 15, 2022

akashkulk commented Sep 15, 2022 • edited by github-actions bot Loading

Build Failed

akashkulk commented Sep 15, 2022 • edited by github-actions bot Loading

Build Failed

github-actions bot commented Sep 15, 2022

tuliren left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 15, 2022

akashkulk commented Sep 15, 2022 • edited by github-actions bot Loading

Build Failed

github-actions bot commented Sep 19, 2022

github-actions bot commented Sep 21, 2022

akashkulk commented Sep 21, 2022 • edited by github-actions bot Loading

Build Passed

tuliren left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 21, 2022

github-actions bot commented Sep 21, 2022

akashkulk commented Sep 21, 2022

github-actions bot commented Sep 21, 2022

akashkulk commented Sep 21, 2022 • edited by github-actions bot Loading

github-actions bot commented Sep 21, 2022

akashkulk commented Sep 15, 2022 •

edited

Loading

CLAassistant commented Sep 15, 2022 •

edited

Loading

tuliren commented Sep 15, 2022 •

edited by github-actions bot

Loading

tuliren commented Sep 15, 2022 •

edited by github-actions bot

Loading

akashkulk commented Sep 15, 2022 •

edited by github-actions bot

Loading

akashkulk commented Sep 15, 2022 •

edited by github-actions bot

Loading

akashkulk commented Sep 15, 2022 •

edited by github-actions bot

Loading

akashkulk commented Sep 15, 2022 •

edited by github-actions bot

Loading

akashkulk commented Sep 15, 2022 •

edited by github-actions bot

Loading

akashkulk commented Sep 21, 2022 •

edited by github-actions bot

Loading

akashkulk commented Sep 21, 2022 •

edited by github-actions bot

Loading