Source AlloyDB: add strict-encrypt version #16776

yurii-bidiuk · 2022-09-15T16:09:48Z

What

How

Added a strict-encrypt version for source AlloyDB

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

github-actions · 2022-09-15T16:10:50Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

source-postgres-strict-encrypt
source-alloydb
source-alloydb-strict-encrypt

yurii-bidiuk · 2022-09-15T16:12:37Z

/test connector=connectors/source-alloydb

🕑 connectors/source-alloydb https://github.com/airbytehq/airbyte/actions/runs/3062008452
✅ connectors/source-alloydb https://github.com/airbytehq/airbyte/actions/runs/3062008452
No Python unittests run

Build Passed

Test summary info:

All Passed

yurii-bidiuk · 2022-09-15T16:14:04Z

/test connector=connectors/source-alloydb-strict-encrypt

🕑 connectors/source-alloydb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3062017438
✅ connectors/source-alloydb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3062017438
No Python unittests run

Build Passed

Test summary info:

All Passed

yurii-bidiuk · 2022-09-15T16:19:03Z

/test connector=connectors/source-postgres-strict-encrypt

🕑 connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3062047529
✅ connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3062047529
No Python unittests run

Build Passed

Test summary info:

All Passed

...encrypt/src/main/java/io/airbyte/integrations/source/alloydb/AlloyDbStrictEncryptSource.java

alexandr-shegeda

LGTM, we can proceed with publishing and merging without airbyte review

github-actions · 2022-09-19T13:22:10Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

source-postgres-strict-encrypt
source-alloydb
source-alloydb-strict-encrypt

yurii-bidiuk · 2022-09-19T13:22:46Z

/test connector=connectors/source-alloydb

🕑 connectors/source-alloydb https://github.com/airbytehq/airbyte/actions/runs/3082745937
✅ connectors/source-alloydb https://github.com/airbytehq/airbyte/actions/runs/3082745937
No Python unittests run

Build Passed

Test summary info:

All Passed

yurii-bidiuk · 2022-09-19T13:22:55Z

/test connector=connectors/source-alloydb-strict-encrypt

🕑 connectors/source-alloydb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3082747834
✅ connectors/source-alloydb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3082747834
No Python unittests run

Build Passed

Test summary info:

All Passed

yurii-bidiuk · 2022-09-19T13:23:04Z

/test connector=connectors/source-postgres-strict-encrypt

🕑 connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3082748271
✅ connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3082748271
No Python unittests run

Build Passed

Test summary info:

All Passed

yurii-bidiuk · 2022-09-19T13:58:22Z

/publish connector=connectors/source-alloydb

🕑 Publishing the following connectors:
connectors/source-alloydb
https://github.com/airbytehq/airbyte/actions/runs/3082991775

Connector	Did it publish?	Were definitions generated?
connectors/source-alloydb	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

yurii-bidiuk · 2022-09-19T13:58:44Z

/publish connector=connectors/source-alloydb-strict-encrypt

🕑 Publishing the following connectors:
connectors/source-alloydb-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/3082993717

Connector	Did it publish?	Were definitions generated?
connectors/source-alloydb-strict-encrypt	✅	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

* Source AlloyDB: add strict-encrypt version * auto-bump connector version [ci skip] Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Sep 15, 2022

octavia-squidington-iii added connectors/source/postgres connectors/source/alloydb connectors/source/alloydb-strict-encrypt labels Sep 15, 2022

yurii-bidiuk requested review from etsybaev and alexandr-shegeda September 15, 2022 16:12

alexandr-shegeda reviewed Sep 16, 2022

View reviewed changes

...encrypt/src/main/java/io/airbyte/integrations/source/alloydb/AlloyDbStrictEncryptSource.java Show resolved Hide resolved

alexandr-shegeda approved these changes Sep 19, 2022

View reviewed changes

Source AlloyDB: add strict-encrypt version

d3d22fd

yurii-bidiuk force-pushed the bidiuk/16613-alloydb-strict-encrypt branch from 9e80b6a to d3d22fd Compare September 19, 2022 13:21

auto-bump connector version [ci skip]

289ed11

yurii-bidiuk marked this pull request as ready for review September 19, 2022 15:07

yurii-bidiuk requested a review from a team as a code owner September 19, 2022 15:07

yurii-bidiuk merged commit dacf381 into master Sep 19, 2022

yurii-bidiuk deleted the bidiuk/16613-alloydb-strict-encrypt branch September 19, 2022 15:08

octavia-squidington-iii mentioned this pull request Sep 21, 2022

Bump Airbyte version from 0.40.7 to 0.40.8 #17009

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source AlloyDB: add strict-encrypt version #16776

Source AlloyDB: add strict-encrypt version #16776

yurii-bidiuk commented Sep 15, 2022

github-actions bot commented Sep 15, 2022

yurii-bidiuk commented Sep 15, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Sep 15, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Sep 15, 2022 •

edited by github-actions bot

Loading

alexandr-shegeda left a comment

github-actions bot commented Sep 19, 2022

yurii-bidiuk commented Sep 19, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Sep 19, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Sep 19, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Sep 19, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Sep 19, 2022 •

edited by github-actions bot

Loading

Source AlloyDB: add strict-encrypt version #16776

Source AlloyDB: add strict-encrypt version #16776

Conversation

yurii-bidiuk commented Sep 15, 2022

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

github-actions bot commented Sep 15, 2022

yurii-bidiuk commented Sep 15, 2022 • edited by github-actions bot Loading

Build Passed

yurii-bidiuk commented Sep 15, 2022 • edited by github-actions bot Loading

Build Passed

yurii-bidiuk commented Sep 15, 2022 • edited by github-actions bot Loading

Build Passed

alexandr-shegeda left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 19, 2022

yurii-bidiuk commented Sep 19, 2022 • edited by github-actions bot Loading

Build Passed

yurii-bidiuk commented Sep 19, 2022 • edited by github-actions bot Loading

Build Passed

yurii-bidiuk commented Sep 19, 2022 • edited by github-actions bot Loading

Build Passed

yurii-bidiuk commented Sep 19, 2022 • edited by github-actions bot Loading

yurii-bidiuk commented Sep 19, 2022 • edited by github-actions bot Loading

yurii-bidiuk commented Sep 15, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Sep 15, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Sep 15, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Sep 19, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Sep 19, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Sep 19, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Sep 19, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Sep 19, 2022 •

edited by github-actions bot

Loading